[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097912#comment-16097912
]
ASF GitHub Bot commented on THRIFT-4260:
Github user taozle closed the pull request at:
GitHub user taozle reopened a pull request:
https://github.com/apache/thrift/pull/1312
Add context as first arg for client method.
Related: https://issues.apache.org/jira/browse/THRIFT-4260
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097913#comment-16097913
]
ASF GitHub Bot commented on THRIFT-4260:
GitHub user taozle reopened a pull request:
Github user taozle closed the pull request at:
https://github.com/apache/thrift/pull/1312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1312
Travis failures seem unrelated.
cc @Jens-G
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user taozle commented on the issue:
https://github.com/apache/thrift/pull/1309
I will try to fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097625#comment-16097625
]
ASF GitHub Bot commented on THRIFT-4260:
GitHub user taozle opened a pull request:
GitHub user taozle opened a pull request:
https://github.com/apache/thrift/pull/1312
Add context as first arg for client method.
Related: https://issues.apache.org/jira/browse/THRIFT-4260
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097597#comment-16097597
]
Can Celasun commented on THRIFT-4260:
-
Yes, because the client is auto generated from the source
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097594#comment-16097594
]
taozle commented on THRIFT-4260:
The commit is intended to add the context in only server side, and i
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1309
Ah, now I see it. The Makefile for the tutorial has the `legacy_context`
flag hardcoded, since it's pinned to the Go version included in the Docker
container. If you are running it outside the
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097592#comment-16097592
]
Can Celasun commented on THRIFT-4260:
-
Yes, there seems to be a bug with the generated code for the
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097590#comment-16097590
]
Jens Geyer commented on THRIFT-4260:
Hi Baas,
I know quite well what the actual problem is, that's
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097586#comment-16097586
]
Bas van Beek edited comment on THRIFT-4260 at 7/23/17 10:22 AM:
That will
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097586#comment-16097586
]
Bas van Beek commented on THRIFT-4260:
--
That will not work for Go unless I would vendor the Go
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1309
go version go1.8.3 windows/amd64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-4260:
---
Priority: Blocker (was: Major)
> Go context generation issue. Context is parameter in Interface not
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-4260:
--
Assignee: taozle
> Go context generation issue. Context is parameter in Interface not in
>
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097581#comment-16097581
]
Jens Geyer edited comment on THRIFT-4260 at 7/23/17 10:03 AM:
--
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097581#comment-16097581
]
Jens Geyer commented on THRIFT-4260:
{quote}Unfortunately the Go library was updated before a new
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bas van Beek updated THRIFT-4260:
-
Description:
Unfortunately the Go library was updated before a new Compiler was released.
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bas van Beek updated THRIFT-4260:
-
Description:
Unfortunately the Go library was updated before a new Compiler was released.
[
https://issues.apache.org/jira/browse/THRIFT-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bas van Beek updated THRIFT-4260:
-
Description:
Unfortunately the Go library was updated before a new Compiler was released.
Bas van Beek created THRIFT-4260:
Summary: Go context generation issue. Context is parameter in
Interface not in implementation
Key: THRIFT-4260
URL: https://issues.apache.org/jira/browse/THRIFT-4260
24 matches
Mail list logo
