[jira] [Commented] (THRIFT-4049) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178074#comment-16178074 ] ASF GitHub Bot commented on THRIFT-4049: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1371: THRIFT-4049, THRIFT-4053: when skipping, if field...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1371 THRIFT-4049, THRIFT-4053: when skipping, if field type is invalid thr… …ow a protocol exception of invalid data instead of doing nothing You can merge this pull request into a Git repository

[jira] [Assigned] (THRIFT-4049) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4049: -- Assignee: James E. King, III > Skip() should throw

[jira] [Assigned] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4050: -- Assignee: Gonzalo Aguilar > Skip() should throw

[jira] [Commented] (THRIFT-4050) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178073#comment-16178073 ] James E. King, III commented on THRIFT-4050: [~gad] would you be able to add the necessary

[jira] [Assigned] (THRIFT-4053) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

[ https://issues.apache.org/jira/browse/THRIFT-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4053: -- Assignee: James E. King, III > Skip() should throw

[jira] [Commented] (THRIFT-4207) Accelerated version of TBinaryProtocol allows invalid input to string fields.

[ https://issues.apache.org/jira/browse/THRIFT-4207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178070#comment-16178070 ] James E. King, III commented on THRIFT-4207: You didn't enable push rights for committers so

[jira] [Commented] (THRIFT-4229) Make thrift-maven-plugin threadSafe

[ https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178068#comment-16178068 ] James E. King, III commented on THRIFT-4229: Does anyone have a patch to provide to resolve

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

[ https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4229: --- Affects Version/s: (was: 0.11.0) > Make thrift-maven-plugin threadSafe >

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

[ https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4229: --- Fix Version/s: (was: 0.11.0) > Make thrift-maven-plugin threadSafe >

[jira] [Updated] (THRIFT-4229) Make thrift-maven-plugin threadSafe

[ https://issues.apache.org/jira/browse/THRIFT-4229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4229: --- Component/s: Build Process > Make thrift-maven-plugin threadSafe >

[jira] [Commented] (THRIFT-4000) Add union test to Test Suite

[ https://issues.apache.org/jira/browse/THRIFT-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178067#comment-16178067 ] James E. King, III commented on THRIFT-4000: Committed but reopened? > Add union test to

[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

[ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178066#comment-16178066 ] James E. King, III commented on THRIFT-4026: Current CI job uses Python 2.7.12. > TSSLSocket

[jira] [Closed] (THRIFT-4028) Please remove System.out.format from the source code

[ https://issues.apache.org/jira/browse/THRIFT-4028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-4028. -- Resolution: Duplicate Assignee: James E. King, III > Please remove

[jira] [Resolved] (THRIFT-2740) Perl coding standards

[ https://issues.apache.org/jira/browse/THRIFT-2740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-2740. Resolution: Fixed Fix Version/s: 0.11.0 > Perl coding standards >

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

[ https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16178008#comment-16178008 ] ASF GitHub Bot commented on THRIFT-4309: Github user cclauss commented on the issue:

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

Github user cclauss commented on the issue: https://github.com/apache/thrift/pull/1339 This makes sense to me. Please merge this PR when you are ready but we must do further work in another PR before THRIFT-4309 is complete. There are three alternative approaches to running

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

[ https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177991#comment-16177991 ] ASF GitHub Bot commented on THRIFT-4309: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1339 What you suggest is that our build process is insufficient to catch these things, and I would like to see our build process become sufficient and enhanced with whatever tools are needed to make

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177989#comment-16177989 ] ASF GitHub Bot commented on THRIFT-4329: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1361 multic is for compact and multi is for binary they are backwards compatible so one can use a binary client against a multi server (which is why you will see servers with "binary:multi"

[jira] [Commented] (THRIFT-4309) All Python files should be compatible with Python 3

[ https://issues.apache.org/jira/browse/THRIFT-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177874#comment-16177874 ] ASF GitHub Bot commented on THRIFT-4309: Github user cclauss commented on the issue:

[GitHub] thrift issue #1339: THRIFT-4309 Python print() function

Github user cclauss commented on the issue: https://github.com/apache/thrift/pull/1339 @jeking3 All of the __print() is a function__ changes are ESSENTIAL Python 3 compatibility. This is not optional. See: https://docs.python.org/3/whatsnew/3.0.html The reason that you are

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177857#comment-16177857 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 What's multic and multi. What's the difference? ---

[jira] [Resolved] (THRIFT-4288) Implement logging levels properly for node.js

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4288. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > Implement

[GitHub] thrift pull request #1334: THRIFT-4288: Implement log.js

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1334 ---

[jira] [Commented] (THRIFT-4288) Implement logging levels properly for node.js

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177788#comment-16177788 ] ASF GitHub Bot commented on THRIFT-4288: Github user asfgit closed the pull request at:

[jira] [Assigned] (THRIFT-4288) Implement logging levels properly for node.js

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4288: -- Assignee: James E. King, III > Implement logging levels properly for node.js

[jira] [Updated] (THRIFT-4288) Implement logging levels properly for node.js

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4288: --- Summary: Implement logging levels properly for node.js (was: Implement logging

[jira] [Updated] (THRIFT-4288) Implement logging properly for node.js (instead of using console)

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4288: --- Summary: Implement logging properly for node.js (instead of using console) (was:

[jira] [Commented] (THRIFT-4288) Implement log utilities.

[ https://issues.apache.org/jira/browse/THRIFT-4288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177743#comment-16177743 ] ASF GitHub Bot commented on THRIFT-4288: Github user Equim-chan commented on the issue:

[GitHub] thrift issue #1334: THRIFT-4288: Implement log.js

Github user Equim-chan commented on the issue: https://github.com/apache/thrift/pull/1334 @jeking3 done. ---

[jira] [Commented] (THRIFT-4329) c_glib Doesn't have a multiplexed processor

[ https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177656#comment-16177656 ] ASF GitHub Bot commented on THRIFT-4329: Github user gadLinux commented on the issue:

[GitHub] thrift issue #1361: THRIFT-4329: Implement multiplexed processor that matche...

Github user gadLinux commented on the issue: https://github.com/apache/thrift/pull/1361 Now seems ok. This is another big change. So I will try to do cross tests after. Meanwhile I cross validated with Java. Already in production with this stuff... ---

[jira] [Commented] (THRIFT-4251) Java Epoll Selector Bug

[ https://issues.apache.org/jira/browse/THRIFT-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16177649#comment-16177649 ] ASF GitHub Bot commented on THRIFT-4251: Github user xiaohu-zhang commented on the issue:

[GitHub] thrift issue #1313: THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSele...

Github user xiaohu-zhang commented on the issue: https://github.com/apache/thrift/pull/1313 Thank you ! honestly speaking , netty and lots of framework implementing this fix. I also doubt It is useful in jdk7. I agree with you ,But if I was you , I will not change the original