Please respond to THRIFT-4062

2017-10-23 Thread Christopher
Could the Thrift developers please respond to the repeated requests from half a dozen different individuals to release a version 0.10.1 with the fix in https://issues.apache.org/jira/browse/THRIFT-4062 ? This is a critical issue, and need not wait until 0.11 or later. The fix is trivial, and all

[GitHub] thrift pull request #1306: Fix Nodejs generation to auto deal with args clas...

2017-10-23 Thread wenshin
Github user wenshin closed the pull request at: https://github.com/apache/thrift/pull/1306 ---

[GitHub] thrift issue #1306: Fix Nodejs generation to auto deal with args class insta...

2017-10-23 Thread wenshin
Github user wenshin commented on the issue: https://github.com/apache/thrift/pull/1306 @jeking3 Thanks for your nice reply, it's duplicate of #1034, I'll close this one. ---

[jira] [Commented] (THRIFT-4062) Remove debug print from TServiceClient

2017-10-23 Thread kenneth mcfarland (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216272#comment-16216272 ] kenneth mcfarland commented on THRIFT-4062: --- Is there any chance this fix will be released soon

[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension

2017-10-23 Thread RobberPhex
Github user RobberPhex commented on the issue: https://github.com/apache/thrift/pull/1391 @jeking3 Currently, I just remove PHP5 support at PHP extension(thrift_protocol), PHP library is still support PHP5. So, I think this PR is good. --- If PHP5

Re: PR to remove PHP5 support

2017-10-23 Thread Robert Lu
Hi, PHP library is still support PHP5 and PHP7 (>=5.3.0). but, PHP extension (thrift_protocol) will just support PHP7, doesn't support PHP5. -- Robert Lu On 10/24/17 11:16, James E. King, III wrote: Hi folks, There is a PR on the table that will remove PHP5 support in favor of PHP7 and

[GitHub] thrift issue #1391: Fix segment fault at thrift_protocol extension

2017-10-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1391 I posted a message on the developer mailing list about removing php5 support. We'll see what comes of it. php5 is currently still shipping so I have some reservations about removing support for

PR to remove PHP5 support

2017-10-23 Thread James E. King, III
Hi folks, There is a PR on the table that will remove PHP5 support in favor of PHP7 and fixing an crashing bug. I wanted to bring it up on the mailing list to gather any objections. https://github.com/apache/thrift/pull/1391 Thanks, Jim

[jira] [Commented] (THRIFT-4037) [CMake] Use a single build system for thrift to make development easier

2017-10-23 Thread Robert Lu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216225#comment-16216225 ] Robert Lu commented on THRIFT-4037: --- Personally, I'd like to migrate to cmake. But, I haven't

[jira] [Updated] (THRIFT-4305) Emit ddoc for generated items

2017-10-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4305: --- Priority: Minor (was: Major) > Emit ddoc for generated items >

[jira] [Resolved] (THRIFT-4305) Emit ddoc for generated items

2017-10-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4305. Resolution: Fixed Fix Version/s: 0.11.0 > Emit ddoc for generated items >

[GitHub] thrift issue #1392: Fix missing positional argument

2017-10-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1392 I opened THRIFT-4367 for this. ---

[jira] [Created] (THRIFT-4367) python TProcessor.process is missing "self"

2017-10-23 Thread James E. King, III (JIRA)
James E. King, III created THRIFT-4367: -- Summary: python TProcessor.process is missing "self" Key: THRIFT-4367 URL: https://issues.apache.org/jira/browse/THRIFT-4367 Project: Thrift

[jira] [Commented] (THRIFT-4367) python TProcessor.process is missing "self"

2017-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215674#comment-16215674 ] ASF GitHub Bot commented on THRIFT-4367: Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-4305) Emit ddoc for generated items

2017-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215642#comment-16215642 ] ASF GitHub Bot commented on THRIFT-4305: Github user asfgit closed the pull request at:

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

2017-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215643#comment-16215643 ] ASF GitHub Bot commented on THRIFT-4306: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1395: THRIFT-4306 dlang: public imports for dependencie...

2017-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1395 ---

[GitHub] thrift pull request #1396: THRIFT-4305 Doc comments in dlang output

2017-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1396 ---

[jira] [Commented] (THRIFT-4305) Emit ddoc for generated items

2017-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215597#comment-16215597 ] ASF GitHub Bot commented on THRIFT-4305: Github user jeking3 commented on the issue:

[jira] [Assigned] (THRIFT-4305) Emit ddoc for generated items

2017-10-23 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4305: -- Assignee: James E. King, III > Emit ddoc for generated items >

[GitHub] thrift issue #1396: THRIFT-4305 Doc comments in dlang output

2017-10-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1396 Manually inspecting the result in a sandbox. ---

[jira] [Commented] (THRIFT-4306) Thrift imports not replicated to D service output

2017-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215573#comment-16215573 ] ASF GitHub Bot commented on THRIFT-4306: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1395: THRIFT-4306 dlang: public imports for dependencies

2017-10-23 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1395 @jfarrell please close this, it was merged in commit 44701e82ad351d7472101ad81aa13e775ffb7384 ---

[GitHub] thrift pull request #1397: change DOCKER_ env vars for travis integration to...

2017-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1397 ---