[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16243490#comment-16243490 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on a diff in the pull

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149592614 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242918#comment-16242918 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jfarrell commented on a diff in the pull request:

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242884#comment-16242884 ] ASF GitHub Bot commented on THRIFT-82: -- Github user Jens-G commented on a diff in the pull request:

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user jfarrell commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149508723 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149504639 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242791#comment-16242791 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on a diff in the pull

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242788#comment-16242788 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on a diff in the pull

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242803#comment-16242803 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on a diff in the pull

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149491753 --- Diff: lib/cl/ensure-externals.sh --- @@ -0,0 +1,12 @@ +#!/bin/sh + +set -e + +if [ ! -d "externals/" ] ; then --- End diff

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149489770 --- Diff: lib/cl/server.lisp --- @@ -0,0 +1,230 @@ +(in-package #:org.apache.thrift.implementation) --- End diff -- it is a common

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user dkochmanski commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149489004 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242696#comment-16242696 ] ASF GitHub Bot commented on THRIFT-82: -- Github user Jens-G commented on the issue:

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242692#comment-16242692 ] ASF GitHub Bot commented on THRIFT-82: -- Github user Jens-G commented on a diff in the pull request:

[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support

Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1410 @jfarrell: What's your opinion re the (c) things above? ---

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user Jens-G commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149475953 --- Diff: lib/cl/framed-transport.lisp --- @@ -0,0 +1,136 @@ +(in-package #:org.apache.thrift.implementation) + + Copyright 2017 Rigetti

[GitHub] thrift pull request #1411: Fix remote client for HTTP transport

GitHub user trotterdylan opened a pull request: https://github.com/apache/thrift/pull/1411 Fix remote client for HTTP transport This change fixes two issues: - Assign parsedUrl to the variable in the outer scope instead of creating a new one. Previously the outer parsedUrl

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242506#comment-16242506 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jfarrell commented on the issue:

[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support

Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1410 Travis requests show an error with "Abuse detected". I've emailed Travis support asking them to look into the issue ---

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242484#comment-16242484 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on a diff in the pull request:

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242486#comment-16242486 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue:

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242483#comment-16242483 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on a diff in the pull request:

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149446200 --- Diff: lib/cl/ensure-externals.sh --- @@ -0,0 +1,12 @@ +#!/bin/sh + +set -e + +if [ ! -d "externals/" ] ; then --- End diff --

[GitHub] thrift issue #1410: THRIFT-82: Add Common Lisp support

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1410 Without a linux build, won't be able to do any merges... ---

[GitHub] thrift pull request #1410: THRIFT-82: Add Common Lisp support

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1410#discussion_r149446453 --- Diff: lib/cl/server.lisp --- @@ -0,0 +1,230 @@ +(in-package #:org.apache.thrift.implementation) --- End diff -- Does one need the

[jira] [Created] (THRIFT-4380) Compiler incorrect generates code which treats a Java enum as a binary type

Christopher Tubbs created THRIFT-4380: - Summary: Compiler incorrect generates code which treats a Java enum as a binary type Key: THRIFT-4380 URL: https://issues.apache.org/jira/browse/THRIFT-4380