[
https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264876#comment-16264876
]
Chet Murthy commented on THRIFT-4392:
-
Oh, didn't see that PRs are preferred. Sent a PR with same
GitHub user chetmurthy opened a pull request:
https://github.com/apache/thrift/pull/1417
THRIFT-4392 reorder structs in plugin.thrift
build thrift, generated ocaml from plugin.thrift, verified that compile
fails.
then applied patch, rebuild thrift, regen ocaml, recompile and
[
https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264875#comment-16264875
]
ASF GitHub Bot commented on THRIFT-4392:
GitHub user chetmurthy opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chet Murthy updated THRIFT-4392:
Attachment: patch
here's a patch
> compiler//plugin.thrift structs mis-ordered blows up ocaml
[
https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264867#comment-16264867
]
Chet Murthy commented on THRIFT-4392:
-
Attaching a patch (against current thrift master, but it works
Chet Murthy created THRIFT-4392:
---
Summary: compiler//plugin.thrift structs mis-ordered blows up
ocaml generator
Key: THRIFT-4392
URL: https://issues.apache.org/jira/browse/THRIFT-4392
Project:
[
https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264543#comment-16264543
]
Allen George commented on THRIFT-4390:
--
It's really unclear to me why I'd need more than 4K though -
[
https://issues.apache.org/jira/browse/THRIFT-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264278#comment-16264278
]
Michael Eiler edited comment on THRIFT-4384 at 11/23/17 12:49 PM:
--
[
https://issues.apache.org/jira/browse/THRIFT-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264278#comment-16264278
]
Michael Eiler commented on THRIFT-4384:
---
Currently I solved the problem for us like shown here: