[jira] [Commented] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-23 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264876#comment-16264876 ] Chet Murthy commented on THRIFT-4392: - Oh, didn't see that PRs are preferred. Sent a PR with same

[GitHub] thrift pull request #1417: THRIFT-4392 reorder structs in plugin.thrift

2017-11-23 Thread chetmurthy
GitHub user chetmurthy opened a pull request: https://github.com/apache/thrift/pull/1417 THRIFT-4392 reorder structs in plugin.thrift build thrift, generated ocaml from plugin.thrift, verified that compile fails. then applied patch, rebuild thrift, regen ocaml, recompile and

[jira] [Commented] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264875#comment-16264875 ] ASF GitHub Bot commented on THRIFT-4392: GitHub user chetmurthy opened a pull request:

[jira] [Updated] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-23 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chet Murthy updated THRIFT-4392: Attachment: patch here's a patch > compiler//plugin.thrift structs mis-ordered blows up ocaml

[jira] [Commented] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-23 Thread Chet Murthy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264867#comment-16264867 ] Chet Murthy commented on THRIFT-4392: - Attaching a patch (against current thrift master, but it works

[jira] [Created] (THRIFT-4392) compiler/..../plugin.thrift structs mis-ordered blows up ocaml generator

2017-11-23 Thread Chet Murthy (JIRA)
Chet Murthy created THRIFT-4392: --- Summary: compiler//plugin.thrift structs mis-ordered blows up ocaml generator Key: THRIFT-4392 URL: https://issues.apache.org/jira/browse/THRIFT-4392 Project:

[jira] [Commented] (THRIFT-4390) Rust socket class cannot handle binary output larger than 4096 bytes

2017-11-23 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264543#comment-16264543 ] Allen George commented on THRIFT-4390: -- It's really unclear to me why I'd need more than 4K though -

[jira] [Comment Edited] (THRIFT-4384) Using multiple services simultaneously is not thread-safe.

2017-11-23 Thread Michael Eiler (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264278#comment-16264278 ] Michael Eiler edited comment on THRIFT-4384 at 11/23/17 12:49 PM: --

[jira] [Commented] (THRIFT-4384) Using multiple services simultaneously is not thread-safe.

2017-11-23 Thread Michael Eiler (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264278#comment-16264278 ] Michael Eiler commented on THRIFT-4384: --- Currently I solved the problem for us like shown here: