[jira] [Commented] (THRIFT-4416) Perl CPAN Packaging Improvements

2017-12-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288480#comment-16288480 ] James E. King, III commented on THRIFT-4416: With the changes in place I was able to upload

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1440 My initial take on this is that the conflation of transport and protocol in general is not a good thing for Thrift. It limits the flexibility to use one interchangeably with something else, but

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2017-12-12 Thread Jens-G
Github user Jens-G commented on the issue: https://github.com/apache/thrift/pull/1440 Plus chinese comments should be english. ---

[jira] [Commented] (THRIFT-4422) Add Async implementation via IFuture

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288448#comment-16288448 ] ASF GitHub Bot commented on THRIFT-4422: GitHub user Jens-G opened a pull request:

[GitHub] thrift pull request #1444: THRIFT-4422 Add Async implementation via IFuture

2017-12-12 Thread Jens-G
GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1444 THRIFT-4422 Add Async implementation via IFuture Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (THRIFT-4422) Add Async implementation via IFuture

2017-12-12 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4422: --- Description: Add optional implementation of an {{IAsync}} interface loosely modeled after the C#

[jira] [Created] (THRIFT-4422) Add Async implementation via IFuture

2017-12-12 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4422: -- Summary: Add Async implementation via IFuture Key: THRIFT-4422 URL: https://issues.apache.org/jira/browse/THRIFT-4422 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-4421) golang tests rely on gomock, which has change behaviour, causing tests to fail

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288346#comment-16288346 ] ASF GitHub Bot commented on THRIFT-4421: GitHub user chetmurthy opened a pull request:

[GitHub] thrift pull request #1443: THRIFT-4421 golang tests rely on gomock, which ha...

2017-12-12 Thread chetmurthy
GitHub user chetmurthy opened a pull request: https://github.com/apache/thrift/pull/1443 THRIFT-4421 golang tests rely on gomock, which has change behaviour, … …causing tests to fail After each call to mockCtrl.Finish() where the controller might get used later, put

[jira] [Created] (THRIFT-4421) golang tests rely on gomock, which has change behaviour, causing tests to fail

2017-12-12 Thread Chet Murthy (JIRA)
Chet Murthy created THRIFT-4421: --- Summary: golang tests rely on gomock, which has change behaviour, causing tests to fail Key: THRIFT-4421 URL: https://issues.apache.org/jira/browse/THRIFT-4421

Re: golang tests fail (due to new gomock behaviour)

2017-12-12 Thread Chet Murthy
Not sure what you mean by "backwards compatible", but (a) this change affects only tests (b) the reason it's needed is that the golang tests pull in gomock, but without a specific version. So anybody who runs tests starting 11/28 is going to pull in the new gomock, and need this patch, I

Re: golang tests fail (due to new gomock behaviour)

2017-12-12 Thread James E. King, III
Hi Chet, I don't know go that well, but I appreciate your effort on go and rust lately - thank you. In terms of this, as long as it's backwards compatible then I think we're good. - Jim On Tue, Dec 12, 2017 at 3:56 PM, Chet Murthy wrote: > Synopsis: "make check" in

golang tests fail (due to new gomock behaviour)

2017-12-12 Thread Chet Murthy
Synopsis: "make check" in lib/go fails b/c gomock no longer allows multiple Finish() calls on a gomock Controller. that change was made on 11/28/17. I'm just finishing a PR that will fix this, but figured maybe I should post it too. As you can see, it's pretty simplistic -- just reNew the

[jira] [Commented] (THRIFT-4413) Publish a Maven artifact for Thrift v0.11

2017-12-12 Thread Yufan Gong (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288199#comment-16288199 ] Yufan Gong commented on THRIFT-4413: Awesome! Excited about this new version. Do you have a release

[jira] [Resolved] (THRIFT-4412) thrift cmake does not use absolute library path, linking system libraries

2017-12-12 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer resolved THRIFT-4412. -- Resolution: Won't Fix [~jking3] I thik you are right and this issue is too broad for

[jira] [Closed] (THRIFT-4412) thrift cmake does not use absolute library path, linking system libraries

2017-12-12 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer closed THRIFT-4412. > thrift cmake does not use absolute library path, linking system libraries >

[jira] [Commented] (THRIFT-4408) Some unicode characters can't be parsed with Thrift Java

2017-12-12 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287670#comment-16287670 ] James E. King, III commented on THRIFT-4408: Is this still an issue in thrift-0.11.0? > Some

Re: Does dlang build on ubuntu-xenial work for anyone?

2017-12-12 Thread James E. King, III
I have disabled dlang for "make cross" in the Ubuntu Xenial based builds because everything fails. Both of the deimos libraries it depends on only support older distributions, which means those code paths are dead. If we want libevent and openssl dlang support we need to find another way to do it.

[GitHub] thrift issue #1442: 0.11.0

2017-12-12 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1442 This is not the right forum to ask for a build related question. Use Apache Jira. You didn't specify which compiler or platform you are using. My guess is your gcc suite is too old.

[jira] [Commented] (THRIFT-4408) Some unicode characters can't be parsed with Thrift Java

2017-12-12 Thread Sergey Krutsko (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287504#comment-16287504 ] Sergey Krutsko commented on THRIFT-4408: Could someone from the community take a look at this?