[jira] [Commented] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311883#comment-16311883 ] ASF GitHub Bot commented on THRIFT-4373: Github user sokac commented on the issue

[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2018-01-04 Thread sokac
Github user sokac commented on the issue: https://github.com/apache/thrift/pull/1401 @jeking3 squashed and rebased. Looks like CI has some troubles, though ---

[jira] [Commented] (THRIFT-82) Common Lisp support

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311422#comment-16311422 ] James E. King, III commented on THRIFT-82: -- I am going to start the process of com

[jira] [Commented] (THRIFT-3983) libthrift is deployed on central with pom packaging instead of jar

2018-01-04 Thread RobberPhex (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311420#comment-16311420 ] RobberPhex commented on THRIFT-3983: This issue can be closed. > libthrift is deploy

[jira] [Commented] (THRIFT-4373) Extending Thrift class results in "Attempt serialize from non-Thrift object"

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311418#comment-16311418 ] ASF GitHub Bot commented on THRIFT-4373: Github user jeking3 commented on the iss

[jira] [Commented] (THRIFT-4354) TSocket block on read

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311416#comment-16311416 ] ASF GitHub Bot commented on THRIFT-4354: Github user jeking3 commented on the iss

[GitHub] thrift issue #1401: THRIFT-4373: Derefer PHP zval _TSPEC

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1401 Need to see if pass the CI build - please squash to a single commit, rebase on master, and force push. ---

[GitHub] thrift issue #1384: THRIFT-4354 TSocket block on read

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1384 Let's get another CI build going on this. ---

[GitHub] thrift issue #1440: Enhancement binary_protocol with frametransport

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1440 I would need to see comments from other folks who use thrift go, and also I need to see a linux build pass, so please rebase on master and force push to kick a new build. ---

[GitHub] thrift pull request #1446: Insert files related to eclipse project to gitign...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1446 ---

[GitHub] thrift issue #1446: Insert files related to eclipse project to gitignore

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1446 In the future please file a Jira ticket for changes. Given this is trivial and not distributed in the final product, I will waive off the requirement. ---

[jira] [Commented] (THRIFT-4434) Update .NET Core components, add tests for .Net Core library and .Net Core compiler, fix bugs and build process

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311404#comment-16311404 ] ASF GitHub Bot commented on THRIFT-4434: Github user jeking3 commented on the iss

[GitHub] thrift issue #1449: THRIFT-4434. Update .NET Core components, add tests for ...

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1449 One of the problems I had moving to netcore 2.0 was that the cross tests would pass as a client, but hang as a server, so I disabled them. If the cross tests pass that will go a long way to proving

[GitHub] thrift pull request #1430: Fix generated maven packaging

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1430 ---

[GitHub] thrift pull request #1456: THRIFT-3983: Fix generated maven packaging

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1456 ---

[GitHub] thrift pull request #1442: 0.11.0

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1442 ---

[jira] [Commented] (THRIFT-3983) libthrift is deployed on central with pom packaging instead of jar

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311398#comment-16311398 ] ASF GitHub Bot commented on THRIFT-3983: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-4438) require php ^5.6 || ^7.0

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311397#comment-16311397 ] James E. King, III commented on THRIFT-4438: I have an issue with the "delete

[jira] [Commented] (THRIFT-4436) Deserialization of nested list discards content

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311393#comment-16311393 ] ASF GitHub Bot commented on THRIFT-4436: Github user jeking3 commented on the iss

[GitHub] thrift issue #1454: THRIFT-4436: port nodejs changes from THRIFT-3748 to js ...

2018-01-04 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1454 Suggest you rebase on master, as the fix for the build issue with dart was merged, and it would be nice to see a clean build. ---

[jira] [Commented] (THRIFT-4439) Shouldn't download dart.deb directly.

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311385#comment-16311385 ] ASF GitHub Bot commented on THRIFT-4439: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4439) Shouldn't download dart.deb directly.

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4439. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks! > Shouldn't dow

[GitHub] thrift pull request #1453: THRIFT-4439: use dartlang repo instead of downloa...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1453 ---

[jira] [Resolved] (THRIFT-4406) JavaScript: Use modern Promise implementations

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4406. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.12.0

[GitHub] thrift pull request #1452: THRIFT-4406: ES6 compatible JavaScript with Promi...

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1452 ---

[jira] [Commented] (THRIFT-4406) JavaScript: Use modern Promise implementations

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311376#comment-16311376 ] ASF GitHub Bot commented on THRIFT-4406: Github user asfgit closed the pull reque

[jira] [Assigned] (THRIFT-4440) rm `build/docker/ubuntu-trusty/Dockerfile.orig`

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4440: -- Assignee: James E. King, III > rm `build/docker/ubuntu-trusty/Dockerfile.orig`

[jira] [Commented] (THRIFT-4440) rm `build/docker/ubuntu-trusty/Dockerfile.orig`

2018-01-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311370#comment-16311370 ] ASF GitHub Bot commented on THRIFT-4440: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4440) rm `build/docker/ubuntu-trusty/Dockerfile.orig`

2018-01-04 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4440. Resolution: Fixed Fix Version/s: 0.12.0 > rm `build/docker/ubuntu-trusty/Doc

[GitHub] thrift pull request #1455: THRIFT-4440: cleanup *.orig

2018-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1455 ---

[jira] [Created] (THRIFT-4442) release 0.11.0 to https://bintray.com/apache/thrift

2018-01-04 Thread RobberPhex (JIRA)
RobberPhex created THRIFT-4442: -- Summary: release 0.11.0 to https://bintray.com/apache/thrift Key: THRIFT-4442 URL: https://issues.apache.org/jira/browse/THRIFT-4442 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-4425) Publish Thrift v0.11 to packagist.org

2018-01-04 Thread RobberPhex (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311135#comment-16311135 ] RobberPhex commented on THRIFT-4425: 0.11.0 is appeared at https://packagist.org/pack