[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633942 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633860 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633628 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user RobberPhex commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164633402 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632749 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -78,11 +69,26 @@ public function __construct($transport = null, $rBufSize = 512, $wBufSize =

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632507 --- Diff: lib/php/lib/Transport/TBufferedTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632710 --- Diff: lib/php/lib/Transport/TTransport.php --- @@ -22,6 +22,7 @@ namespace Thrift\Transport; +use

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1484#discussion_r164632409 --- Diff: lib/php/lib/Factory/TStringFuncFactory.php --- @@ -21,8 +21,9 @@ namespace Thrift\Factory; -use Thrift\StringFunc\Mbstring;

[jira] [Created] (THRIFT-4479) Enhance Windows CI build with 32/64 cygwin/mingw builds like in Boost.Format

James E. King, III created THRIFT-4479: -- Summary: Enhance Windows CI build with 32/64 cygwin/mingw builds like in Boost.Format Key: THRIFT-4479 URL: https://issues.apache.org/jira/browse/THRIFT-4479

[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang

[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344438#comment-16344438 ] ASF GitHub Bot commented on THRIFT-4308: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1483: THRIFT-4308: re-enable dlang deimos build support for li...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1483 Of course the lib/d certificates had to expire on January 29 too... ---

[jira] [Created] (THRIFT-4478) Thrift is not compatible with dlang 2.078 and later

James E. King, III created THRIFT-4478: -- Summary: Thrift is not compatible with dlang 2.078 and later Key: THRIFT-4478 URL: https://issues.apache.org/jira/browse/THRIFT-4478 Project: Thrift

[jira] [Commented] (THRIFT-4477) TBufferedTransport must have underlying transport

[ https://issues.apache.org/jira/browse/THRIFT-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344421#comment-16344421 ] ASF GitHub Bot commented on THRIFT-4477: GitHub user RobberPhex opened a pull request:

[jira] [Created] (THRIFT-4477) TBufferedTransport must have underlying transport

Robert Lu created THRIFT-4477: - Summary: TBufferedTransport must have underlying transport Key: THRIFT-4477 URL: https://issues.apache.org/jira/browse/THRIFT-4477 Project: Thrift Issue Type: Bug

[GitHub] thrift pull request #1484: TBufferedTransport must have underlying transport

GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1484 TBufferedTransport must have underlying transport ref: https://issues.apache.org/jira/browse/THRIFT-4477 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1474 @jfarrell from what I can see these error codes are inside contributed code in the fbthrift project, at least from the C++ side, in a file that contains the Apache license:

[jira] [Resolved] (THRIFT-4475) lib/php/test should be checked for PSR-2

[ https://issues.apache.org/jira/browse/THRIFT-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4475. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks. > lib/php/test

[jira] [Commented] (THRIFT-4475) lib/php/test should be checked for PSR-2

[ https://issues.apache.org/jira/browse/THRIFT-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343993#comment-16343993 ] ASF GitHub Bot commented on THRIFT-4475: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1482: THRIFT-4475: check lib/php/test for PSR-2

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1482 ---

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 @jeking3 `Do we really need to ask for permission to add three additional error codes from fbthrift?` - yes, if there is something in Facebook fbthrift that someone wants to add to Apache Thrift

[jira] [Commented] (THRIFT-4474) PHP generator use PSR-4 default

[ https://issues.apache.org/jira/browse/THRIFT-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343915#comment-16343915 ] ASF GitHub Bot commented on THRIFT-4474: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1479: THRIFT-4474: generate PHP code use PSR-4 style default

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1479 Are these changes all backwards compatible? ---

[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang

[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343912#comment-16343912 ] ASF GitHub Bot commented on THRIFT-4308: GitHub user jeking3 opened a pull request:

[GitHub] thrift pull request #1483: THRIFT-4308: re-enable dlang deimos build support...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1483 THRIFT-4308: re-enable dlang deimos build support for libevent and openssl ... working around a dmd link order issue. https://issues.apache.org/jira/browse/THRIFT-4308 You can merge this

[jira] [Commented] (THRIFT-4308) D language docker images need demios for libevent and openssl fixed to re-enable make cross on dlang

[ https://issues.apache.org/jira/browse/THRIFT-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343899#comment-16343899 ] James E. King, III commented on THRIFT-4308: Okay, so it turns out other people have reported

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343539#comment-16343539 ] ASF GitHub Bot commented on THRIFT-82: -- Github user jeking3 commented on the issue:

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1412 Sorry I have been working on some other things - I will try to get back around to this as soon as I can. It's important to the project to have as many languages supported as possible. ---

[jira] [Commented] (THRIFT-4426) repository should not include symbolic links

[ https://issues.apache.org/jira/browse/THRIFT-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343263#comment-16343263 ] Xiaoshuang LU commented on THRIFT-4426: --- Hi [~roger.meier], Would you please reviewing this patch?

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343221#comment-16343221 ] ASF GitHub Bot commented on THRIFT-82: -- Github user uint commented on the issue:

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

Github user uint commented on the issue: https://github.com/apache/thrift/pull/1412 Rebased. ---

[jira] [Commented] (THRIFT-82) Common Lisp support

[ https://issues.apache.org/jira/browse/THRIFT-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343185#comment-16343185 ] ASF GitHub Bot commented on THRIFT-82: -- Github user dkochmanski commented on the issue:

[GitHub] thrift issue #1412: [THRIFT-82] Add Common Lisp support

Github user dkochmanski commented on the issue: https://github.com/apache/thrift/pull/1412 Basically SBCL 1.3.14 (artful) works fine locally on Docker (and 1.3.1 had a bug with base strings according to SBCL devs - xenial). So the problem is probably something on environment hosting