[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347488#comment-16347488 ] Dave Watson commented on THRIFT-4484: - IIRC cpp needs "cpp.ref = "true"" on the field to make it a

[GitHub] thrift issue #1459: THRIFT-4448: Golang: do something with context.Context

Github user johnboiles commented on the issue: https://github.com/apache/thrift/pull/1459 @jeking3 @dcelasun Travis is green so I think we're almost good to go here. Mind taking another look and merging if it looks good? ---

[jira] [Commented] (THRIFT-4448) Golang: do something with context.Context

[ https://issues.apache.org/jira/browse/THRIFT-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347291#comment-16347291 ] ASF GitHub Bot commented on THRIFT-4448: Github user johnboiles commented on the issue:

[jira] [Reopened] (THRIFT-4454) Large writes/reads may cause range check errors in debug mode

[ https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-4454: There are a few more places, similar code. > Large writes/reads may cause range check errors in debug

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer edited comment on THRIFT-4484 at 1/31/18 11:25 AM: 3On 31

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer edited comment on THRIFT-4484 at 1/31/18 11:24 AM: On 31

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346460#comment-16346460 ] Craig Ringer commented on THRIFT-4484: -- On 31 Jan. 2018 16:11, "Jens Geyer (JIRA)"

[jira] [Comment Edited] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346405#comment-16346405 ] Jens Geyer edited comment on THRIFT-4484 at 1/31/18 8:08 AM: - The more

[jira] [Commented] (THRIFT-4484) C++ codegen invalid for optional self-membership

[ https://issues.apache.org/jira/browse/THRIFT-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346405#comment-16346405 ] Jens Geyer commented on THRIFT-4484: The more interesting question is whether it makes sense to do