[GitHub] thrift pull request #1504: Fix wrong @param in comment

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1504 ---

[GitHub] thrift issue #1504: Fix wrong @param in comment

2018-03-08 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1504 Usually we ask for a Jira ticket for each change but I'm not going to considering this is a small doc change. In the future please see: https://thrift.apache.org/docs/HowToContribute ---

[GitHub] thrift pull request #1504: Fix wrong @param in comment

2018-03-08 Thread victoryifei
GitHub user victoryifei opened a pull request: https://github.com/apache/thrift/pull/1504 Fix wrong @param in comment Wrong @ param name can cause warning when `-Wdocumentation` flag is on for objc. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Assigned] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4509: -- Assignee: (was: James E. King, III) > js and nodejs libraries need to be

[jira] [Assigned] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-08 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4509: -- Assignee: James E. King, III > js and nodejs libraries need to be refreshed

[jira] [Commented] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391513#comment-16391513 ] ASF GitHub Bot commented on THRIFT-4509: Github user asfgit closed the pull request at:

[GitHub] thrift pull request #1501: THRIFT-4509: remove nodejs browser test

2018-03-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1501 ---

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-08 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 I finalized the changes, however there are a couple of errors in my builds which I think are irrelevant to my changes. Here are the links to my build results (please let me know if you

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391015#comment-16391015 ] ASF GitHub Bot commented on THRIFT-4476: GitHub user ozymaxx reopened a pull request:

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391014#comment-16391014 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift pull request #1496: THRIFT-4476: Typecasting problem on list items (+...

2018-03-08 Thread ozymaxx
GitHub user ozymaxx reopened a pull request: https://github.com/apache/thrift/pull/1496 THRIFT-4476: Typecasting problem on list items (+ low precision double rendering, + mis-rendering non-fractional double literals in Python) - high precision double rendering in JS, Java, Python

[GitHub] thrift pull request #1500: THRIFT-4509: use nodejs 8.x from nodesource.com i...

2018-03-08 Thread bananer
Github user bananer closed the pull request at: https://github.com/apache/thrift/pull/1500 ---

[jira] [Commented] (THRIFT-4509) js and nodejs libraries need to be refreshed with current libraries

2018-03-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16390913#comment-16390913 ] ASF GitHub Bot commented on THRIFT-4509: Github user bananer closed the pull request at: