[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: {{Source:}} {{---}} {{struct Node {}} {{    1: string name;}} {{    2: list

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: {{Source:}} {{---}} {{struct Node {}} {{    1: string name;}} {{    2:

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: {{Source:}} {{---}} {{struct Node {}} {{    1: string name;}} {{    2: list

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: {{Source:}} {{---}} {{struct Node {}} {{    1: string name;}} {{    2: list

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: Source: ``` struct Node { 1: string name; 2: list children; } ```

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: {{Source:}} {{```}} {{struct Node {}} {{    1: string name;}} {{    2: list

[jira] [Updated] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Zhulanow updated THRIFT-4521: - Description: +Source:+ {{struct Node {}} {{    1: string name;}} {{    2: list children;}}

[jira] [Created] (THRIFT-4521) Cocoa compiler produces invalid code for recursive structs

2018-03-16 Thread Yan Zhulanow (JIRA)
Yan Zhulanow created THRIFT-4521: Summary: Cocoa compiler produces invalid code for recursive structs Key: THRIFT-4521 URL: https://issues.apache.org/jira/browse/THRIFT-4521 Project: Thrift

[jira] [Commented] (THRIFT-4419) Rust framed transport cannot handle writes above 4096 bytes

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403237#comment-16403237 ] ASF GitHub Bot commented on THRIFT-4419: GitHub user allengeorge opened a pull request:

[GitHub] thrift pull request #1508: THRIFT-4419: Fix bug where framed messages > 4K c...

2018-03-16 Thread allengeorge
GitHub user allengeorge opened a pull request: https://github.com/apache/thrift/pull/1508 THRIFT-4419: Fix bug where framed messages > 4K could not be read Client: rs You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-03-16 Thread jfarrell
Github user jfarrell commented on the issue: https://github.com/apache/thrift/pull/1474 Hi @yfeldblum, thanks for taking a look into this for us, appreciate your help. A new PR would be great that way it gives the ASF the needed audit trail of the origination of the pull request code

[GitHub] thrift issue #1474: Recognize fbthrift TApplicationException codes

2018-03-16 Thread yfeldblum
Github user yfeldblum commented on the issue: https://github.com/apache/thrift/pull/1474 @jfarrell Does Apache actually need a new PR originating from FB? Or is it sufficient for FB to okay this PR? ---

[jira] [Updated] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

2018-03-16 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4515: --- Description: The cross test suite kills the server process after the client is done,

[jira] [Comment Edited] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

2018-03-16 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400437#comment-16400437 ] James E. King, III edited comment on THRIFT-4515 at 3/16/18 8:28 PM: -

[jira] [Comment Edited] (THRIFT-4515) Gracefully shutdown cross-test servers to fully test teardown

2018-03-16 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400437#comment-16400437 ] James E. King, III edited comment on THRIFT-4515 at 3/16/18 5:45 PM: -

[jira] [Commented] (THRIFT-4496) Dealing with language keywords in Thrift (e.g. service method names)

2018-03-16 Thread Vera Filippova (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402196#comment-16402196 ] Vera Filippova commented on THRIFT-4496:  Here is what I plan to do next. Could you please tell

[GitHub] thrift issue #1480: [nodejs] Fix issue with connection failures silently fai...

2018-03-16 Thread dorilla
Github user dorilla commented on the issue: https://github.com/apache/thrift/pull/1480 Apologies, I haven't had the time to update this ticket. I fully intend to, just trying to find the time. ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16402029#comment-16402029 ] ASF GitHub Bot commented on THRIFT-4476: Github user jeking3 commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-16 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1496 If there's a way to fix it in the compiler so that it works properly, that's much better. Having compiler-version-specific branches in the thrift compiler to handle floating point oddities like

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401966#comment-16401966 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-16 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 @jeking3 or another alternative path to go: emitting double can depend on the msvc compiler version. If the compiler version is 2013 or less, we can ignore using fixed. ---

[jira] [Commented] (THRIFT-4476) Typecasting problem on list items

2018-03-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401951#comment-16401951 ] ASF GitHub Bot commented on THRIFT-4476: Github user ozymaxx commented on the issue:

[GitHub] thrift issue #1496: THRIFT-4476: Typecasting problem on list items (+ low pr...

2018-03-16 Thread ozymaxx
Github user ozymaxx commented on the issue: https://github.com/apache/thrift/pull/1496 @jeking3 , I will now re-enable the tests. But please note that the problem is at the C++ compiler level. The pre-2015 versions of the Visual Studio C++ compilers uses a different parsing and

[jira] [Created] (THRIFT-4520) Modernize JS/node

2018-03-16 Thread Philip Frank (JIRA)
Philip Frank created THRIFT-4520: Summary: Modernize JS/node Key: THRIFT-4520 URL: https://issues.apache.org/jira/browse/THRIFT-4520 Project: Thrift Issue Type: Wish Components:

[jira] [Resolved] (THRIFT-4516) Add support for go 1.10

2018-03-16 Thread Can Celasun (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Can Celasun resolved THRIFT-4516. - Resolution: Fixed Fix Version/s: 0.12.0 > Add support for go 1.10 >