[GitHub] thrift pull request #1491: THRIFT-4489: Add UDS support for nodejs thrift cl...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1491 ---

[jira] [Resolved] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4489. Resolution: Fixed Fix Version/s: 0.12.0 Committed - thanks. > Unix domain s

[jira] [Commented] (THRIFT-4489) Unix domain socket support for NodeJS client

[ https://issues.apache.org/jira/browse/THRIFT-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407782#comment-16407782 ] ASF GitHub Bot commented on THRIFT-4489: Github user asfgit closed the pull reque

[VOTE]: Move from legacy asf git to Apache GitBox

Apache GitBox provides the Thrift project more control over the lifecycle of pull requests and improve the team's ability to get things done in a timely manner. The goal is to improve team self-service in GitHub and integrated CI workflows. One important improvement for committers is that it allo

[jira] [Commented] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407860#comment-16407860 ] Allen George commented on THRIFT-4451: -- I'm noticing weird behavior where the rust c

[jira] [Commented] (THRIFT-4451) Rust client fails to communicate with multiplexed perl/c_glib servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407862#comment-16407862 ] Allen George commented on THRIFT-4451: -- Weirdly enough, here's the sequence of back

Re: [VOTE]: Move from legacy asf git to Apache GitBox

+1 On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote: > Apache GitBox provides the Thrift project more control over the lifecycle > of pull requests and improve the team's ability to get things done in a > timely manner. The goal is to improve team self-service in GitHub and > integrated CI

Re: [VOTE]: Move from legacy asf git to Apache GitBox

+1 On Wed, Mar 21, 2018, 10:27 PM Duru Can Celasun wrote: > +1 > > On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote: > > Apache GitBox provides the Thrift project more control over the lifecycle > > of pull requests and improve the team's ability to get things done in a > > timely manner.

Re: [VOTE]: Move from legacy asf git to Apache GitBox

+1 Xin Wang lovep...@hotmail.com 在 2018年3月21日，下午9:51，Aki Sukegawa mailto:nsu...@gmail.com>> 写道： +1 On Wed, Mar 21, 2018, 10:27 PM Duru Can Celasun mailto:dcela...@apache.org>> wrote: +1 On Wed, 21 Mar 2018, at 13:18, James E. King, III wrote: Apache GitBox prov

Re: [VOTE]: Move from legacy asf git to Apache GitBox

+1 -Jake On Wed, Mar 21, 2018 at 8:18 AM, James E. King, III wrote: > Apache GitBox provides the Thrift project more control over the lifecycle > of pull requests and improve the team's ability to get things done in a > timely manner. The goal is to improve team self-service in GitHub and > in

[GitHub] thrift pull request #744: update TSocket.php

Github user lihanharry closed the pull request at: https://github.com/apache/thrift/pull/744 ---

[GitHub] thrift pull request #1515: add connect timeout, support accurate send timeou...

GitHub user lihanharry opened a pull request: https://github.com/apache/thrift/pull/1515 add connect timeout, support accurate send timeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/lihanharry/thrift master Alternatively y

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 THRIFT-4171 ---

[jira] [Commented] (THRIFT-4171) PHP TSocket sendTimeout is being used as connectTimeout

[ https://issues.apache.org/jira/browse/THRIFT-4171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408389#comment-16408389 ] ASF GitHub Bot commented on THRIFT-4171: Github user jeking3 commented on the iss

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 Please squash your changes to a single commit if possible. Thanks. ---

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

Github user dcelasun commented on the issue: https://github.com/apache/thrift/pull/1515 Please don't change the code style while you are doing unrelated changes, it makes it very hard to review what *actually* changed. Even with the changes, there are lots of style inconsistencies lik

[jira] [Created] (THRIFT-4527) Upgrade byteorder version in Rust lib

Joshua created THRIFT-4527: -- Summary: Upgrade byteorder version in Rust lib Key: THRIFT-4527 URL: https://issues.apache.org/jira/browse/THRIFT-4527 Project: Thrift Issue Type: Dependency upgrade

[GitHub] thrift pull request #1516: THRIFT-4527 Upgrade byteorder in rust

GitHub user QuestofIranon opened a pull request: https://github.com/apache/thrift/pull/1516 THRIFT-4527 Upgrade byteorder in rust updated byteorder 1.1.0 -> 1.2.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/QuestofIranon/thrif

[jira] [Issue Comment Deleted] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua updated THRIFT-4527: --- Comment: was deleted (was: see: https://github.com/apache/thrift/pull/1516) > Upgrade byteorder version in R

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408646#comment-16408646 ] ASF GitHub Bot commented on THRIFT-4527: GitHub user QuestofIranon opened a pull

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408647#comment-16408647 ] Joshua commented on THRIFT-4527: see: https://github.com/apache/thrift/pull/1516 > Upgra

[jira] [Updated] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joshua updated THRIFT-4527: --- Description: The Rust library was depending on byteorder v1.1.0, upgraded to v1.2.1 to prevent dependency con

[jira] [Created] (THRIFT-4528) Something wrong in either ruby server or cpp client with json processing

James E. King, III created THRIFT-4528: -- Summary: Something wrong in either ruby server or cpp client with json processing Key: THRIFT-4528 URL: https://issues.apache.org/jira/browse/THRIFT-4528

[jira] [Assigned] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[ https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4358: -- Assignee: James E. King, III > Add unix domain sockets in ruby to cross test -

[jira] [Resolved] (THRIFT-4358) Add unix domain sockets in ruby to cross test - code exists

[ https://issues.apache.org/jira/browse/THRIFT-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4358. Resolution: Fixed Fix Version/s: 0.12.0 > Add unix domain sockets in ruby to

[jira] [Resolved] (THRIFT-4525) Add ssl socket option to ruby cross tests

[ https://issues.apache.org/jira/browse/THRIFT-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4525. Resolution: Fixed Fix Version/s: 0.12.0 > Add ssl socket option to ruby cros

[GitHub] thrift pull request #1514: THRIFT-4525: add ruby cross test ssl support

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1514 ---

[jira] [Commented] (THRIFT-4525) Add ssl socket option to ruby cross tests

[ https://issues.apache.org/jira/browse/THRIFT-4525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408852#comment-16408852 ] ASF GitHub Bot commented on THRIFT-4525: Github user asfgit closed the pull reque

[jira] [Updated] (THRIFT-4502) Cleanup "Known Test Failures" in order to improve quality

[ https://issues.apache.org/jira/browse/THRIFT-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4502: --- Issue Type: Epic (was: Story) > Cleanup "Known Test Failures" in order to improve qu

[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1515 Fortunately these changes are confined to one file so reviewing it isn't too bad - hopefully they pass the new php formatting tests in the sca build. ---

[jira] [Assigned] (THRIFT-4342) Support ruby rspec 3

[ https://issues.apache.org/jira/browse/THRIFT-4342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-4342: -- Assignee: James E. King, III > Support ruby rspec 3 > > >

[jira] [Resolved] (THRIFT-4497) Erlang records should use map() for map type

[ https://issues.apache.org/jira/browse/THRIFT-4497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4497. Resolution: Fixed Fix Version/s: 0.12.0 > Erlang records should use map() fo

[jira] [Resolved] (THRIFT-4495) Erlang records should allow 'undefined' for non-required fields

[ https://issues.apache.org/jira/browse/THRIFT-4495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4495. Resolution: Fixed Fix Version/s: 0.12.0 > Erlang records should allow 'undef

[GitHub] thrift issue #1516: THRIFT-4527 Upgrade byteorder in rust

Github user allengeorge commented on the issue: https://github.com/apache/thrift/pull/1516 LGTM. @QuestofIranon just curious - why bump the version? ---

[jira] [Commented] (THRIFT-4527) Upgrade byteorder version in Rust lib

[ https://issues.apache.org/jira/browse/THRIFT-4527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408906#comment-16408906 ] ASF GitHub Bot commented on THRIFT-4527: Github user allengeorge commented on the

[jira] [Created] (THRIFT-4529) Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines

Joshua created THRIFT-4529: -- Summary: Rust generation should include #![allow(non_snake_case)] or force conform to Rust style guidelines Key: THRIFT-4529 URL: https://issues.apache.org/jira/browse/THRIFT-4529