[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440393#comment-16440393 ] ASF GitHub Bot commented on THRIFT-4552: dcelasun commented on issue #1542: THRIFT-4552: remove

[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268

2018-04-16 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440097#comment-16440097 ] Vihang Karajgaonkar commented on THRIFT-3769: - oh sorry :) I thought you were based on your

[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268

2018-04-16 Thread Sergey Shelukhin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440093#comment-16440093 ] Sergey Shelukhin commented on THRIFT-3769: -- LGTM but I'm not a committer > Fix logic of

[jira] [Commented] (THRIFT-3769) Fix logic of THRIFT-2268

2018-04-16 Thread Vihang Karajgaonkar (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440087#comment-16440087 ] Vihang Karajgaonkar commented on THRIFT-3769: - ping [~jking3] [~sershe] > Fix logic of

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440049#comment-16440049 ] ASF GitHub Bot commented on THRIFT-4555: bpodgursky commented on issue #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439748#comment-16439748 ] ASF GitHub Bot commented on THRIFT-4555: dcelasun commented on issue #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439622#comment-16439622 ] ASF GitHub Bot commented on THRIFT-4555: bpodgursky commented on issue #1540: THRIFT-4555

[jira] [Updated] (THRIFT-4556) Rethrow unhandled exceptions

2018-04-16 Thread Nicolas Krog (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Krog updated THRIFT-4556: - Summary: Rethrow unhandled exceptions (was: Make it possible to return an exception to the

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439034#comment-16439034 ] ASF GitHub Bot commented on THRIFT-4555: dcelasun commented on issue #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4555) Getter of binary field in Java creates unnecessary copy

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439033#comment-16439033 ] ASF GitHub Bot commented on THRIFT-4555: dcelasun commented on issue #1540: THRIFT-4555

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439028#comment-16439028 ] ASF GitHub Bot commented on THRIFT-4532: mustafa-cosar commented on issue #1541: THRIFT-4532: Do

[jira] [Commented] (THRIFT-4552) why acquire a lock in TSimpleServer implementation for Go?

2018-04-16 Thread gansteed (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439025#comment-16439025 ] gansteed commented on THRIFT-4552: -- hello, the PR failed because of C++ tests:

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439021#comment-16439021 ] ASF GitHub Bot commented on THRIFT-4532: bgedik commented on issue #1541: THRIFT-4532: Do not

[jira] [Commented] (THRIFT-4532) Avoid updating Thrift compiler generated code if the output has not changed

2018-04-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439020#comment-16439020 ] ASF GitHub Bot commented on THRIFT-4532: bgedik commented on issue #1541: THRIFT-4532: Do not