[jira] [Resolved] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4741. Resolution: Fixed Fix Version/s: 0.13.0 Committed > Missing "inner" argument from one

[jira] [Resolved] (THRIFT-4742) Typo "cannot read from null input stream" on write

2019-01-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-4742. Resolution: Fixed Fix Version/s: 0.13.0 Committed > Typo "cannot read from null input

[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744558#comment-16744558 ] James E. King III commented on THRIFT-4741: --- The pull request is fine, I'm just saying the

[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744557#comment-16744557 ] Jens Geyer commented on THRIFT-4741: I shortly considered putting both changes into one PR, but did

[jira] [Commented] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744550#comment-16744550 ] James E. King III commented on THRIFT-4741: --- I'd suggest for items like this which are fairly

[jira] [Created] (THRIFT-4742) Typo "cannot read from null input stream" on write

2019-01-16 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4742: -- Summary: Typo "cannot read from null input stream" on write Key: THRIFT-4742 URL: https://issues.apache.org/jira/browse/THRIFT-4742 Project: Thrift Issue Type:

[jira] [Assigned] (THRIFT-4742) Typo "cannot read from null input stream" on write

2019-01-16 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4742: -- Assignee: Jens Geyer > Typo "cannot read from null input stream" on write >

[jira] [Created] (THRIFT-4741) Missing "inner" argument from one CTOR

2019-01-16 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4741: -- Summary: Missing "inner" argument from one CTOR Key: THRIFT-4741 URL: https://issues.apache.org/jira/browse/THRIFT-4741 Project: Thrift Issue Type: Bug

Re: [VOTE] Next version number: 1.0

2019-01-16 Thread James E. King III
It sounds like a gating factor to switch to cmake then... On Wed, Jan 16, 2019 at 10:40 AM Randy Abernethy wrote: > People have maturity expectations associated with a 1.0 release. So > yes, my vote to do a release might be +1 while my vote for doing the > same release as 1.0 might be -1

RE: Thrift Maven Plugin on Linux

2019-01-16 Thread Adam Marcionek
Hi Randy, You know what, I was just perusing the Thrift documentation (https://thrift.apache.org/lib/cpp) and saw this: On Linux, the best way to do this is to ensure that /usr/local/lib is in your /etc/ld.so.conf and then run /sbin/ldconfig. I'm thinking we may not have done this. So I will

Re: [VOTE] Next version number: 1.0

2019-01-16 Thread Randy Abernethy
People have maturity expectations associated with a 1.0 release. So yes, my vote to do a release might be +1 while my vote for doing the same release as 1.0 might be -1 because I do not want to mislead the public. On Tue, Jan 15, 2019 at 7:32 PM James E. King III wrote: > > To do this we need to

Re: Thrift Maven Plugin on Linux

2019-01-16 Thread Randy Abernethy
I have used the old Maven plug in as recently as 2018 on Thrift v0.10 and did not have any trouble on Ubuntu 16.04. On Tue, Jan 15, 2019 at 7:36 PM James E. King III wrote: > > Hi Adam, > > Definitely create an issue in Jira and submit a PR. Things in contrib/ are > in there either due to