[jira] [Resolved] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4747. --- Resolution: Fixed Assignee: James E. King III Fix Version/s: 0.13.0

[jira] [Resolved] (THRIFT-4654) Thrift Dart port is not compatible with Dart 2

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4654. --- Resolution: Fixed Fix Version/s: 0.13.0 > Thrift Dart port is not compatible

[jira] [Commented] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread Renan Cakirerk (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748310#comment-16748310 ] Renan Cakirerk commented on THRIFT-4747: The `omitempty` tags were introduced he

[jira] [Commented] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748308#comment-16748308 ] James E. King III commented on THRIFT-4747: --- What version was this found in?

[jira] [Updated] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4747: -- Fix Version/s: (was: 0.13.0) > The 'omitempty' tag should not be appended to optio

[jira] [Comment Edited] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread Renan Cakirerk (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748302#comment-16748302 ] Renan Cakirerk edited comment on THRIFT-4747 at 1/22/19 1:18 AM: -

[jira] [Commented] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread Renan Cakirerk (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748302#comment-16748302 ] Renan Cakirerk commented on THRIFT-4747: Here's how to setup the thrift build en

[jira] [Comment Edited] (THRIFT-4715) C# union "data" should be strongly-typed

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748291#comment-16748291 ] Jens Geyer edited comment on THRIFT-4715 at 1/22/19 12:53 AM:

[jira] [Commented] (THRIFT-1786) C# Union Typing

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748290#comment-16748290 ] Jens Geyer commented on THRIFT-1786: Not to mention the (breaking?) change on the cl

[jira] [Commented] (THRIFT-4715) C# union "data" should be strongly-typed

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748291#comment-16748291 ] Jens Geyer commented on THRIFT-4715: I try to make the best out of it w/o breaking t

[jira] [Commented] (THRIFT-1786) C# Union Typing

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748289#comment-16748289 ] Jens Geyer commented on THRIFT-1786: For half an hour now I do wonder who wants to t

[jira] [Created] (THRIFT-4747) The 'omitempty' tag should not be appended to optional fields that have a default value

2019-01-21 Thread Renan Cakirerk (JIRA)
Renan Cakirerk created THRIFT-4747: -- Summary: The 'omitempty' tag should not be appended to optional fields that have a default value Key: THRIFT-4747 URL: https://issues.apache.org/jira/browse/THRIFT-4747

[jira] [Assigned] (THRIFT-4715) C# union "data" should be strongly-typed

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4715: -- Assignee: Jens Geyer > C# union "data" should be strongly-typed > ---

[jira] [Assigned] (THRIFT-4722) Netcore union "data" should be strongly-typed

2019-01-21 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4722: -- Assignee: Jens Geyer > Netcore union "data" should be strongly-typed > --

[jira] [Updated] (THRIFT-4551) Add prettier for consistent JS code formatting

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4551: -- Fix Version/s: (was: 0.12.0) > Add prettier for consistent JS code formatting > --

[jira] [Updated] (THRIFT-4551) Add prettier for consistent JS code formatting

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4551: -- Affects Version/s: 0.11.0 > Add prettier for consistent JS code formatting > -

[jira] [Reopened] (THRIFT-4551) Add prettier for consistent JS code formatting

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III reopened THRIFT-4551: --- > Add prettier for consistent JS code formatting > -

[jira] [Resolved] (THRIFT-4691) The perl CPAN module contains no tests

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4691. --- Resolution: Fixed Fix Version/s: 0.13.0 > The perl CPAN module contains no te

[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

2019-01-21 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748101#comment-16748101 ] James E. King III commented on THRIFT-3560: --- Seems reasonable to me. > C++ TT

[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

2019-01-21 Thread Sebastian Zenker (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748046#comment-16748046 ] Sebastian Zenker commented on THRIFT-3560: -- Should I also add the override keyw

[jira] [Updated] (THRIFT-4746) Publish a Maven artifact for Thrift v0.12

2019-01-21 Thread Dmitry Volodin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin updated THRIFT-4746: --- Issue Type: Task (was: Bug) > Publish a Maven artifact for Thrift v0.12 > -

[jira] [Created] (THRIFT-4746) Publish a Maven artifact for Thrift v0.12

2019-01-21 Thread Dmitry Volodin (JIRA)
Dmitry Volodin created THRIFT-4746: -- Summary: Publish a Maven artifact for Thrift v0.12 Key: THRIFT-4746 URL: https://issues.apache.org/jira/browse/THRIFT-4746 Project: Thrift Issue Type: Bu