[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756793#comment-16756793 ] Jim Apple commented on THRIFT-4138: --- It seems like I should also check {{str.fail()}},

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756765#comment-16756765 ] Jim Apple commented on THRIFT-4138: --- OK, if I'm re-reading this correctly, the very pr

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread Jim Apple (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756759#comment-16756759 ] Jim Apple commented on THRIFT-4138: --- What is the type of {{t}} in that gdb snippet? I

[jira] [Updated] (THRIFT-4405) c_glib does not accept seqid < 0, cpp json readHeaderBegin corrupts negative seqid

2019-01-30 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4405: -- Affects Version/s: (was: 0.10.0) 0.11.0 > c_glib does not a

[jira] [Resolved] (THRIFT-4763) HTML compiler produces invalid HTML document

2019-01-30 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-4763. --- Resolution: Fixed Assignee: James E. King III Fix Version/s: 0.13.0

[jira] [Updated] (THRIFT-4405) c_glib does not accept seqid < 0, cpp json readHeaderBegin corrupts negative seqid

2019-01-30 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-4405: -- Summary: c_glib does not accept seqid < 0, cpp json readHeaderBegin corrupts negative

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

2019-01-30 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756749#comment-16756749 ] James E. King III commented on THRIFT-4138: --- This broke TJSONProtocol's abilit

[jira] [Commented] (THRIFT-4405) Proper use of sequence IDs in all clients and servers

2019-01-30 Thread James E. King III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756563#comment-16756563 ] James E. King III commented on THRIFT-4405: --- Good news, the tests caught stuff

[jira] [Created] (THRIFT-4766) JDK9+ fails on missing annotations

2019-01-30 Thread Fokko Driesprong (JIRA)
Fokko Driesprong created THRIFT-4766: Summary: JDK9+ fails on missing annotations Key: THRIFT-4766 URL: https://issues.apache.org/jira/browse/THRIFT-4766 Project: Thrift Issue Type: Impro