Re: Release 0.13.0

2019-10-08 Thread Jens Geyer
Cool! Sure, please do, just drop a line when you're done. Currently trying to get THRIFT-4874 done myself, still not through. Asides from that, I cut the branch when you tell me. No more blockers left then. > There are also two PRs for c_glib warnings. Someone familiar with it > should take a

[jira] [Commented] (THRIFT-4942) Set PHP struct generated field values as private with getters and setters

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947214#comment-16947214 ] Duru Can Celasun commented on THRIFT-4942: -- The patch itself looks fine, but I'm not sure if

[jira] [Resolved] (THRIFT-4945) Log output mode is not standardized

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4945. -- Fix Version/s: 0.13.0 Resolution: Fixed > Log output mode is not standardized

[jira] [Commented] (THRIFT-4949) improve HTTP/1 server test case

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947212#comment-16947212 ] Duru Can Celasun commented on THRIFT-4949: -- I'm not really familiar with tomcat but it looks OK

[jira] [Resolved] (THRIFT-4967) Node.js tutorial server fails if the zip function invoked

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4967. -- Fix Version/s: 0.13.0 Resolution: Fixed > Node.js tutorial server fails if the

[jira] [Resolved] (THRIFT-4969) PHP test doesn't check the code generation with php:classmap

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4969. -- Fix Version/s: 0.13.0 Resolution: Fixed > PHP test doesn't check the code

[jira] [Updated] (THRIFT-4970) PHP tutorial doesn't work with Thrift v0.12.0+

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun updated THRIFT-4970: - Priority: Minor (was: Major) > PHP tutorial doesn't work with Thrift v0.12.0+ >

[jira] [Resolved] (THRIFT-4970) PHP tutorial doesn't work with Thrift v0.12.0+

2019-10-08 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-4970. -- Fix Version/s: 0.13.0 Resolution: Fixed > PHP tutorial doesn't work with

[jira] [Commented] (THRIFT-4874) Thrift 0.12.0 Source Distribution (.tar.gz) Contains Hardlinks - Extract Fails

2019-10-08 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-4874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947184#comment-16947184 ] Jens Geyer commented on THRIFT-4874: {code} $ tar tvvf thrift-0.12.0.tar.gz | grep "link to"