franciscohanna92 commented on issue #1947:
URL: https://github.com/apache/thrift/pull/1947#issuecomment-616873555
Need this fix!
This is an automated message from the Apache Git Service.
To respond to the message, please log
Jens-G edited a comment on issue #2095:
URL: https://github.com/apache/thrift/pull/2095#issuecomment-616823649
Thanks! The remaining ones are probably unrelated problems but could you do
me the favour and force-push again to trigger CI?
Jens-G commented on issue #2095:
URL: https://github.com/apache/thrift/pull/2095#issuecomment-616823649
Thanbs! The remaining ones are probably unrelated problems but could you do
me the favour and force-push again to trigger CI?
> I had an impression that CMake is able to build the compiler and the c++
> library at least
I didn't say it does not work. I said it had never been completed to the point
where we can drop the autotools based build system entirely. And I also said
that the promises made in the past are
janosvitok commented on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616715322
So what's the status of CMake support? I had an impression that CMake is
able to build the compiler and the c++ library at least (that's what I've used
to compile thrift compiler on
Jens-G edited a comment on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616696754
They seem unmaintained because some people started the CMake switch but
never finished it. Hence we have two build systems to maintain and files that
ought to be automatically
Jens-G commented on issue #2100:
URL: https://github.com/apache/thrift/pull/2100#issuecomment-616696754
They seem unmaintained because some people started the CMake switch but
never finished it. Hence we have two build systems to maintain and files that
ought to be automatically generated
[
https://issues.apache.org/jira/browse/THRIFT-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087874#comment-17087874
]
Mario Emmenlauer commented on THRIFT-5178:
--
The PR for this issue adds a new default for the
Mario Emmenlauer created THRIFT-5180:
Summary: THttpClient requires a path when used with domain sockets
Key: THRIFT-5180
URL: https://issues.apache.org/jira/browse/THRIFT-5180
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087784#comment-17087784
]
Mario Emmenlauer commented on THRIFT-3877:
--
Could issue THRIFT-5180 be related?
> C++: library
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616584968
:-( Another random error in the CI. Can this be merged anyways?
This is an automated message from the Apache Git
dmaluka commented on issue #2102:
URL: https://github.com/apache/thrift/pull/2102#issuecomment-616585369
Re-triggered via force-pushing the same change again.
This is an automated message from the Apache Git Service.
To
emmenlau commented on issue #2102:
URL: https://github.com/apache/thrift/pull/2102#issuecomment-616523977
@dmaluka This is a nice changeset. To promote your change, maybe just
re-trigger the build so that hopefully tests work? With 1 out of 2 builds I'm
lucky and get all green lights :-)
emmenlau opened a new pull request #2105:
URL: https://github.com/apache/thrift/pull/2105
The constructors for THttpClient require specifying a `host`. However not
all supported socket types require a host. I.e. when using a Unix domain
socket, the host is required to be localhost.
[
https://issues.apache.org/jira/browse/THRIFT-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Emmenlauer updated THRIFT-5178:
-
Description:
The [constructors for
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616521068
Re-triggered build with a rebase on latest master, to fix random error in
Travis CI.
This is an automated message
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616505723
There seems to be an unrelated issue in
https://travis-ci.org/github/apache/thrift/jobs/677163097. Should I re-trigger
the builds and tests?
[
https://issues.apache.org/jira/browse/THRIFT-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zezeng Wang reassigned THRIFT-5179:
---
Assignee: Zezeng Wang
> Thrift compiler will generate wrong code if IDL struct's name is
Zezeng Wang created THRIFT-5179:
---
Summary: Thrift compiler will generate wrong code if IDL struct's
name is 'a' or 'b'
Key: THRIFT-5179
URL: https://issues.apache.org/jira/browse/THRIFT-5179
Project:
Mario Emmenlauer created THRIFT-5178:
Summary: THttpClient should work without specifying host
Key: THRIFT-5178
URL: https://issues.apache.org/jira/browse/THRIFT-5178
Project: Thrift
emmenlau commented on issue #2094:
URL: https://github.com/apache/thrift/pull/2094#issuecomment-616435582
I've found a small improvement where the Javascript target actually depends
on the target that copies the compiler into the source tree, not on the build
of the compiler. This ensures
21 matches
Mail list logo
