[GitHub] [thrift] stale[bot] commented on issue #2016: TNonblockingSSLServerTest.cpp: add missing include signal.h on Linux

stale[bot] commented on issue #2016: URL: https://github.com/apache/thrift/pull/2016#issuecomment-618164495 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[GitHub] [thrift] emmenlau commented on issue #2106: Added isOpen() to TServerTransport

emmenlau commented on issue #2106: URL: https://github.com/apache/thrift/pull/2106#issuecomment-618056254 The two errors in Travis CI seem unrelated. Ready for review. This is an automated message from the Apache Git Service.

[jira] [Assigned] (THRIFT-5183) Read beyond current frame in THeaderTransport might block the protocol code

[ https://issues.apache.org/jira/browse/THRIFT-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-5183: -- Assignee: Yuxuan Wang > Read beyond current frame in THeaderTransport might block the protoco

[jira] [Updated] (THRIFT-5183) Read beyond current frame in THeaderTransport might block the protocol code

[ https://issues.apache.org/jira/browse/THRIFT-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5183: --- Summary: Read beyond current frame in THeaderTransport might block the protocol code (was: [Go] Rea

[jira] [Updated] (THRIFT-5183) Read beyond current frame in THeaderTransport might block the protocol code

[ https://issues.apache.org/jira/browse/THRIFT-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5183: --- Issue Type: Bug (was: Improvement) > Read beyond current frame in THeaderTransport might block the

[jira] [Commented] (THRIFT-5180) THttpClient requires a path when used with domain sockets

[ https://issues.apache.org/jira/browse/THRIFT-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089967#comment-17089967 ] Jens Geyer commented on THRIFT-5180: TBH, about the required non-empty URL ... I had

[jira] [Resolved] (THRIFT-5109) Misc CMake improvements

[ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5109. Resolution: Fixed > Misc CMake improvements > --- > > Key: THR

[jira] [Comment Edited] (THRIFT-5182) Disable VS2015 in favor of VS2019?

[ https://issues.apache.org/jira/browse/THRIFT-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089956#comment-17089956 ] Jens Geyer edited comment on THRIFT-5182 at 4/22/20, 7:11 PM:

[jira] [Commented] (THRIFT-5182) Disable VS2015 in favor of VS2019?

[ https://issues.apache.org/jira/browse/THRIFT-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089956#comment-17089956 ] Jens Geyer commented on THRIFT-5182: I'm fine with it, if that is the question :-) T

[GitHub] [thrift] emmenlau commented on issue #2106: Added isOpen() to TServerTransport

emmenlau commented on issue #2106: URL: https://github.com/apache/thrift/pull/2106#issuecomment-617959369 Triggering build again, in the hope that CI now works... This is an automated message from the Apache Git Service. To r

[jira] [Updated] (THRIFT-5183) [Go] Read beyond current frame in THeaderTransport might block the protocol code

[ https://issues.apache.org/jira/browse/THRIFT-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxuan Wang updated THRIFT-5183: Description: This is a bug introduced in my initial implementation of go THeader in https://githu

[GitHub] [thrift] fishy commented on issue #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

fishy commented on issue #2110: URL: https://github.com/apache/thrift/pull/2110#issuecomment-617877222 @dcelasun :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [thrift] fishy opened a new pull request #2110: THRIFT-5183: Don't try to read next frame in THeaderTransport.Read

fishy opened a new pull request #2110: URL: https://github.com/apache/thrift/pull/2110 Client: go Trying to read the next frame will likely cause the Read call blocking indefinitely and eventually lead to timeout. See the JIRA ticket for more context.

[jira] [Created] (THRIFT-5183) [Go] Read beyond current frame in THeaderTransport might block the protocol code

Yuxuan Wang created THRIFT-5183: --- Summary: [Go] Read beyond current frame in THeaderTransport might block the protocol code Key: THRIFT-5183 URL: https://issues.apache.org/jira/browse/THRIFT-5183 Projec

[GitHub] [thrift] emmenlau opened a new pull request #2109: TOutput: Add further parsers for errno-to-string conversion

emmenlau opened a new pull request #2109: URL: https://github.com/apache/thrift/pull/2109 This change has mostly an impact on Windows. Currently Thrift does not resolve error strings on Windows (for me). A typical error message may look like `Could not bind: errno = 10049`. With C++11 the

[GitHub] [thrift] phile314 opened a new pull request #2108: Haskell: Handle incomplete reads correctly.

phile314 opened a new pull request #2108: URL: https://github.com/apache/thrift/pull/2108 The read functions for handles promise to return *up* to the requested number of bytes. This means in case we read less bytes, we should try again to read some more bytes. This issue caused invalid fr

[GitHub] [thrift] emmenlau commented on issue #2107: THRIFT-4282: Disabled StressTestNonBlocking on Windows

emmenlau commented on issue #2107: URL: https://github.com/apache/thrift/pull/2107#issuecomment-617769144 The single error in Travis CI is unrelated. PR is ready for review... This is an automated message from the Apac

[jira] [Created] (THRIFT-5182) Disable VS2015 in favor of VS2019?

Mario Emmenlauer created THRIFT-5182: Summary: Disable VS2015 in favor of VS2019? Key: THRIFT-5182 URL: https://issues.apache.org/jira/browse/THRIFT-5182 Project: Thrift Issue Type: Impro

[jira] [Comment Edited] (THRIFT-4282) StressTestNonBlocking is disabled in Appveyor as it is unstable on Windows in general

[ https://issues.apache.org/jira/browse/THRIFT-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089493#comment-17089493 ] Mario Emmenlauer edited comment on THRIFT-4282 at 4/22/20, 9:40 AM: --

[GitHub] [thrift] emmenlau opened a new pull request #2107: THRIFT-4282: Disabled StressTestNonBlocking on Windows

emmenlau opened a new pull request #2107: URL: https://github.com/apache/thrift/pull/2107 This PR disables StressTestNonBlocking on Windows, not just in AppVeyor but generally. This is required because the test is flaky. - [x] See https://jira.apache.org/jira/browse/THRIFT-4282 -

[jira] [Commented] (THRIFT-4282) StressTestNonBlocking is disabled in Appveyor as it is unstable on Windows in general

[ https://issues.apache.org/jira/browse/THRIFT-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089493#comment-17089493 ] Mario Emmenlauer commented on THRIFT-4282: -- I agree that StressTestNonBlocking

[jira] [Commented] (THRIFT-5180) THttpClient requires a path when used with domain sockets

[ https://issues.apache.org/jira/browse/THRIFT-5180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17089399#comment-17089399 ] Mario Emmenlauer commented on THRIFT-5180: -- I will not be able to implement a f

[GitHub] [thrift] emmenlau commented on issue #2105: THRIFT-5178: Added constructor with default host localhost

emmenlau commented on issue #2105: URL: https://github.com/apache/thrift/pull/2105#issuecomment-617603859 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an