[
https://issues.apache.org/jira/browse/THRIFT-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duru Can Celasun resolved THRIFT-4282.
--
Fix Version/s: 0.14.0
Resolution: Resolved
> StressTestNonBlocking is disabled
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618835805
CI is all green, merged.
This is an automated message from the Apache Git Service.
To respond to the message, pl
dcelasun commented on pull request #2113:
URL: https://github.com/apache/thrift/pull/2113#issuecomment-618832363
Tests are failing:
```
File "test/thrift_json.py", line 79
if __name__ == '__main__':
^
SyntaxError: invalid syntax
Makefile:6
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618831826
Thanks! CI failures are unrelated so I'm merging this.
This is an automated message from the Apache Git Service.
zeshuai007 opened a new pull request #2113:
URL: https://github.com/apache/thrift/pull/2113
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your
fishy commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618739157
@dcelasun Test added.
This is an automated message from the Apache Git Service.
To respond to the message, please l
dcelasun commented on pull request #2107:
URL: https://github.com/apache/thrift/pull/2107#issuecomment-618692351
Since the original issue is more than 2 years old without any solution, I'm
happy to just disable this on Windows.
Restarted Travis, which was broken due to a timeout on S
dcelasun commented on pull request #2106:
URL: https://github.com/apache/thrift/pull/2106#issuecomment-618691219
Travis errors seem transient, restarted the build.
This is an automated message from the Apache Git Service.
To
dcelasun commented on pull request #1966:
URL: https://github.com/apache/thrift/pull/1966#issuecomment-618689998
The C++ library supports THeader, which is more or less transport agnostic
and should be the preferred way of setting headers.
This PR on the other hand, effectively bypas
dcelasun commented on pull request #2000:
URL: https://github.com/apache/thrift/pull/2000#issuecomment-618688019
Thanks for the PR @spwin! Can you please add a test case so this won't
regress in the future?
This is an automa
dcelasun commented on pull request #2032:
URL: https://github.com/apache/thrift/pull/2032#issuecomment-618685580
Please also update
[LANGUAGES.md](https://github.com/apache/thrift/blob/master/LANGUAGES.md) and
[CHANGES.md](https://github.com/apache/thrift/blob/master/CHANGES.md#0140).
--
dcelasun commented on pull request #2084:
URL: https://github.com/apache/thrift/pull/2084#issuecomment-618682028
No worries, please ping me whenever you are ready and I'll take a look.
This is an automated message from the Ap
dcelasun commented on pull request #2068:
URL: https://github.com/apache/thrift/pull/2068#issuecomment-618679553
This broke MSVC builds on AppVeyor, see
[here](https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/32087820/job/b7qtw26hq6phy6jx?fullLog=true).
Please p
janosvitok commented on pull request #2084:
URL: https://github.com/apache/thrift/pull/2084#issuecomment-618678598
No. the code in PR causes deadlocks and I didn't have time to find out the
problem, and I won't soon. Sorry.
dcelasun commented on pull request #2079:
URL: https://github.com/apache/thrift/pull/2079#issuecomment-618677520
Thanks for the PR @penenin! Could you please rebase from master so Travis
can run again?
This is an automated m
Hi Thrift Devs,
Recently, it seems GitBox has been updated to start spamming the
Thrift dev list. This produces a lot of redundant noise if somebody is
already watching the repo on GitHub. Can these be sent to a separate
notifications list for Thrift instead, so followers of the Thrift
mailing lis
dcelasun edited a comment on pull request #2099:
URL: https://github.com/apache/thrift/pull/2099#issuecomment-618668928
This broke [CI](https://api.travis-ci.org/v3/job/675570277/log.txt) due to
style issues.
Please ping me after fixing and I'll reopen.
dcelasun commented on pull request #2089:
URL: https://github.com/apache/thrift/pull/2089#issuecomment-618676340
This broke [CI](https://api.travis-ci.org/v3/job/672411817/log.txt) due to
style issues.
Please ping me after fixing and I'll reopen.
---
dcelasun edited a comment on pull request #2099:
URL: https://github.com/apache/thrift/pull/2099#issuecomment-618668928
This broke [Python
tests](https://api.travis-ci.org/v3/job/675570277/log.txt).
Please ping me after fixing and I'll reopen.
--
dcelasun commented on pull request #2084:
URL: https://github.com/apache/thrift/pull/2084#issuecomment-618674662
@janosvitok any progress?
This is an automated message from the Apache Git Service.
To respond to the message, p
dcelasun commented on pull request #2109:
URL: https://github.com/apache/thrift/pull/2109#issuecomment-618673933
Thanks for the PR @emmenlau!
I'm not familiar with Windows or MSVC but this is at least harmless for
other platforms so if nobody objects, I'll go ahead and merge this in
dcelasun commented on pull request #2085:
URL: https://github.com/apache/thrift/pull/2085#issuecomment-618671507
Thanks for the PR! Couple of things before this can be merged:
- Please open a Jira ticket and discuss why this change is needed. It's not
obvious to me why we should prea
dcelasun commented on pull request #2099:
URL: https://github.com/apache/thrift/pull/2099#issuecomment-618668928
This broke [Python
tests](https://api.travis-ci.org/v3/job/675570277/log.txt).
This is an automated message fro
emmenlau commented on pull request #2109:
URL: https://github.com/apache/thrift/pull/2109#issuecomment-618667684
The single error in Travis CI is unrelated. Please review?
This is an automated message from the Apache Git Serv
[
https://issues.apache.org/jira/browse/THRIFT-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duru Can Celasun resolved THRIFT-5171.
--
Fix Version/s: 0.14.0
Resolution: Fixed
> Fix maven-ant-tasks to use HTTPS inst
dcelasun commented on pull request #2092:
URL: https://github.com/apache/thrift/pull/2092#issuecomment-618666383
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
dcelasun commented on pull request #2110:
URL: https://github.com/apache/thrift/pull/2110#issuecomment-618662755
Nice catch @fishy! Could you maybe add a test so this won't regress in a
potential refactor down the line?
Thi
penenin opened a new pull request #2112:
URL: https://github.com/apache/thrift/pull/2112
When establishing a WebSocket connection, Firefox sends Connection:
keep-alive, Upgrade instead of just Connection: Upgrade. Check to see if
Upgrade is in the header instead of checking to see if i
James Lacey created THRIFT-5184:
---
Summary: D: WebSocket Server Transport Fix for Firefox
Key: THRIFT-5184
URL: https://issues.apache.org/jira/browse/THRIFT-5184
Project: Thrift
Issue Type: Bug
Hi all,
I've seen repeated requests for an update of the Node.js package,
see i.e. https://issues.apache.org/jira/browse/THRIFT-5039 and
https://issues.apache.org/jira/browse/THRIFT-5170.
I would be happy to understand if there is significant effort
involved to make a new Node.js release? The d
[
https://issues.apache.org/jira/browse/THRIFT-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090419#comment-17090419
]
Mario Emmenlauer commented on THRIFT-5170:
--
I think this is a duplicate of THRI
zeshuai007 opened a new pull request #2111:
URL: https://github.com/apache/thrift/pull/2111
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does your
stale[bot] commented on issue #2016:
URL: https://github.com/apache/thrift/pull/2016#issuecomment-618228349
This issue is no longer stale. Thank you for your contributions.
This is an automated message from the Apache Git
emmenlau commented on issue #2016:
URL: https://github.com/apache/thrift/pull/2016#issuecomment-618228324
Thanks bot! I'll get back to this issue, promise!
This is an automated message from the Apache Git Service.
To respond
34 matches
Mail list logo
