[GitHub] [thrift] stale[bot] commented on pull request #2033: THRIFT-5117: Add unordered_map, unordered_set to to_string

2020-04-25 Thread GitBox
stale[bot] commented on pull request #2033: URL: https://github.com/apache/thrift/pull/2033#issuecomment-619497064 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contrib

Thtrift needs you: Looking for language maintainers

2020-04-25 Thread Jens Geyer
Hi all, as you all know Thrift has a fairly decent set of supported languages and language flavours. What the project needs at this stage might be YOU. You are an Haskell expert or love C-glib? You are working for eternities with JavaScript, NodeJS, TypeScript, Ruby or Java and know the rope

[GitHub] [thrift] Jens-G edited a comment on pull request #2118: Add cmake support for C# netstd

2020-04-25 Thread GitBox
Jens-G edited a comment on pull request #2118: URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616 +1 LGTM but not tested. Except of course that CI is all red. Do we need to update documents (like *md) maybe? --

[GitHub] [thrift] Jens-G edited a comment on pull request #2118: Add cmake support for C# netstd

2020-04-25 Thread GitBox
Jens-G edited a comment on pull request #2118: URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616 +1 LGTM but not tested. Except of course that CI is all red. This is an automated message from the Apac

[GitHub] [thrift] Jens-G commented on pull request #2118: Add cmake support for C# netstd

2020-04-25 Thread GitBox
Jens-G commented on pull request #2118: URL: https://github.com/apache/thrift/pull/2118#issuecomment-619382616 +1 LGTM but not tested This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [thrift] wyjwang commented on pull request #2064: THRIFT-5144: Fix memory leak when generate deserialize list element

2020-04-25 Thread GitBox
wyjwang commented on pull request #2064: URL: https://github.com/apache/thrift/pull/2064#issuecomment-619348568 Yes, I found the problem with ASAN and checked it with ASAN after solving it. The problem of incomplete display of g_malloc can be solved by configuring this parameter.

[jira] [Updated] (THRIFT-5039) thrift npm package should be published from root folder

2020-04-25 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5039: --- Component/s: (was: JavaScript - Library) Node.js - Library > thrift npm package

[jira] [Resolved] (THRIFT-5170) Node.js not working at all for Thrift 0.13.0 as published to npm

2020-04-25 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5170. Resolution: Duplicate > Node.js not working at all for Thrift 0.13.0 as published to npm > ---

[jira] [Assigned] (THRIFT-5170) Node.js not working at all for Thrift 0.13.0 as published to npm

2020-04-25 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-5170: -- Assignee: Mario Emmenlauer > Node.js not working at all for Thrift 0.13.0 as published to npm

[jira] [Updated] (THRIFT-5170) Node.js not working at all for Thrift 0.13.0 as published to npm

2020-04-25 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5170: --- Summary: Node.js not working at all for Thrift 0.13.0 as published to npm (was: [Javascript] Node.j

[jira] [Updated] (THRIFT-5170) Node.js not working at all for Thrift 0.13.0 as published to npm

2020-04-25 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5170: --- Component/s: Node.js - Library > Node.js not working at all for Thrift 0.13.0 as published to npm >

[GitHub] [thrift] dcelasun commented on pull request #2117: Supplement TBinaryprotocol module testcase

2020-04-25 Thread GitBox
dcelasun commented on pull request #2117: URL: https://github.com/apache/thrift/pull/2117#issuecomment-619344705 Tests are failing: ``` # Python code style flake8 ./lib/py/test/thrift_TBinaryProtocol.py:1:1: F401 'sys' imported but unused ./lib/py/test/thrift_TBinaryProtocol.p