[GitHub] [thrift] summerCol commented on a change in pull request #2122: add testcase for compactprotocol(python)

summerCol commented on a change in pull request #2122: URL: https://github.com/apache/thrift/pull/2122#discussion_r41552 ## File path: lib/py/test/testcompact.py ## @@ -0,0 +1,91 @@ + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [thrift] summerCol commented on a change in pull request #2122: add testcase for compactprotocol(python)

summerCol commented on a change in pull request #2122: URL: https://github.com/apache/thrift/pull/2122#discussion_r41467 ## File path: lib/py/test/testcompact.py ## @@ -0,0 +1,91 @@ + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [thrift] summerCol commented on a change in pull request #2122: add testcase for compactprotocol(python)

summerCol commented on a change in pull request #2122: URL: https://github.com/apache/thrift/pull/2122#discussion_r415553746 ## File path: lib/py/test/testcompact.py ## @@ -0,0 +1,91 @@ + Review comment: Remove this empty line. ## File path: lib/py/test/testcom

[GitHub] [thrift] zeshuai007 opened a new pull request #2123: Update doc/install/README.md

zeshuai007 opened a new pull request #2123: URL: https://github.com/apache/thrift/pull/2123 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your

[GitHub] [thrift] zeshuai007 opened a new pull request #2122: add testcase for compactprotocol(python)

zeshuai007 opened a new pull request #2122: URL: https://github.com/apache/thrift/pull/2122 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does your

Re: Spammy gitbox

Ping. Please move GitHub email notifications to a separate list. They are making this dev list impossible to follow. On Thu, Apr 23, 2020 at 5:18 PM Christopher wrote: > > Hi Thrift Devs, > > Recently, it seems GitBox has been updated to start spamming the > Thrift dev list. This produces a lot o

[GitHub] [thrift] janosvitok commented on pull request #2069: THRIFT-5150: Fix compilation with Swift 5.2

janosvitok commented on pull request #2069: URL: https://github.com/apache/thrift/pull/2069#issuecomment-619711785 Ready to merge. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [thrift] penenin commented on a change in pull request #2121: THRIFT-5185: Add support for using WebSockets as a server transport.

penenin commented on a change in pull request #2121: URL: https://github.com/apache/thrift/pull/2121#discussion_r415449352 ## File path: lib/cpp/src/thrift/endian.h ## @@ -0,0 +1,124 @@ +// Review comment: Since I didn't author the file, but it states that it is in the

[GitHub] [thrift] fishy commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers

fishy commented on pull request #2119: URL: https://github.com/apache/thrift/pull/2119#issuecomment-619647145 Failing tests are fixed. The CI failure seems to be gradle related. This is an automated message from the Apache Gi

[GitHub] [thrift] stale[bot] commented on pull request #2015: TCompactProtocol.tcc: add missing include cstdlib

stale[bot] commented on pull request #2015: URL: https://github.com/apache/thrift/pull/2015#issuecomment-619631457 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contrib

[GitHub] [thrift] stale[bot] commented on pull request #2030: THRIFT-5114: Simplified reallocation of TMemoryBuffer

stale[bot] commented on pull request #2030: URL: https://github.com/apache/thrift/pull/2030#issuecomment-619595612 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contrib

[GitHub] [thrift] stale[bot] commented on pull request #2035: THRIFT-5118: Fix memory leak when the handler method return a exception

stale[bot] commented on pull request #2035: URL: https://github.com/apache/thrift/pull/2035#issuecomment-619585301 This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contrib

[GitHub] [thrift] Jens-G commented on a change in pull request #2089: Supplementary testcase for py module

Jens-G commented on a change in pull request #2089: URL: https://github.com/apache/thrift/pull/2089#discussion_r415288133 ## File path: lib/py/test/thrift_transport.py ## @@ -0,0 +1,51 @@ +import unittest Review comment: ASF header missing --

[jira] [Assigned] (THRIFT-5177) getaddrinfo() should not be used for Unix sockets

[ https://issues.apache.org/jira/browse/THRIFT-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-5177: -- Assignee: Dmitry Maluka > getaddrinfo() should not be used for Unix sockets > ---

[jira] [Resolved] (THRIFT-5177) getaddrinfo() should not be used for Unix sockets

[ https://issues.apache.org/jira/browse/THRIFT-5177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5177. Fix Version/s: 0.14.0 Resolution: Fixed > getaddrinfo() should not be used for Unix sockets

[GitHub] [thrift] Jens-G commented on pull request #2102: THRIFT-5177: getaddrinfo() should not be used for Unix sockets

Jens-G commented on pull request #2102: URL: https://github.com/apache/thrift/pull/2102#issuecomment-619533475 Thanks @emmenlau for reviewing This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [thrift] zeshuai007 commented on pull request #2033: THRIFT-5117: Add unordered_map, unordered_set to to_string

zeshuai007 commented on pull request #2033: URL: https://github.com/apache/thrift/pull/2033#issuecomment-619528769 Hi @prudhvid, I don't found obvious errors in your code, but the CI failed largely. Can you solve it before the bot close it? ---

[GitHub] [thrift] stale[bot] commented on pull request #2033: THRIFT-5117: Add unordered_map, unordered_set to to_string

stale[bot] commented on pull request #2033: URL: https://github.com/apache/thrift/pull/2033#issuecomment-619528772 This issue is no longer stale. Thank you for your contributions. This is an automated message from the Apa

[GitHub] [thrift] zeshuai007 commented on pull request #2113: supplementary testcase for TJSONProtocol

zeshuai007 commented on pull request #2113: URL: https://github.com/apache/thrift/pull/2113#issuecomment-619519390 @dcelasun ，done. This is an automated message from the Apache Git Service. To respond to the message, please l