[GitHub] [thrift] zeshuai007 commented on pull request #2111: THRIFT-5179: Thrift compiler will generate wrong code if IDL struct's name is 'a' or 'b'

2020-04-27 Thread GitBox
zeshuai007 commented on pull request #2111: URL: https://github.com/apache/thrift/pull/2111#issuecomment-620322886 Hi @Jens-G , @dcelasun , can you help me review this PR? This is an automated message from the Apache Git

[GitHub] [thrift] zeshuai007 edited a comment on pull request #2089: Supplementary testcase for py module

2020-04-27 Thread GitBox
zeshuai007 edited a comment on pull request #2089: URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964 @Jens-G, @dcelasun , I have fixed the conflict, and the CI has passed. This is an automated

[GitHub] [thrift] zeshuai007 commented on pull request #2089: Supplementary testcase for py module

2020-04-27 Thread GitBox
zeshuai007 commented on pull request #2089: URL: https://github.com/apache/thrift/pull/2089#issuecomment-620313964 @Jens-G I have fixed the conflict, and the CI has passed. This is an automated message from the Apache

Re: Spammy gitbox

2020-04-27 Thread Christopher
It doesn't look like Thrift has a separate notifications list. I recommend requesting one, then updating the .asf.yaml file in the repo to send notifications there. On Mon, Apr 27, 2020 at 5:49 PM Daniel Gruno wrote: > > Please see https://s.apache.org/asfyaml-notify for how to set up >

[jira] [Commented] (THRIFT-5164) Go middleware support

2020-04-27 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094027#comment-17094027 ] Yuxuan Wang commented on THRIFT-5164: - So after I created this ticket, we also implemented a

Re: Thrift needs you: Looking for language maintainers

2020-04-27 Thread Jens Geyer
You’re welcome! Get started and be not afraid to ask if you need something. Have fun, JensG From: Abhishek Chhajer Sent: Monday, April 27, 2020 10:06 PM To: Jens Geyer ; dev@thrift.apache.org Subject: Re: Thrift needs you: Looking for language maintainers I am interested in working on Java

[jira] [Resolved] (THRIFT-5188) Occasional ERROR_INSUFFICIENT_BUFFER at WinHttpQueryHeaders()

2020-04-27 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5188. Fix Version/s: 0.14.0 Assignee: Jens Geyer Resolution: Fixed > Occasional

[jira] [Updated] (THRIFT-5188) Occasional ERROR_INSUFFICIENT_BUFFER at WinHttpQueryHeaders()

2020-04-27 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5188: --- Attachment: 0001-THRIFT-5188-Occasional-ERROR_INSUFFICIENT_BUFFER-at-.patch > Occasional

[jira] [Updated] (THRIFT-5188) Occasional ERROR_INSUFFICIENT_BUFFER at WinHttpQueryHeaders()

2020-04-27 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5188: --- Description: Calls {{WinHttpQueryHeaders()}} sometimes return error 122

[jira] [Created] (THRIFT-5188) Occasional ERROR_INSUFFICIENT_BUFFER at WinHttpQueryHeaders()

2020-04-27 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5188: -- Summary: Occasional ERROR_INSUFFICIENT_BUFFER at WinHttpQueryHeaders() Key: THRIFT-5188 URL: https://issues.apache.org/jira/browse/THRIFT-5188 Project: Thrift

[jira] [Resolved] (THRIFT-5164) Go middleware support

2020-04-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5164. -- Fix Version/s: 0.14.0 Resolution: Fixed > Go middleware support >

[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers

2020-04-27 Thread GitBox
dcelasun commented on pull request #2119: URL: https://github.com/apache/thrift/pull/2119#issuecomment-620157935 Merged, thanks for the PR @pacejackson! This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (THRIFT-5187) Add support for Unix domain sockets on Windows 10 or later

2020-04-27 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093776#comment-17093776 ] Mario Emmenlauer commented on THRIFT-5187: -- Correction: According to

[GitHub] [thrift] pacejackson commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers

2020-04-27 Thread GitBox
pacejackson commented on pull request #2119: URL: https://github.com/apache/thrift/pull/2119#issuecomment-620115399 Updated :) This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (THRIFT-5187) Add support for Unix domain sockets on Windows 10 or later

2020-04-27 Thread Mario Emmenlauer (Jira)
Mario Emmenlauer created THRIFT-5187: Summary: Add support for Unix domain sockets on Windows 10 or later Key: THRIFT-5187 URL: https://issues.apache.org/jira/browse/THRIFT-5187 Project: Thrift

[GitHub] [thrift] penenin edited a comment on pull request #2079: THRIFT-5159: Fix runtime ReferenceError in generated code

2020-04-27 Thread GitBox
penenin edited a comment on pull request #2079: URL: https://github.com/apache/thrift/pull/2079#issuecomment-620052366 It looks like Travis ran again successfully. Please let me know if that is sufficient for what you wanted.

[GitHub] [thrift] dcelasun commented on pull request #2079: THRIFT-5159: Fix runtime ReferenceError in generated code

2020-04-27 Thread GitBox
dcelasun commented on pull request #2079: URL: https://github.com/apache/thrift/pull/2079#issuecomment-620053009 Indeed, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [thrift] penenin commented on pull request #2079: THRIFT-5159: Fix runtime ReferenceError in generated code

2020-04-27 Thread GitBox
penenin commented on pull request #2079: URL: https://github.com/apache/thrift/pull/2079#issuecomment-620052366 It looks like Travis ran again successfully. Please let know if that is sufficient for what you wanted. This is

[GitHub] [thrift] ulidtko opened a new pull request #2124: THRIFT-5186: Don't pass AI_ADDRCONFIG to getaddrinfo()

2020-04-27 Thread GitBox
ulidtko opened a new pull request #2124: URL: https://github.com/apache/thrift/pull/2124 Hi! Please see the [Jira issue][THRIFT-5186] for rationale. Basically, this patch enables Thrift clients & servers to continue working in "offline mode" — when only the loopback interace `lo`

[GitHub] [thrift] cfriedt commented on pull request #2030: THRIFT-5114: Simplified reallocation of TMemoryBuffer

2020-04-27 Thread GitBox
cfriedt commented on pull request #2030: URL: https://github.com/apache/thrift/pull/2030#issuecomment-620006879 Getting pushed back again, sorry. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [thrift] stale[bot] commented on pull request #2030: THRIFT-5114: Simplified reallocation of TMemoryBuffer

2020-04-27 Thread GitBox
stale[bot] commented on pull request #2030: URL: https://github.com/apache/thrift/pull/2030#issuecomment-620006900 This issue is no longer stale. Thank you for your contributions. This is an automated message from the

[jira] [Updated] (THRIFT-5186) AI_ADDRCONFIG: Thrift libraries crash with localhost-only network.

2020-04-27 Thread Max (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Max updated THRIFT-5186: Attachment: 0001-THRIFT-5186-Dont-pass-AI_ADDRCONFIG-to-getaddrinfo.patch > AI_ADDRCONFIG: Thrift libraries crash

[jira] [Created] (THRIFT-5186) AI_ADDRCONFIG: Thrift libraries crash with localhost-only network.

2020-04-27 Thread Max (Jira)
Max created THRIFT-5186: --- Summary: AI_ADDRCONFIG: Thrift libraries crash with localhost-only network. Key: THRIFT-5186 URL: https://issues.apache.org/jira/browse/THRIFT-5186 Project: Thrift Issue

[GitHub] [thrift] emmenlau commented on pull request #2118: Add cmake support for C# netstd

2020-04-27 Thread GitBox
emmenlau commented on pull request #2118: URL: https://github.com/apache/thrift/pull/2118#issuecomment-619847306 The problem with the CI is not easily fixed for me. The issue comes from the fact that the autotools build does not resolve the dependency between tests and the Thrift library

[GitHub] [thrift] emmenlau commented on pull request #2029: Improved cmake robustness for subproject usage

2020-04-27 Thread GitBox
emmenlau commented on pull request #2029: URL: https://github.com/apache/thrift/pull/2029#issuecomment-619834916 This is fixed in latest master already. Closing. This is an automated message from the Apache Git Service. To

[GitHub] [thrift] dcelasun commented on pull request #2119: THRIFT-5164: add middleware framework for Go servers

2020-04-27 Thread GitBox
dcelasun commented on pull request #2119: URL: https://github.com/apache/thrift/pull/2119#issuecomment-619813948 All right tests are green, I've managed to play around with it locally and everything looks good. One small thing: Since this is a breaking change for `TProcessor`,

[jira] [Resolved] (THRIFT-5184) D: WebSocket Server Transport Fix for Firefox

2020-04-27 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duru Can Celasun resolved THRIFT-5184. -- Resolution: Fixed > D: WebSocket Server Transport Fix for Firefox >

[GitHub] [thrift] dcelasun commented on pull request #2117: Supplement TBinaryprotocol module testcase

2020-04-27 Thread GitBox
dcelasun commented on pull request #2117: URL: https://github.com/apache/thrift/pull/2117#issuecomment-619798847 @zeshuai007 thanks, merged. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [thrift] zeshuai007 commented on pull request #2117: Supplement TBinaryprotocol module testcase

2020-04-27 Thread GitBox
zeshuai007 commented on pull request #2117: URL: https://github.com/apache/thrift/pull/2117#issuecomment-619790668 @dcelasun , I have modified it, and the CI has passed. This is an automated message from the Apache Git

[GitHub] [thrift] dcelasun commented on pull request #2033: THRIFT-5117: Add unordered_map, unordered_set to to_string

2020-04-27 Thread GitBox
dcelasun commented on pull request #2033: URL: https://github.com/apache/thrift/pull/2033#issuecomment-619780027 @prudhvid please rebase from master. There have been some CI fixes and I'd like to see a green build before merging.

[GitHub] [thrift] summerCol commented on a change in pull request #2122: add testcase for compactprotocol(python)

2020-04-27 Thread GitBox
summerCol commented on a change in pull request #2122: URL: https://github.com/apache/thrift/pull/2122#discussion_r41552 ## File path: lib/py/test/testcompact.py ## @@ -0,0 +1,91 @@ + +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [thrift] summerCol commented on a change in pull request #2122: add testcase for compactprotocol(python)

2020-04-27 Thread GitBox
summerCol commented on a change in pull request #2122: URL: https://github.com/apache/thrift/pull/2122#discussion_r415553746 ## File path: lib/py/test/testcompact.py ## @@ -0,0 +1,91 @@ + Review comment: Remove this empty line. ## File path:

[GitHub] [thrift] zeshuai007 opened a new pull request #2123: Update doc/install/README.md

2020-04-27 Thread GitBox
zeshuai007 opened a new pull request #2123: URL: https://github.com/apache/thrift/pull/2123 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does

[GitHub] [thrift] zeshuai007 opened a new pull request #2122: add testcase for compactprotocol(python)

2020-04-27 Thread GitBox
zeshuai007 opened a new pull request #2122: URL: https://github.com/apache/thrift/pull/2122 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [ ] If a ticket exists: Does