[GitHub] [thrift] taiyangc opened a new pull request #2154: THRIFT-5195: Handle Thrift union type sending for Swift

2020-05-22 Thread GitBox
taiyangc opened a new pull request #2154: URL: https://github.com/apache/thrift/pull/2154 Swift should handle union type (enum) correctly when packing into a struct type for sending. Note that union types are essentially structs with all optionals, so a specific check on t

[jira] [Commented] (THRIFT-5214) go: Implement connection check in TSocket

2020-05-22 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114411#comment-17114411 ] Yuxuan Wang commented on THRIFT-5214: - I implemented it in https://github.com/apache

[GitHub] [thrift] fishy opened a new pull request #2153: THRIFT-5214: Connectivity check on go's TSocket

2020-05-22 Thread GitBox
fishy opened a new pull request #2153: URL: https://github.com/apache/thrift/pull/2153 Client: go Implement connectivity check on go's TSocket and TSSLSocket for non-Windows systems. The implementation is inspired by https://github.blog/2020-05-20-three-bugs-in-the-go-mys

Vala

2020-05-22 Thread James Lacey
I have extended the Thrift compiler and c_glib library to support Vala. There is still a lot of work to do before it would be ready for a PR, but I have the tutorial client and server interacting with other languages' implementation of the tutorial. If anyone is interested, I need some help with au

[GitHub] [thrift] penenin opened a new pull request #2152: THRIFT-5215: Remove portable_endian.h

2020-05-22 Thread GitBox
penenin opened a new pull request #2152: URL: https://github.com/apache/thrift/pull/2152 Client: cpp Remove portable_endian.h - [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes

[jira] [Created] (THRIFT-5215) C++: Remove portable_endian.h

2020-05-22 Thread James Lacey (Jira)
James Lacey created THRIFT-5215: --- Summary: C++: Remove portable_endian.h Key: THRIFT-5215 URL: https://issues.apache.org/jira/browse/THRIFT-5215 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-5182) Disable VS2015 in favor of VS2019?

2020-05-22 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113836#comment-17113836 ] Zezeng Wang commented on THRIFT-5182: - Current VS project has some building errors,

[jira] [Commented] (THRIFT-5214) go: Implement connection check in TSocket

2020-05-22 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113828#comment-17113828 ] Duru Can Celasun commented on THRIFT-5214: -- 1. Github's fix for that issue was