[GitHub] [thrift] Jens-G closed pull request #2000: THRIFT-5082: Add a Class reference for PHP enum $_TSPEC

2020-06-09 Thread GitBox
Jens-G closed pull request #2000: URL: https://github.com/apache/thrift/pull/2000 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (THRIFT-5082) Add a Class reference for PHP enum $_TSPEC

2020-06-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5082. Fix Version/s: 0.14.0 Assignee: Stanislav Resolution: Fixed > Add a Class

[jira] [Commented] (THRIFT-5186) AI_ADDRCONFIG: Thrift libraries crash with localhost-only network.

2020-06-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17129807#comment-17129807 ] Jens Geyer commented on THRIFT-5186: Original comment from

[jira] [Resolved] (THRIFT-5186) AI_ADDRCONFIG: Thrift libraries crash with localhost-only network.

2020-06-09 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5186. Resolution: Fixed > AI_ADDRCONFIG: Thrift libraries crash with localhost-only network. >

[GitHub] [thrift] Jens-G closed pull request #2151: THRIFT-5186: Rewrite address resolution in T{Nonblocking,}ServerSocket [REVIEW WANTED]

2020-06-09 Thread GitBox
Jens-G closed pull request #2151: URL: https://github.com/apache/thrift/pull/2151 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [thrift] dcelasun merged pull request #2176: THRIFT-5214: Reset read deadline in socketConn

2020-06-09 Thread GitBox
dcelasun merged pull request #2176: URL: https://github.com/apache/thrift/pull/2176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [thrift] dcelasun merged pull request #2172: THRIFT-5214: Push read deadline in socketConn

2020-06-09 Thread GitBox
dcelasun merged pull request #2172: URL: https://github.com/apache/thrift/pull/2172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [thrift] em010272 opened a new pull request #2177: Adding LOGGER.isDebugEnabled() conditional statements into TSaslTransport

2020-06-09 Thread GitBox
em010272 opened a new pull request #2177: URL: https://github.com/apache/thrift/pull/2177 ….thrift.transport.TSaslTransport to fix the issue 4926 - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not

[GitHub] [thrift] paroga closed pull request #2175: Fix missing signal.h include

2020-06-09 Thread GitBox
paroga closed pull request #2175: URL: https://github.com/apache/thrift/pull/2175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [thrift] fishy opened a new pull request #2176: THRIFT-5214: Reset read deadline in socketConn

2020-06-09 Thread GitBox
fishy opened a new pull request #2176: URL: https://github.com/apache/thrift/pull/2176 Client: go This is a slightly different approach from the fix in e382275b. The previous approach relying on passing the set socket timeout into the underlying socketConn from TSocket and

[GitHub] [thrift] xqfu opened a new pull request #2179: THRIFT-4930: Remove LOGGER.warn in org.apache.thrift.transport.TSocket

2020-06-09 Thread GitBox
xqfu opened a new pull request #2179: URL: https://github.com/apache/thrift/pull/2179 Remove LOGGER.warn in org.apache.thrift.transport.TSocket to fix the issues 4930 and 4924 In org.apache.thrift.transport.TSocket in the previous approach, sensitive information about socket input

[GitHub] [thrift] Rapotkinnik opened a new pull request #2180: THRIFT-5104: Forward call context into handlers

2020-06-09 Thread GitBox
Rapotkinnik opened a new pull request #2180: URL: https://github.com/apache/thrift/pull/2180 https://issues.apache.org/jira/browse/THRIFT-5104 Generating additional methods of If which accept call context to achive for example such a feature as authorization. This change

[GitHub] [thrift] dcelasun merged pull request #2174: THRIFT-5214: Partial rewrite of TFramedTransport

2020-06-09 Thread GitBox
dcelasun merged pull request #2174: URL: https://github.com/apache/thrift/pull/2174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [thrift] xiaoqin-fu opened a new pull request #2178: THRIFT-4928: Adding LOGGER.isInfoEnabled()() condition into TTransport

2020-06-09 Thread GitBox
xiaoqin-fu opened a new pull request #2178: URL: https://github.com/apache/thrift/pull/2178 Adding LOGGER.isInfoEnabled() conditional statement into org.apache.thrift.transport.thrift.transport.TTransport to fix the issue 4928 In org.apache.thrift.transport.TTransport in the

[GitHub] [thrift] dcelasun merged pull request #2173: Use io.CopyN to simplify THeaderTransport code

2020-06-09 Thread GitBox
dcelasun merged pull request #2173: URL: https://github.com/apache/thrift/pull/2173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: C++ reviewers for PR 2151 wanted

2020-06-09 Thread Randy Abernethy
Just took a look. +1 On Tue, Jun 9, 2020 at 12:59 AM max ulidtko wrote: > Hi list, > > I'm the PR author — calling out for reviewers! > > The diff is under 1 kLoC. > > I have it well-groomed already: > • CI bots are green; > • new code is clang-formatted; > • entry in CHANGES.md added; > •

Re: C++ reviewers for PR 2151 wanted

2020-06-09 Thread max ulidtko
Hi list, I'm the PR author — calling out for reviewers! The diff is under 1 kLoC. I have it well-groomed already: • CI bots are green; • new code is clang-formatted; • entry in CHANGES.md added; • both buildsystems adjusted for new file; • non-pertinent changes split off; • Jens Geyer's