Jens-G closed pull request #2291:
URL: https://github.com/apache/thrift/pull/2291
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/THRIFT-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-5198.
Resolution: Fixed
> Fix certain Visual Studio hints in generated netstd code
>
[
https://issues.apache.org/jira/browse/THRIFT-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5198:
---
Attachment: (was:
0001-THRIFT-5198-Fix-certain-Visual-Studio-hints-in-gener.patch)
> Fix
[
https://issues.apache.org/jira/browse/THRIFT-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5198:
---
Attachment: 0001-THRIFT-5198-Fix-certain-Visual-Studio-hints-in-gener.patch
> Fix certain Visual
[
https://issues.apache.org/jira/browse/THRIFT-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5198:
---
Attachment: 0001-THRIFT-5198-Fix-certain-Visual-Studio-hints-in-gener.patch
> Fix certain Visual
[
https://issues.apache.org/jira/browse/THRIFT-5198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reopened THRIFT-5198:
Depending on the IDL in question, we now also may get:
* IDE0079 remove unnecessary suppression
>
[
https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246680#comment-17246680
]
Yuxuan Wang edited comment on THRIFT-4685 at 12/9/20, 5:17 PM:
---
[~slon]
[
https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246680#comment-17246680
]
Yuxuan Wang commented on THRIFT-4685:
-
[~slon] Thanks. I understood the situation.
If the only
[
https://issues.apache.org/jira/browse/THRIFT-4685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17246349#comment-17246349
]
Fedor Korotkiy commented on THRIFT-4685:
I think it is necessary to explain original problem