[jira] [Commented] (THRIFT-5342) Apply 'noexcept' attribute to Init/Copy/Move Constructors and Assignments

2021-03-29 Thread Kashirin Alex (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311028#comment-17311028 ] Kashirin Alex commented on THRIFT-5342: --- Yes, it is correct the parent-task is the Pull-Request#

[GitHub] [thrift] aaronstgeorge-wf opened a new pull request #2366: THRIFT-5383 Remove unnecessary bounds check

2021-03-29 Thread GitBox
aaronstgeorge-wf opened a new pull request #2366: URL: https://github.com/apache/thrift/pull/2366 The added test passes with thrift 0.13.0 and fails on 0.14.0. The source of the error seems to be an unnecessary bounds check when reading JSON string. - [x] Did you

[jira] [Updated] (THRIFT-5383) TJSONProtocol Java readString throws on bounds check

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5383: --- Summary: TJSONProtocol Java readString throws on bounds check (was: TJSONProtocol Java readString

[jira] [Comment Edited] (THRIFT-5383) TJSONProtocol Java readString throws on unnecessary bounds check

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310997#comment-17310997 ] Jens Geyer edited comment on THRIFT-5383 at 3/29/21, 9:25 PM: -- > this line

[jira] [Commented] (THRIFT-5383) TJSONProtocol Java readString throws on unnecessary bounds check

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310997#comment-17310997 ] Jens Geyer commented on THRIFT-5383: > this line appears to be unnecessary. I think "misplaced"

[jira] [Resolved] (THRIFT-5385) XML-HTTP client reports IsOpen=TRUE even if it is not

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5385. Fix Version/s: 0.15.0 Resolution: Fixed > XML-HTTP client reports IsOpen=TRUE even if it

[jira] [Resolved] (THRIFT-5384) Improved error message for HTTP transports

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5384. Fix Version/s: 0.15.0 Resolution: Fixed > Improved error message for HTTP transports >

[jira] [Resolved] (THRIFT-5386) XML-HTTP client may throw "max message size reached" incorrectly

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5386. Fix Version/s: 0.15.0 Resolution: Fixed > XML-HTTP client may throw "max message size

[jira] [Resolved] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5387. Fix Version/s: 0.15.0 Resolution: Fixed > Improved and simplified Delphi test setup >

[jira] [Updated] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5387: --- Attachment: 0001-THRIFT-5387-Improved-and-simplified-Delphi-test-setu.patch > Improved and

[jira] [Updated] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5387: --- Attachment: (was: 0004-THRIFT-5387-Improved-and-simplified-Delphi-test-setu.patch) > Improved

[jira] [Updated] (THRIFT-5385) XML-HTTP client reports IsOpen=TRUE even if it is not

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5385: --- Attachment: 0001-THRIFT-5385-XML-HTTP-client-reports-IsOpen-TRUE-even.patch > XML-HTTP client

[jira] [Updated] (THRIFT-5384) Improved error message for HTTP transports

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5384: --- Attachment: 0002-THRIFT-5384-Improved-error-message-for-HTTP-transpor.patch > Improved error

[jira] [Updated] (THRIFT-5386) XML-HTTP client may throw "max message size reached" incorrectly

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5386: --- Attachment: 0003-THRIFT-5386-XML-HTTP-client-may-throw-max-message-si.patch > XML-HTTP client may

[jira] [Updated] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5387: --- Attachment: 0001-THRIFT-5385-XML-HTTP-client-reports-IsOpen-TRUE-even.patch > Improved and

[jira] [Updated] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5387: --- Attachment: (was: 0001-THRIFT-5385-XML-HTTP-client-reports-IsOpen-TRUE-even.patch) > Improved

[jira] [Updated] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5387: --- Attachment: 0004-THRIFT-5387-Improved-and-simplified-Delphi-test-setu.patch > Improved and

[jira] [Created] (THRIFT-5387) Improved and simplified Delphi test setup

2021-03-29 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5387: -- Summary: Improved and simplified Delphi test setup Key: THRIFT-5387 URL: https://issues.apache.org/jira/browse/THRIFT-5387 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-5386) XML-HTTP client may throw "max message size reached" incorrectly

2021-03-29 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5386: -- Summary: XML-HTTP client may throw "max message size reached" incorrectly Key: THRIFT-5386 URL: https://issues.apache.org/jira/browse/THRIFT-5386 Project: Thrift

[jira] [Created] (THRIFT-5385) XML-HTTP client reports IsOpen=TRUE even if it is not

2021-03-29 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5385: -- Summary: XML-HTTP client reports IsOpen=TRUE even if it is not Key: THRIFT-5385 URL: https://issues.apache.org/jira/browse/THRIFT-5385 Project: Thrift Issue

[jira] [Created] (THRIFT-5384) Improved error message for HTTP transports

2021-03-29 Thread Jens Geyer (Jira)
Jens Geyer created THRIFT-5384: -- Summary: Improved error message for HTTP transports Key: THRIFT-5384 URL: https://issues.apache.org/jira/browse/THRIFT-5384 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-5383) TJSONProtocol Java readString throws on unnecessary bounds check

2021-03-29 Thread Aaron St. George (Jira)
Aaron St. George created THRIFT-5383: Summary: TJSONProtocol Java readString throws on unnecessary bounds check Key: THRIFT-5383 URL: https://issues.apache.org/jira/browse/THRIFT-5383 Project:

[jira] [Commented] (THRIFT-5342) Apply 'noexcept' attribute to Init/Copy/Move Constructors and Assignments

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17310455#comment-17310455 ] Jens Geyer commented on THRIFT-5342: > label pull-request-available Would be more helpful to know

[jira] [Resolved] (THRIFT-5341) Fix Old-Style-Cast, Missing override and Possible noexcept

2021-03-29 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5341. Fix Version/s: 0.15.0 Resolution: Fixed No further comments or objections from anyone, so

[GitHub] [thrift] Jens-G closed pull request #2318: THRIFT-5341: Fix Old-Style-Cast, Missing override and Possible noexcept

2021-03-29 Thread GitBox
Jens-G closed pull request #2318: URL: https://github.com/apache/thrift/pull/2318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please