question about pull request

2021-08-05 Thread Bhalchandra Pandit
I created this pull request which only has javadoc fixes. Apparently, some checks failed (appveyor and travis ci). I looked at the links but I am not able to figure out why they failed for javadoc only changes. Can someone please help me understand the

[jira] [Updated] (THRIFT-5450) AppVeyor CI does not run any MSVC tests?

2021-08-05 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer updated THRIFT-5450: - Description: I've just checked the CI for MSVC tests, and found the following

[jira] [Created] (THRIFT-5450) AppVeyor CI does not run any MSVC tests?

2021-08-05 Thread Mario Emmenlauer (Jira)
Mario Emmenlauer created THRIFT-5450: Summary: AppVeyor CI does not run any MSVC tests? Key: THRIFT-5450 URL: https://issues.apache.org/jira/browse/THRIFT-5450 Project: Thrift Issue

[jira] [Closed] (THRIFT-5077) Failed to build tests with non system boost location

2021-08-05 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer closed THRIFT-5077. > Failed to build tests with non system boost location >

[jira] [Resolved] (THRIFT-5077) Failed to build tests with non system boost location

2021-08-05 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Emmenlauer resolved THRIFT-5077. -- Resolution: Not A Problem A standard cmake config option exists to resolve the issue.

[jira] [Commented] (THRIFT-5077) Failed to build tests with non system boost location

2021-08-05 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17393988#comment-17393988 ] Mario Emmenlauer commented on THRIFT-5077: -- Closing because setting `BOOST_ROOT` in cmake fixes

[GitHub] [thrift] frankiechang123 closed pull request #2430: THRIFT-5449: Use poll instead of select in Python TNonblockingServer if available

2021-08-05 Thread GitBox
frankiechang123 closed pull request #2430: URL: https://github.com/apache/thrift/pull/2430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

AppVeyor build instructions update imminent - is it ok?

2021-08-05 Thread Mario Emmenlauer
Dear Thrift developers, I've concerned myself with the AppVeyor build instructions just because a number of recent builds had failed. Now I'm under the impression that the build instructions can use a bit of love and cleanup. I've started to work on the build in the following PR:

[jira] [Updated] (THRIFT-5449) Use select.poll instead of select.select in Python TNonblockingServer if available

2021-08-05 Thread Yiyang Zhou (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yiyang Zhou updated THRIFT-5449: External issue URL: (was: https://github.com/apache/thrift/pull/2430) > Use select.poll instead

[GitHub] [thrift] frankiechang123 opened a new pull request #2432: THRIFT-5449: Use poll instead of select in Python TNonblockingServer …

2021-08-05 Thread GitBox
frankiechang123 opened a new pull request #2432: URL: https://github.com/apache/thrift/pull/2432 Use poll instead of select if possible Currently, Python TNonblockingServer uses `select.select` to monitor the IO of all existing connections. The value of file descriptors