[jira] [Comment Edited] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522069#comment-17522069 ] Tian Jiang edited comment on THRIFT-5483 at 4/14/22 5:41 AM: - Yes, defining

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522069#comment-17522069 ] Tian Jiang commented on THRIFT-5483: Yes, defining a separate key is just my current solution for

[jira] [Comment Edited] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu edited comment on THRIFT-5483 at 4/14/22 4:41 AM: OK in this case

[jira] [Comment Edited] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu edited comment on THRIFT-5483 at 4/14/22 4:40 AM: OK in this case

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522058#comment-17522058 ] Liu Jiayu commented on THRIFT-5483: --- OK in this case your issue isn't related to comparator, but

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522046#comment-17522046 ] Tian Jiang commented on THRIFT-5483: [~jiayuliu] Sadly, it does use `compareTo` to judge if two keys

[jira] [Updated] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tian Jiang updated THRIFT-5483: --- Attachment: screenshot-1.png > Support customized comparator in Java >

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522044#comment-17522044 ] Liu Jiayu commented on THRIFT-5483: --- [~jt2594838]  I don't follow your example. HashMap is unordered,

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522042#comment-17522042 ] Tian Jiang commented on THRIFT-5483: [~jiayuliu] Thanks for your suggestion, but it only works with

[jira] [Commented] (THRIFT-5014) Do Direct Comparison on Raw Values Instead of Objects

[ https://issues.apache.org/jira/browse/THRIFT-5014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522043#comment-17522043 ] Liu Jiayu commented on THRIFT-5014: --- i think this issue can be closed given the pull request is merged

[jira] [Assigned] (THRIFT-5485) @SuppressWarnings is placed above Javadoc

[ https://issues.apache.org/jira/browse/THRIFT-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu reassigned THRIFT-5485: - Assignee: Liu Jiayu > @SuppressWarnings is placed above Javadoc >

[GitHub] [thrift] Jimexist opened a new pull request, #2573: THRIFT-5485: change the java gen @SuppressWarnings location

Jimexist opened a new pull request, #2573: URL: https://github.com/apache/thrift/pull/2573 THRIFT-5485: change the java gen @SuppressWarnings location - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required

[jira] [Updated] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu updated THRIFT-5483: -- Priority: Trivial (was: Major) > Support customized comparator in Java >

[jira] [Commented] (THRIFT-5483) Support customized comparator in Java

[ https://issues.apache.org/jira/browse/THRIFT-5483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17522041#comment-17522041 ] Liu Jiayu commented on THRIFT-5483: --- [~jt2594838] in my opinion this isn't something that should be

[jira] [Closed] (THRIFT-5524) Add param for option_type to generate JDK8 optional types but with postfix in parallel with original getter

[ https://issues.apache.org/jira/browse/THRIFT-5524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Jiayu closed THRIFT-5524. - Assignee: Liu Jiayu Resolution: Won't Fix after some discussion, won't go down this path. > Add

[GitHub] [thrift] Jens-G closed pull request #2559: THRIFT-5551: java generator to add @Override where possible

Jens-G closed pull request #2559: THRIFT-5551: java generator to add @Override where possible URL: https://github.com/apache/thrift/pull/2559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2570: Bump minimist from 1.2.5 to 1.2.6 in /lib/ts

dependabot[bot] opened a new pull request, #2570: URL: https://github.com/apache/thrift/pull/2570 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846;>7efb22a

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2569: Bump ajv from 6.7.0 to 6.12.6 in /lib/ts

dependabot[bot] opened a new pull request, #2569: URL: https://github.com/apache/thrift/pull/2569 Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.7.0 to 6.12.6. Release notes Sourced from https://github.com/ajv-validator/ajv/releases;>ajv's releases. v6.12.6 Fix

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2572: Bump cached-path-relative from 1.0.2 to 1.1.0 in /lib/ts

dependabot[bot] opened a new pull request, #2572: URL: https://github.com/apache/thrift/pull/2572 Bumps [cached-path-relative](https://github.com/ashaffer/cached-path-relative) from 1.0.2 to 1.1.0. Commits See full diff in

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2571: Bump minimist from 1.2.5 to 1.2.6 in /lib/js

dependabot[bot] opened a new pull request, #2571: URL: https://github.com/apache/thrift/pull/2571 Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. Commits https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846;>7efb22a

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2567: Bump ajv from 6.5.4 to 6.12.6

dependabot[bot] opened a new pull request, #2567: URL: https://github.com/apache/thrift/pull/2567 Bumps [ajv](https://github.com/ajv-validator/ajv) from 6.5.4 to 6.12.6. Release notes Sourced from https://github.com/ajv-validator/ajv/releases;>ajv's releases. v6.12.6 Fix

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2568: Bump ansi-regex from 3.0.0 to 3.0.1

dependabot[bot] opened a new pull request, #2568: URL: https://github.com/apache/thrift/pull/2568 Bumps [ansi-regex](https://github.com/chalk/ansi-regex) from 3.0.0 to 3.0.1. Commits https://github.com/chalk/ansi-regex/commit/f545bdb80048f527889eddb9ac1a851c6f2a2241;>f545bdb

[GitHub] [thrift] dependabot[bot] opened a new pull request, #2566: Bump cached-path-relative from 1.0.2 to 1.1.0 in /lib/js

dependabot[bot] opened a new pull request, #2566: URL: https://github.com/apache/thrift/pull/2566 Bumps [cached-path-relative](https://github.com/ashaffer/cached-path-relative) from 1.0.2 to 1.1.0. Commits See full diff in

[jira] [Resolved] (THRIFT-5555) Java codegen and library to support future-returning client interface and implementation

[ https://issues.apache.org/jira/browse/THRIFT-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-. Fix Version/s: 0.17.0 Assignee: Liu Jiayu Resolution: Fixed > Java codegen and

[GitHub] [thrift] Jens-G merged pull request #2564: Bump async from 3.2.1 to 3.2.3 in /lib/js

Jens-G merged PR #2564: URL: https://github.com/apache/thrift/pull/2564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (THRIFT-5555) Java codegen and library to support future-returning client interface and implementation

[ https://issues.apache.org/jira/browse/THRIFT-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-: --- Component/s: (was: Java - Library) > Java codegen and library to support future-returning

[GitHub] [thrift] Jens-G merged pull request #2562: THRIFT-5555: Java codegen and library to support future-returning client interface and implementation

Jens-G merged PR #2562: URL: https://github.com/apache/thrift/pull/2562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [thrift] pspeter opened a new pull request, #2565: Fix bug in THttpClient proxy handling

pspeter opened a new pull request, #2565: URL: https://github.com/apache/thrift/pull/2565 Previously, creating an instance of this class would throw whenever the http(s)_proxy environment variables were set, since it tried concatenating a string with a bytes array. -- This is an