Re: date/time/timestamp, following ISO 8601

2022-06-04 Thread Yuxuan Wang
I think precision is a big issue for a timestamp type. I found an article to discuss this issue across languages: https://nickb.dev/blog/iso8601-and-nanosecond-precision-across-languages/ In our own experience, we just typedef i64 to TimestampMilliseconds for milliseconds precision (example

Re: date/time/timestamp, following ISO 8601

2022-06-04 Thread Liu Jiayu
thank you for the detailed context - i didn't know about the past discussion and i can totally relate to the fact that it's a complex topic. coming from apache arrow, i've come to know its design choices (date32/64) - it's not perfect but i guess worth looking at, given it's also a

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Triton Circonflexe (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547959#comment-17547959 ] Triton Circonflexe commented on THRIFT-5587: Boost::Uuid library looks like a fine candidate

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Triton Circonflexe (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547956#comment-17547956 ] Triton Circonflexe commented on THRIFT-5587: I took a quick look and it seems that Wireshark

date/time/timestamp, following ISO 8601

2022-06-04 Thread Jens Geyer
jiayuliu wrote: > Taking a step back, I wonder if we can standardize on a paved path > for adding newer standalone types in terms of requiredness/optional, > plugin mechanism, and/or the level of language support, e.g. if I > want to add support for date/time/timestamp, following ISO 8601, >

[jira] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587 ] Liu Jiayu deleted comment on THRIFT-5587: --- was (Author: jiayuliu): Taking a step back, I wonder if we can standardize on a paved path for adding newer standalone types in terms of

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547944#comment-17547944 ] Jens Geyer commented on THRIFT-5587: This ticket is *not* about timestamps or any other tasks to

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547941#comment-17547941 ] Liu Jiayu commented on THRIFT-5587: --- Taking a step back, I wonder if we can standardize on a paved

[jira] [Commented] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Liu Jiayu (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547940#comment-17547940 ] Liu Jiayu commented on THRIFT-5587: --- I agree with that: * for binary use the 16 bytes and byte

[jira] [Updated] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5587: --- Description: I hereby propose to add *{{uuid}}* as an additional built-in basic type. *Rationale:*

[jira] [Updated] (THRIFT-5587) Introduce uuid as additional builtin type

2022-06-04 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5587: --- Summary: Introduce uuid as additional builtin type (was: Introduce guid as additional builtin

[jira] [Commented] (THRIFT-5587) Introduce guid as additional builtin type

2022-06-04 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17547938#comment-17547938 ] Jens Geyer commented on THRIFT-5587: {quote}for internal representation of the data, it's always