Re: Dropping Java 8 support?

2022-09-15 Thread Jiayu Liu
After 0.17 releaseĀ  i am proposing once again to upgrade to Java 11 minimal version. Any more feedback or concerns? On May 14, 2022, yuxuan wang wrote: > +1 for using jdk11 to build jdk8 compatible jar for now, and dropping > jdk8 > support later (we are already planning/working on migrating to j

Re: Java problems in the Travis builds

2022-09-15 Thread Jiayu Liu
I'm trying to resolve the JDK bug by upgrading to Java 17 in bionic build. The pull request is [1]. I also try to reduce excessive logging in [2] [1]: https://github.com/apache/thrift/pull/2662 [2]: https://github.com/apache/thrift/pull/2659 On September 11, 2022, yuxuan wang wrote: > So I looke

[jira] [Resolved] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5628. Fix Version/s: 0.18.0 Assignee: Philip Lee Resolution: Fixed > MaxMessageSize is n

[GitHub] [thrift] Jens-G merged pull request #2668: Thrift-5628: Call ResetConsumedMessageSize from ReadMessageEndAsync

2022-09-15 Thread GitBox
Jens-G merged PR #2668: URL: https://github.com/apache/thrift/pull/2668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@thrift.apache.or

[GitHub] [thrift] PhilPJL opened a new pull request, #2668: Thrift-5628: Call ResetConsumedMessageSize from ReadMessageEndAsync

2022-09-15 Thread GitBox
PhilPJL opened a new pull request, #2668: URL: https://github.com/apache/thrift/pull/2668 Made ResetConsumedMessageSize a public abstract member of TTransport. Implemented on all inheritors. Called ResetConsumedMessageSize from all ReadMessageEndAsync. -- This is an automated me

[jira] [Commented] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605181#comment-17605181 ] Jens Geyer commented on THRIFT-5628: > Would it make sense to call Flush on reads?

[jira] [Comment Edited] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Philip Lee (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605179#comment-17605179 ] Philip Lee edited comment on THRIFT-5628 at 9/15/22 8:03 AM: -

[jira] [Comment Edited] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605168#comment-17605168 ] Jens Geyer edited comment on THRIFT-5628 at 9/15/22 8:01 AM: -

[jira] [Commented] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Philip Lee (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605179#comment-17605179 ] Philip Lee commented on THRIFT-5628: Flush is called for send requests which is why

[jira] [Comment Edited] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605168#comment-17605168 ] Jens Geyer edited comment on THRIFT-5628 at 9/15/22 7:53 AM: -

[jira] [Comment Edited] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605168#comment-17605168 ] Jens Geyer edited comment on THRIFT-5628 at 9/15/22 7:52 AM: -

[jira] [Comment Edited] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605168#comment-17605168 ] Jens Geyer edited comment on THRIFT-5628 at 9/15/22 7:51 AM: -

[jira] [Commented] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605168#comment-17605168 ] Jens Geyer commented on THRIFT-5628: {quote}I'm thinking that ReadMessageEndAsync sh

[jira] [Commented] (THRIFT-5628) MaxMessageSize is never reset on a read buffer

2022-09-15 Thread Philip Lee (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605158#comment-17605158 ] Philip Lee commented on THRIFT-5628: The application polls some hardware collecting