[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679453#comment-17679453 ] Christopher Friedt commented on THRIFT-5678: I would be happy to expand the PR I have open

[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Christopher Friedt (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679452#comment-17679452 ] Christopher Friedt commented on THRIFT-5678: I would agree with Mario. Unless a class is

[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679449#comment-17679449 ] Mario Emmenlauer commented on THRIFT-5678: -- I'm currently travelling so I have limited internet

[jira] [Comment Edited] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679431#comment-17679431 ] Jens Geyer edited comment on THRIFT-5678 at 1/21/23 10:33 AM: -- I just had a

[jira] [Commented] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17679431#comment-17679431 ] Jens Geyer commented on THRIFT-5678: I just had a look at that mentioned commit and there are indeed

[jira] [Updated] (THRIFT-5678) TConnectedClient: warning due to non-virtual dtor

2023-01-21 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5678: --- Summary: TConnectedClient: warning due to non-virtual dtor (was: lib: cpp: TConnectedClient: