It looks like we didn't implement uuid in rust yet, so with swift already
fixed, Java/kotlin is the last one to fix.
On Thu, Aug 10, 2023 at 8:43 AM Yuxuan Wang wrote:
> Actually, only Java is remaining non-compliance while all other
> implementations are 16:
>
> === 8< ===
> fishy@perch:~/work/
fishy opened a new pull request, #2843:
URL: https://github.com/apache/thrift/pull/2843
It should be 16 not 17 according to the spec.
Currently ENUM holds 16, it's not in TBinaryProtocol spec and seems to be a
Java implementation detail somehow got mixed inside TType, move that to 255
Actually, only Java is remaining non-compliance while all other
implementations are 16:
=== 8< ===
fishy@perch:~/work/thrift/lib$ git grep -w 17 | grep -i uuid
java/src/main/java/org/apache/thrift/protocol/TType.java: public static
final byte UUID = 17;
java/src/test/java/org/apache/thrift/protoc
Sorry I'm changing my vote to -1.
I just realized that we still have
https://issues.apache.org/jira/browse/THRIFT-5653 unfixed. Basically we
shipped 0.18.0 and 0.18.1 with java, kotlin, rust, and swift with the
non-compliant UUID implementation. That probably didn't cause much problem
because the
