[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17564482#comment-17564482 ] Allen George commented on THRIFT-5283: -- [~tokcum]I'm so sorry, and I totally understand your

[jira] [Commented] (THRIFT-5594) Update crates.io with version 0.16.0

[ https://issues.apache.org/jira/browse/THRIFT-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561578#comment-17561578 ] Allen George commented on THRIFT-5594: -- [~pascal.bach] [~TennyZhuang] I'm incredibly sorry for the

[jira] [Resolved] (THRIFT-5594) Update crates.io with version 0.16.0

[ https://issues.apache.org/jira/browse/THRIFT-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5594. -- Resolution: Fixed > Update crates.io with version 0.16.0 >

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523999#comment-17523999 ] Allen George commented on THRIFT-5559: -- [~fayalalebrun] That change sounds reasonable. I don't

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523266#comment-17523266 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:25 AM: --- For

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523264#comment-17523264 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:22 AM: --- It's been

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523264#comment-17523264 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:22 AM: --- It's been

[jira] [Comment Edited] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523266#comment-17523266 ] Allen George edited comment on THRIFT-5559 at 4/17/22 2:21 AM: --- For

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523266#comment-17523266 ] Allen George commented on THRIFT-5559: -- For example, consider: {noformat} Trait_A + - Trait_B

[jira] [Commented] (THRIFT-5559) Processor can be implemented on handler trait itself

[ https://issues.apache.org/jira/browse/THRIFT-5559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17523264#comment-17523264 ] Allen George commented on THRIFT-5559: -- It's been a very, very long time since I've looked at the

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17514565#comment-17514565 ] Allen George commented on THRIFT-5283: -- [~tokcum] Yes - splitting Windows pipe support into a

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508514#comment-17508514 ] Allen George commented on THRIFT-5283: -- Took a quick look, and in general - looks good! One minor

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17508509#comment-17508509 ] Allen George commented on THRIFT-5283: -- [~tokcum] Sorry for the delay. I'll take a look over the

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17501862#comment-17501862 ] Allen George commented on THRIFT-5283: -- [~tokcum] Tobias - thank you so much for looking at this

[jira] [Resolved] (THRIFT-5457) Travis fails consistently on a Rust dependency

[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5457. -- Fix Version/s: 0.16.0 Resolution: Fixed > Travis fails consistently on a Rust

[jira] [Assigned] (THRIFT-5457) Travis fails consistently on a Rust dependency

[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5457: Assignee: Allen George > Travis fails consistently on a Rust dependency >

[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412308#comment-17412308 ] Allen George commented on THRIFT-5457: -- >From reading

[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17412301#comment-17412301 ] Allen George commented on THRIFT-5457: -- Really puzzled what's going on here, and why this would

[jira] [Assigned] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5392: Assignee: Allen George > Thrift Enums should generate forward compatible enum like code

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391182#comment-17391182 ] Allen George edited comment on THRIFT-5392 at 8/1/21, 3:51 PM: --- I don't

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17391182#comment-17391182 ] Allen George commented on THRIFT-5392: -- I don't mind reverting the change and then just using an

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317112#comment-17317112 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:38 AM: Also

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317114#comment-17317114 ] Allen George commented on THRIFT-5392: -- This is a separate concern for a separate ticket:

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317114#comment-17317114 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:37 AM: This is

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317112#comment-17317112 ] Allen George commented on THRIFT-5392: -- Also note that your concern: {noformat} // we allow

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317108#comment-17317108 ] Allen George commented on THRIFT-5392: -- Link to the comment where I considered it:

[jira] [Comment Edited] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317107#comment-17317107 ] Allen George edited comment on THRIFT-5392 at 4/8/21, 11:28 AM: I

[jira] [Commented] (THRIFT-5392) Thrift Enums should generate forward compatible enum like code

[ https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317107#comment-17317107 ] Allen George commented on THRIFT-5392: -- I considered using a sentinel value, but note that it would

[jira] [Resolved] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4098. -- Fix Version/s: 0.15.0 Resolution: Fixed > Support user-defined output namespaces in

[jira] [Resolved] (THRIFT-5363) All-caps constant rendered incorrectly

[ https://issues.apache.org/jira/browse/THRIFT-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5363. -- Fix Version/s: 0.15.0 Resolution: Fixed > All-caps constant rendered incorrectly >

[jira] [Resolved] (THRIFT-5360) Remove deprecated description() methods from Error types

[ https://issues.apache.org/jira/browse/THRIFT-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5360. -- Resolution: Fixed > Remove deprecated description() methods from Error types >

[jira] [Created] (THRIFT-5365) Implement the JSON protocol

Allen George created THRIFT-5365: Summary: Implement the JSON protocol Key: THRIFT-5365 URL: https://issues.apache.org/jira/browse/THRIFT-5365 Project: Thrift Issue Type: New Feature

[jira] [Updated] (THRIFT-5364) Remove clippy::vec_box lint override

[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Summary: Remove clippy::vec_box lint override (was: Remove clippy::box_vec lint override) >

[jira] [Updated] (THRIFT-5364) Remove clippy::vec_box lint override

[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Description: Currently the rust code generator wraps types in a {{Box}} in two functions: #

[jira] [Assigned] (THRIFT-4777) Non Blocking Server implementation for Rust

[ https://issues.apache.org/jira/browse/THRIFT-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4777: Assignee: (was: Allen George) > Non Blocking Server implementation for Rust >

[jira] [Assigned] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4098: Assignee: Allen George > Support user-defined output namespaces in generated Rust

[jira] [Assigned] (THRIFT-5360) Remove deprecated description() methods from Error types

[ https://issues.apache.org/jira/browse/THRIFT-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5360: Assignee: Allen George > Remove deprecated description() methods from Error types >

[jira] [Assigned] (THRIFT-5363) All-caps constant rendered incorrectly

[ https://issues.apache.org/jira/browse/THRIFT-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5363: Assignee: Allen George > All-caps constant rendered incorrectly >

[jira] [Updated] (THRIFT-5054) Support THeader in Rust

[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5054: - Priority: Minor (was: Trivial) > Support THeader in Rust > --- > >

[jira] [Updated] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4098: - Priority: Major (was: Minor) > Support user-defined output namespaces in generated Rust

[jira] [Updated] (THRIFT-5364) Remove clippy::box_vec lint override

[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5364: - Priority: Minor (was: Major) > Remove clippy::box_vec lint override >

[jira] [Resolved] (THRIFT-5339) [Rust] Add `TObject` trait to cover sync read & write methods of Struct/Union/Enum

[ https://issues.apache.org/jira/browse/THRIFT-5339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5339. -- Resolution: Duplicate Relevant, but duplicates THRIFT-4100. > [Rust] Add `TObject` trait to

[jira] [Commented] (THRIFT-5364) Remove clippy::box_vec lint override

[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296551#comment-17296551 ] Allen George commented on THRIFT-5364: -- Also something to note: {{is_typedef}} and

[jira] [Commented] (THRIFT-5364) Remove clippy::box_vec lint override

[ https://issues.apache.org/jira/browse/THRIFT-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17296550#comment-17296550 ] Allen George commented on THRIFT-5364: -- I _think_ the best option here is to know what context the

[jira] [Created] (THRIFT-5364) Remove clippy::box_vec lint override

Allen George created THRIFT-5364: Summary: Remove clippy::box_vec lint override Key: THRIFT-5364 URL: https://issues.apache.org/jira/browse/THRIFT-5364 Project: Thrift Issue Type:

[jira] [Reopened] (THRIFT-5054) Support THeader in Rust

[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reopened THRIFT-5054: -- > Support THeader in Rust > --- > > Key: THRIFT-5054 >

[jira] [Commented] (THRIFT-5054) Support THeader in Rust

[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293804#comment-17293804 ] Allen George commented on THRIFT-5054: -- OK. Reopening. > Support THeader in Rust >

[jira] [Resolved] (THRIFT-5054) Support THeader in Rust

[ https://issues.apache.org/jira/browse/THRIFT-5054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5054. -- Resolution: Won't Fix Since this is Facebook-only, deciding not to support this. > Support

[jira] [Created] (THRIFT-5363) All-caps constant rendered incorrectly

Allen George created THRIFT-5363: Summary: All-caps constant rendered incorrectly Key: THRIFT-5363 URL: https://issues.apache.org/jira/browse/THRIFT-5363 Project: Thrift Issue Type: Bug

[jira] [Resolved] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5314. -- Fix Version/s: 0.15.0 Resolution: Fixed Done in

[jira] [Resolved] (THRIFT-4101) Make auto-generated Rust enums and unions more user-extensible

[ https://issues.apache.org/jira/browse/THRIFT-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4101. -- Fix Version/s: 0.15.0 Resolution: Fixed Done in

[jira] [Commented] (THRIFT-5283) Ability to listen over unix socket in thrift Rust crate

[ https://issues.apache.org/jira/browse/THRIFT-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292887#comment-17292887 ] Allen George commented on THRIFT-5283: -- [~prateeknischal] Is adding this functionality still

[jira] [Resolved] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4451. -- Resolution: Fixed > Rust cross test client fails to communicate with multiplexed servers >

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: rs_client_tests_post_change.txt > Rust cross test client fails to communicate with

[jira] [Commented] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292421#comment-17292421 ] Allen George commented on THRIFT-4451: -- Made change to share the underlying {{TCPStream}} between

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: rs_server_tests_post_change.txt > Rust cross test client fails to communicate with

[jira] [Commented] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292204#comment-17292204 ] Allen George commented on THRIFT-4451: -- I made some time recently to work on the Rust Thrift

[jira] [Updated] (THRIFT-4451) Rust cross test client fails to communicate with multiplexed servers

[ https://issues.apache.org/jira/browse/THRIFT-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4451: - Attachment: Screen Shot 2021-02-27 at 13.31.21.png > Rust cross test client fails to

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288781#comment-17288781 ] Allen George edited comment on THRIFT-5314 at 2/23/21, 1:56 AM: I've

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17288781#comment-17288781 ] Allen George commented on THRIFT-5314: -- I've taken a crack at this here:

[jira] [Created] (THRIFT-5361) Investigate alternatives to const map/set/list creation

Allen George created THRIFT-5361: Summary: Investigate alternatives to const map/set/list creation Key: THRIFT-5361 URL: https://issues.apache.org/jira/browse/THRIFT-5361 Project: Thrift

[jira] [Created] (THRIFT-5360) Remove deprecated description() methods from Error types

Allen George created THRIFT-5360: Summary: Remove deprecated description() methods from Error types Key: THRIFT-5360 URL: https://issues.apache.org/jira/browse/THRIFT-5360 Project: Thrift

[jira] [Updated] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5314: - Affects Version/s: 0.14.0 > Enum forward compatibility > -- > >

[jira] [Assigned] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5314: Assignee: Allen George > Enum forward compatibility > -- > >

[jira] [Assigned] (THRIFT-4101) Make auto-generated Rust enums and unions more user-extensible

[ https://issues.apache.org/jira/browse/THRIFT-4101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4101: Assignee: Allen George > Make auto-generated Rust enums and unions more user-extensible

[jira] [Resolved] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5299. -- Fix Version/s: 0.14.1 Resolution: Fixed Fixed in

[jira] [Assigned] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-5299: Assignee: Allen George > rs implementation compact protocol seq_id should not use zigzag

[jira] [Closed] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George closed THRIFT-5300. Resolution: Invalid Not an issue in the Rust implementation as per the conversation. > rs

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235906#comment-17235906 ] Allen George commented on THRIFT-5299: -- Note: The reason why signed ints are used everywhere for

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235560#comment-17235560 ] Allen George edited comment on THRIFT-5314 at 11/19/20, 4:02 PM: - I

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235560#comment-17235560 ] Allen George commented on THRIFT-5314: -- I don't think that's necessary. You could have the same

[jira] [Comment Edited] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235545#comment-17235545 ] Allen George edited comment on THRIFT-5299 at 11/19/20, 3:24 PM: - II was

[jira] [Comment Edited] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235545#comment-17235545 ] Allen George edited comment on THRIFT-5299 at 11/19/20, 3:23 PM: - II was

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235545#comment-17235545 ] Allen George commented on THRIFT-5299: -- II was curious about why this didn't break all the cross

[jira] [Commented] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235519#comment-17235519 ] Allen George commented on THRIFT-4098: -- Copying comment from THRIFT-5071: One can't place thrift

[jira] [Comment Edited] (THRIFT-4098) Support user-defined output namespaces in generated Rust modules

[ https://issues.apache.org/jira/browse/THRIFT-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235519#comment-17235519 ] Allen George edited comment on THRIFT-4098 at 11/19/20, 2:39 PM: -

[jira] [Resolved] (THRIFT-5071) Rust: rust tutorial can not be compiled with rust edition 2018

[ https://issues.apache.org/jira/browse/THRIFT-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5071. -- Fix Version/s: 0.14.0 Resolution: Fixed > Rust: rust tutorial can not be compiled with

[jira] [Commented] (THRIFT-5071) Rust: rust tutorial can not be compiled with rust edition 2018

[ https://issues.apache.org/jira/browse/THRIFT-5071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235517#comment-17235517 ] Allen George commented on THRIFT-5071: -- (1) was completed this year via

[jira] [Updated] (THRIFT-5306) Rust library, tutorial, test, cross-test code should not throw any clippy errors

[ https://issues.apache.org/jira/browse/THRIFT-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5306: - Fix Version/s: 0.14.0 > Rust library, tutorial, test, cross-test code should not throw any

[jira] [Resolved] (THRIFT-5306) Rust library, tutorial, test, cross-test code should not throw any clippy errors

[ https://issues.apache.org/jira/browse/THRIFT-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5306. -- Resolution: Fixed As of linked PR. > Rust library, tutorial, test, cross-test code should

[jira] [Comment Edited] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235158#comment-17235158 ] Allen George edited comment on THRIFT-5314 at 11/19/20, 3:55 AM: - What

[jira] [Commented] (THRIFT-5314) Enum forward compatibility

[ https://issues.apache.org/jira/browse/THRIFT-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235158#comment-17235158 ] Allen George commented on THRIFT-5314: -- What should the right behavior be? If the receiver gets a

[jira] [Comment Edited] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes

[ https://issues.apache.org/jira/browse/THRIFT-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235155#comment-17235155 ] Allen George edited comment on THRIFT-4764 at 11/19/20, 3:47 AM: -

[jira] [Resolved] (THRIFT-5307) Rust generated code should compile cleanly with clippy

[ https://issues.apache.org/jira/browse/THRIFT-5307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5307. -- Fix Version/s: 0.14.0 Resolution: Fixed Completed as of

[jira] [Resolved] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes

[ https://issues.apache.org/jira/browse/THRIFT-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-4764. -- Fix Version/s: 0.14.0 Resolution: Fixed Completed as of

[jira] [Issue Comment Deleted] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes

[ https://issues.apache.org/jira/browse/THRIFT-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-4764: - Comment: was deleted (was: This has been completed as of

[jira] [Assigned] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes

[ https://issues.apache.org/jira/browse/THRIFT-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George reassigned THRIFT-4764: Assignee: Allen George > Rust frontend emits deprecated clippy suppression attributes >

[jira] [Commented] (THRIFT-4764) Rust frontend emits deprecated clippy suppression attributes

[ https://issues.apache.org/jira/browse/THRIFT-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17235154#comment-17235154 ] Allen George commented on THRIFT-4764: -- This has been completed as of

[jira] [Created] (THRIFT-5307) Rust generated code should compile cleanly with clippy

Allen George created THRIFT-5307: Summary: Rust generated code should compile cleanly with clippy Key: THRIFT-5307 URL: https://issues.apache.org/jira/browse/THRIFT-5307 Project: Thrift

[jira] [Created] (THRIFT-5306) Rust library, tutorial, test, cross-test code should not throw any clippy errors

Allen George created THRIFT-5306: Summary: Rust library, tutorial, test, cross-test code should not throw any clippy errors Key: THRIFT-5306 URL: https://issues.apache.org/jira/browse/THRIFT-5306

[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225130#comment-17225130 ] Allen George edited comment on THRIFT-5300 at 11/3/20, 5:00 AM:

[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225130#comment-17225130 ] Allen George edited comment on THRIFT-5300 at 11/3/20, 5:00 AM:

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225130#comment-17225130 ] Allen George commented on THRIFT-5300: -- [~shuoli84] This is what I get for trying to squeeze in

[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224972#comment-17224972 ] Allen George edited comment on THRIFT-5300 at 11/2/20, 9:37 PM:

[jira] [Commented] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224972#comment-17224972 ] Allen George commented on THRIFT-5300: -- [~shuoli84][~ulidtko] I just checked the spec again (it's

[jira] [Comment Edited] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224972#comment-17224972 ] Allen George edited comment on THRIFT-5300 at 11/2/20, 9:36 PM:

[jira] [Updated] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5300: - Attachment: Screen Shot 2020-11-02 at 16.31.31.png > rs compact protocol collection elem type

[jira] [Updated] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George updated THRIFT-5300: - Attachment: Screen Shot 2020-11-02 at 16.31.09.png > rs compact protocol collection elem type

[jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.

[ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223685#comment-17223685 ] Allen George commented on THRIFT-5299: -- [~shuoli84] I'm sorry - I'm a little confused by what's

[jira] [Resolved] (THRIFT-5300) rs compact protocol collection elem type to ttype mapping wrong

[ https://issues.apache.org/jira/browse/THRIFT-5300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen George resolved THRIFT-5300. -- Assignee: Allen George Resolution: Invalid Closing out because this is not a bug in the

  1   2   3   >