[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2012-01-23 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191848#comment-13191848 ] Andrew Grumet commented on THRIFT-1478: --- OK. I've patched a clean checkout and run

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2012-01-23 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190954#comment-13190954 ] Andrew Grumet commented on THRIFT-1478: --- Notes on the php unit tests: 1. The tests

[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite

2012-01-21 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190509#comment-13190509 ] Andrew Grumet commented on THRIFT-1484: --- Thanks, got it. So we can move on both fr

[jira] [Commented] (THRIFT-1484) Introduce phpunit test suite

2012-01-20 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189684#comment-13189684 ] Andrew Grumet commented on THRIFT-1484: --- Found and patched some very basic test cod

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2012-01-20 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189682#comment-13189682 ] Andrew Grumet commented on THRIFT-1478: --- Working my way up the learning curve. Sub

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2012-01-03 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179308#comment-13179308 ] Andrew Grumet commented on THRIFT-1478: --- Still seeing i64 errors on my 32bit machin

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2011-12-31 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178070#comment-13178070 ] Andrew Grumet commented on THRIFT-1478: --- Here's a better link to the test steps ht

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2011-12-31 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178069#comment-13178069 ] Andrew Grumet commented on THRIFT-1478: --- Yep! I'm a bit of a n00b to this stuff to

[jira] [Commented] (THRIFT-1478) TJSONProtocol in PHP

2011-12-31 Thread Andrew Grumet (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178053#comment-13178053 ] Andrew Grumet commented on THRIFT-1478: --- You may need the patch in THRIFT-1479. Co