[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13976207#comment-13976207 ] Ben Sigelman commented on THRIFT-2429: -- Per my thoughts above, I'm in favor of

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13970134#comment-13970134 ] Ben Sigelman commented on THRIFT-2429: -- [~apesternikov], that would be utterly fine

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967540#comment-13967540 ] Ben Sigelman commented on THRIFT-2429: -- Hi Randy, Thanks for the detailed

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967689#comment-13967689 ] Ben Sigelman commented on THRIFT-2429: -- Thanks for the detailed explanation once

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13966737#comment-13966737 ] Ben Sigelman commented on THRIFT-2429: -- Thanks, Randy. I did a little bit of

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13967178#comment-13967178 ] Ben Sigelman commented on THRIFT-2429: -- Thanks for clarifying, Jens. Sounds like PB

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965590#comment-13965590 ] Ben Sigelman commented on THRIFT-2429: -- As I mentioned earlier, required fields are

[jira] [Commented] (THRIFT-2451) Do not use pointers for optional fields with defaults. Do not write such fields if its value set to default. Also, do not use pointers for any optional fields mapped t

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965668#comment-13965668 ] Ben Sigelman commented on THRIFT-2451: -- I really do appreciate the effort you're

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961980#comment-13961980 ] Ben Sigelman commented on THRIFT-2232: -- Hi [~apesternikov], A few responses: -

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13961990#comment-13961990 ] Ben Sigelman commented on THRIFT-2451: -- A few responses. - It's not clear to me

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962366#comment-13962366 ] Ben Sigelman commented on THRIFT-2451: -- I added the pointers to slices/maps partly

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962376#comment-13962376 ] Ben Sigelman commented on THRIFT-2451: -- I'm not on the thrift team and will thus

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962386#comment-13962386 ] Ben Sigelman commented on THRIFT-2451: -- You and I have divergent opinions about the

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962396#comment-13962396 ] Ben Sigelman commented on THRIFT-2429: -- FYI, I am neither an official thrift

[jira] [Commented] (THRIFT-2451) Go generated code should not initialize optional fields. Instead, Get accessors should be generated

[ https://issues.apache.org/jira/browse/THRIFT-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962399#comment-13962399 ] Ben Sigelman commented on THRIFT-2451: -- My point was that some people use a nil

[jira] [Commented] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962575#comment-13962575 ] Ben Sigelman commented on THRIFT-2429: -- Using default values as a convenience is one

[jira] [Comment Edited] (THRIFT-2429) Provide option to not write default values, rely on receiver default construction instead

[ https://issues.apache.org/jira/browse/THRIFT-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13962575#comment-13962575 ] Ben Sigelman edited comment on THRIFT-2429 at 4/8/14 4:53 AM:

[jira] [Commented] (THRIFT-2343) Golang - Return a single error for all exceptions instead of multiple return values

[ https://issues.apache.org/jira/browse/THRIFT-2343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890042#comment-13890042 ] Ben Sigelman commented on THRIFT-2343: -- Seems like a good idea to me! My teammate

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13850909#comment-13850909 ] Ben Sigelman commented on THRIFT-2232: -- Thanks very much for your help! IsSet*

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848083#comment-13848083 ] Ben Sigelman commented on THRIFT-2232: -- Per

[jira] [Updated] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Sigelman updated THRIFT-2232: - Attachment: thrift-2232-golang-optional-fields-fix.patch after rebasing to the upstream master,

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804664#comment-13804664 ] Ben Sigelman commented on THRIFT-2232: -- Thanks for the remedial help re: thrift

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803549#comment-13803549 ] Ben Sigelman commented on THRIFT-2232: -- Hi Jens, Thanks for getting back to me. I

[jira] [Commented] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801855#comment-13801855 ] Ben Sigelman commented on THRIFT-2232: -- Hi [~jensg], thanks for the quick response!

[jira] [Comment Edited] (THRIFT-2232) IsSet* broken in Go

[ https://issues.apache.org/jira/browse/THRIFT-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801855#comment-13801855 ] Ben Sigelman edited comment on THRIFT-2232 at 10/22/13 4:29 PM:

[jira] [Created] (THRIFT-2232) IsSet* broken in Go

Ben Sigelman created THRIFT-2232: Summary: IsSet* broken in Go Key: THRIFT-2232 URL: https://issues.apache.org/jira/browse/THRIFT-2232 Project: Thrift Issue Type: Bug Components: