Github user ChristopherRogers commented on the issue:
https://github.com/apache/thrift/pull/1084
I have not. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user ChristopherRogers commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r80357625
--- Diff: lib/swift/Sources/TMultiplexedProtocol.swift ---
@@ -0,0 +1,47 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under
Github user ChristopherRogers commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r80357489
--- Diff: lib/swift/Sources/TProtocol.swift ---
@@ -0,0 +1,182 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
Github user ChristopherRogers commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r80355496
--- Diff: compiler/cpp/src/generate/t_swift_3_generator.cc ---
@@ -0,0 +1,2458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ChristopherRogers commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r80357106
--- Diff: compiler/cpp/src/generate/t_swift_3_generator.cc ---
@@ -0,0 +1,2458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ChristopherRogers commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r80355989
--- Diff: compiler/cpp/src/generate/t_swift_3_generator.cc ---
@@ -0,0 +1,2458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ChristopherRogers commented on the issue:
https://github.com/apache/thrift/pull/1084
I noticed you haven't special cased unions (they'll just be generated as
structs.) Have you looked into adding support for this? I'd love to be able to
use Swift's
Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172575020
Also, I just remembered from an old version of Xcode that even the @[]/@{}
syntax used autorelease (probably to easily codegen in both ARC and MRC) but
that
Github user ChristopherRogers commented on the pull request:
https://github.com/apache/thrift/pull/790#issuecomment-172571012
Ah, my apologies for the extra semicolons. It was missing semicolons in the
default init methods where a collection type had a default value.
I
GitHub user ChristopherRogers opened a pull request:
https://github.com/apache/thrift/pull/790
THRIFT-3545 Cocoa: Container type literals do not compile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChristopherRogers/thrift
10 matches
Mail list logo
