[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-29 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106201#comment-16106201 ] Davin Chia commented on THRIFT-4253: [~jensg] Made the whitespace changes. Will b

[jira] [Resolved] (THRIFT-4254) Go generator does not respect typedef types when generating read/write functions.

2017-07-21 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davin Chia resolved THRIFT-4254. Resolution: Fixed > Go generator does not respect typedef types when generating read/write > funct

[jira] [Commented] (THRIFT-4254) Go generator does not respect typedef types when generating read/write functions.

2017-07-21 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095887#comment-16095887 ] Davin Chia commented on THRIFT-4254: Seems to be solved in current version. Closing f

[jira] [Resolved] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-20 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davin Chia resolved THRIFT-4255. Resolution: Fixed > Go generator has type errors when in read/write functions for set > ---

[jira] [Commented] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-20 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095485#comment-16095485 ] Davin Chia commented on THRIFT-4255: Seems this has been fixed in https://issues.apa

[jira] [Created] (THRIFT-4255) Go generator has type errors when in read/write functions for set

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4255: -- Summary: Go generator has type errors when in read/write functions for set Key: THRIFT-4255 URL: https://issues.apache.org/jira/browse/THRIFT-4255 Project: Thrift

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:44 AM: -

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:15 AM: -

[jira] [Comment Edited] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia edited comment on THRIFT-4253 at 7/18/17 3:13 AM: -

[jira] [Created] (THRIFT-4254) Go generator does not respect typedef types when generating read/write functions.

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4254: -- Summary: Go generator does not respect typedef types when generating read/write functions. Key: THRIFT-4254 URL: https://issues.apache.org/jira/browse/THRIFT-4254 Project

[jira] [Commented] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090895#comment-16090895 ] Davin Chia commented on THRIFT-4253: Thanks for the quick reply [~jensg]. This is the

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090880#comment-16090880 ] Davin Chia commented on THRIFT-2063: Ah sorry for the noise. I am definitely going to

[jira] [Comment Edited] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia edited comment on THRIFT-2063 at 7/17/17 8:57 PM: -

[jira] [Created] (THRIFT-4253) Go generator assigns strings to field in const instead of pointers.

2017-07-17 Thread Davin Chia (JIRA)
Davin Chia created THRIFT-4253: -- Summary: Go generator assigns strings to field in const instead of pointers. Key: THRIFT-4253 URL: https://issues.apache.org/jira/browse/THRIFT-4253 Project: Thrift

[jira] [Comment Edited] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-17 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia edited comment on THRIFT-2063 at 7/17/17 8:00 PM: -

[jira] [Commented] (THRIFT-2063) Go compiler cannot create code for maps with complex/binary keys

2017-07-14 Thread Davin Chia (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087783#comment-16087783 ] Davin Chia commented on THRIFT-2063: Bumping this. I know this is an old issue, but I