Github user GZShi commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1153#discussion_r95948613
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
ownEventBase_
GitHub user GZShi opened a pull request:
https://github.com/apache/thrift/pull/1153
fix a bug in windows
The `SOCKET` type is defined as a unsigned number in windows, the
`evutil_socket_t` variables are always large than zero, therefore the condition
not work well here.
You can