[
https://issues.apache.org/jira/browse/THRIFT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov reassigned THRIFT-369:
--
Assignee: Ilya Maykov
> sets and maps break equality
>
>
>
[
https://issues.apache.org/jira/browse/THRIFT-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1252:
Attachment: THRIFT-1252.patch
Attaching patch file.
> Segfault in Ruby deserializer
> ---
Segfault in Ruby deserializer
-
Key: THRIFT-1252
URL: https://issues.apache.org/jira/browse/THRIFT-1252
Project: Thrift
Issue Type: Bug
Components: Ruby - Library
Affects Versions: 0.7
Envir
[
https://issues.apache.org/jira/browse/THRIFT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov resolved THRIFT-418.
Resolution: Fixed
Resolving.
> Don't do runtime sorting of struct fields
> ---
[
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049468#comment-13049468
]
Ilya Maykov commented on THRIFT-1204:
-
Fair enough, I buy the argument that rubygems
[
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049339#comment-13049339
]
Ilya Maykov commented on THRIFT-1204:
-
Michael - thrift is packaged as a gem, so tryi
[
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1204:
Attachment: THRIFT-1204-require-thrift-in-gen-rb-files.patch
Updated patch that adds the requires
[
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1204:
Attachment: (was: THRIFT-1204-require-thrift-in-gen-rb-files.patch)
> Ruby autogenerated files
[
https://issues.apache.org/jira/browse/THRIFT-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1204:
Attachment: THRIFT-1204-require-thrift-in-gen-rb-files.patch
Attaching patch. This will add the fo
Ruby autogenerated files should require 'thrift' gem
Key: THRIFT-1204
URL: https://issues.apache.org/jira/browse/THRIFT-1204
Project: Thrift
Issue Type: Improvement
Components: R
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: THRIFT-1189_ruby_performance_improvements.txt)
> Ruby deserializer speed imp
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: THRIFT-1189_ruby_performance_improvements.txt
New patch which makes a couple minor imp
[
https://issues.apache.org/jira/browse/THRIFT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-418:
---
Attachment: THRIFT-418-avoid-runtime-sorting-of-struct-fields-2.patch
New patch which reverts the pre
[
https://issues.apache.org/jira/browse/THRIFT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov reopened THRIFT-418:
Reopening as I've thought about it and a patch which doesn't change the
compiler or generated code end
[
https://issues.apache.org/jira/browse/THRIFT-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047028#comment-13047028
]
Ilya Maykov commented on THRIFT-1203:
-
Shouldn't we open a related ticket to make the
[
https://issues.apache.org/jira/browse/THRIFT-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046915#comment-13046915
]
Ilya Maykov commented on THRIFT-639:
I guess what I'm saying is, I don't think this is
[
https://issues.apache.org/jira/browse/THRIFT-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046914#comment-13046914
]
Ilya Maykov commented on THRIFT-639:
I think you're supposed to throw away your connec
[
https://issues.apache.org/jira/browse/THRIFT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046846#comment-13046846
]
Ilya Maykov commented on THRIFT-369:
I just tested this against thrift 0.6.0 and equal
[
https://issues.apache.org/jira/browse/THRIFT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-418:
---
Patch Info: [Patch Available]
> Don't do runtime sorting of struct fields
> -
[
https://issues.apache.org/jira/browse/THRIFT-418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-418:
---
Attachment: THRIFT-418-avoid-runtime-sorting-of-struct-fields.patch
Attaching patch. There are 2 chan
[
https://issues.apache.org/jira/browse/THRIFT-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046276#comment-13046276
]
Ilya Maykov commented on THRIFT-1200:
-
As far as I know, the "var" keyword is not nec
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046253#comment-13046253
]
Ilya Maykov edited comment on THRIFT-1047 at 6/8/11 10:03 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046253#comment-13046253
]
Ilya Maykov commented on THRIFT-1047:
-
Jake - can you also add the type check to the
[
https://issues.apache.org/jira/browse/THRIFT-1200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1200:
Attachment: THRIFT-1200-js-namespace-fix.txt
Attaching patch against trunk as of 2011-06-08 (rev 1
JS compiler generates code that clobbers existing namespaces
Key: THRIFT-1200
URL: https://issues.apache.org/jira/browse/THRIFT-1200
Project: Thrift
Issue Type: Bug
Compo
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: THRIFT-1189_ruby_performance_improvements.txt
Attaching new patch with XTransport#read
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: patch-THRIFT-1189-2.txt)
> Ruby deserializer speed improvements
> --
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: patch-THRIFT-1189-combined.txt)
> Ruby deserializer speed improvements
> ---
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: patch-THRIFT-1189-3.txt)
> Ruby deserializer speed improvements
> --
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: patch-THRIFT-1189.txt)
> Ruby deserializer speed improvements
>
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045115#comment-13045115
]
Ilya Maykov commented on THRIFT-1189:
-
Per IRC discussion with Bryan Duxbury, I'm goi
[
https://issues.apache.org/jira/browse/THRIFT-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1193:
Attachment: patch-THRIFT-1193.txt
Patch attached.
> Potential infinite loop in nonblocking_server
Potential infinite loop in nonblocking_server
-
Key: THRIFT-1193
URL: https://issues.apache.org/jira/browse/THRIFT-1193
Project: Thrift
Issue Type: Bug
Components: Ruby - Library
Affe
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041854#comment-13041854
]
Ilya Maykov commented on THRIFT-1183:
-
P.S. The pure-ruby BinaryProtocol already has
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041853#comment-13041853
]
Ilya Maykov commented on THRIFT-1183:
-
I haven't tested it in 1.8.6 but it should wor
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: patch-THRIFT-1189-combined.txt
Single combined patch, and this time against the SVN re
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041494#comment-13041494
]
Ilya Maykov commented on THRIFT-1183:
-
This breaks CompactProtocol completely in JRub
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Description:
I have a patch to the Ruby libraries that greatly increases deserializer speed.
We'v
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: patch-THRIFT-1189-3.txt
One more patch. This one speeds up BinaryProtocolAccelerated#r
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: patch-THRIFT-1189-2.txt
Attaching a second patch that takes care of a couple more low-
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: thrift_perf_test.tar.gz
> Ruby deserializer speed improvements
> -
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: thrift_perf_test.tar.gz)
> Ruby deserializer speed improvements
> --
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Description:
I have a patch to the Ruby libraries that greatly increases deserializer speed.
We'v
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: thrift_perf_test.tar.gz
Added benchmark for equality test to perf test.
> Ruby deseri
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Description:
I have a patch to the Ruby libraries that greatly increases deserializer speed.
We'v
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Description:
I have a patch to the Ruby libraries that greatly increases deserializer speed.
We'v
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: (was: thrift_perf_test.tar.gz)
> Ruby deserializer speed improvements
> --
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041421#comment-13041421
]
Ilya Maykov commented on THRIFT-1187:
-
To repro the original bug:
1) rvm use 1.9.2 (a
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1187:
Summary: nonblocking_server shutdown race under Ruby 1.9 (was:
nonblocking_server shutdown race u
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Attachment: patch-THRIFT-1182-2.txt
The original patch didn't call read_(list|map|set)_end if the
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041419#comment-13041419
]
Ilya Maykov edited comment on THRIFT-1182 at 5/31/11 4:56 AM:
-
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1187:
Attachment: patch-THRIFT-1187.txt
Uploading again, fixed commend.
> nonblocking_server shutdown r
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1187:
Attachment: (was: patch-THRIFT-1187.txt)
> nonblocking_server shutdown race under in Ruby 1.9
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: patch-THRIFT-1189.txt
Attaching patch with perf improvements.
> Ruby deserializer spe
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Attachment: thrift_perf_test.tar.gz
Simple tool to benchmark deserialization and hashing performan
[
https://issues.apache.org/jira/browse/THRIFT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1189:
Description:
I have a patch to the Ruby libraries that greatly increases deserializer speed.
We'v
Ruby deserializer speed improvements
Key: THRIFT-1189
URL: https://issues.apache.org/jira/browse/THRIFT-1189
Project: Thrift
Issue Type: Improvement
Components: Ruby - Library
Affects Versio
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1187:
Attachment: patch-THRIFT-1187.txt
Patch attached. Paths are funky again because it's against my ow
[
https://issues.apache.org/jira/browse/THRIFT-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1187:
Description:
While testing some changes today I noticed that nonblocking_server tests pass
for me
nonblocking_server shutdown race under in Ruby 1.9
--
Key: THRIFT-1187
URL: https://issues.apache.org/jira/browse/THRIFT-1187
Project: Thrift
Issue Type: Bug
Components: Ruby - Librar
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1183:
Remaining Estimate: (was: 1h)
Original Estimate: (was: 1h)
> Pure-ruby CompactProtoco
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Attachment: patch-THRIFT-1182.txt
Wrong file attached last time, here goes try 2.
> Native deseri
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040764#comment-13040764
]
Ilya Maykov commented on THRIFT-1182:
-
Sorry the patch is against a copy of the sourc
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Attachment: (was: patch-THRIFT-1182.txt)
> Native deserializer segfaults on incorrect list ele
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Patch Info: [Patch Available]
> Native deserializer segfaults on incorrect list element type
> ---
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Attachment: patch-THRIFT-1182.txt
Attaching patch.
With this patch, the deserializer will skip an
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040760#comment-13040760
]
Ilya Maykov commented on THRIFT-1183:
-
Sorry the patch is against a copy of the sourc
[
https://issues.apache.org/jira/browse/THRIFT-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1183:
Attachment: patch-THRIFT-1183.txt
Patch attached.
> Pure-ruby CompactProtocol raises ArgumentErro
Pure-ruby CompactProtocol raises ArgumentError when deserializing under Ruby 1.9
Key: THRIFT-1183
URL: https://issues.apache.org/jira/browse/THRIFT-1183
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040743#comment-13040743
]
Ilya Maykov commented on THRIFT-1182:
-
Per IRC chat with Bryan Duxbury, the deseriali
[
https://issues.apache.org/jira/browse/THRIFT-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilya Maykov updated THRIFT-1182:
Attachment: thrift_crash.rb
Attached simple repro. Run with thrift 0.6.0 gem, tested on ruby 1.8.7
Native deserializer segfaults on incorrect list element type
Key: THRIFT-1182
URL: https://issues.apache.org/jira/browse/THRIFT-1182
Project: Thrift
Issue Type: Bug
Compo
72 matches
Mail list logo