GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1530
THRIFT-4540 buffered transport broken when trying to re-open a formerâ¦
â¦ly closed transport
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1529
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1529
THRIFT-4539 Allow TBufferedTransport to be used as base class
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1528
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1528
Thrift 4538
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4538
Alternatively you can review and apply these changes as
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1524
Squash please.
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1524
Disclaimer: I did not look at every line and I did not look into the
AppVeyor failure.
Aside from one minor thing everything that I skimmed through LTGM, and my
code still compiles :-) so
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1524#discussion_r178426941
--- Diff: lib/csharp/src/Protocol/TCompactProtocol.cs ---
@@ -7,7 +7,7 @@
* "License"); you may not use this file except in compliance
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1527
@jfarrell: could you close that?
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1527
@zengqinglong: could you please stop opening meaningless PRs? Thank you.
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1493
THRIFT-4492 protected ExceptionType type member of TApplicationExceptâ¦
â¦ion cannot be accessed
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1492
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1492
THRIFT-4492 protected ExceptionType type member of TApplicationExceptâ¦
â¦ion cannot be accessed
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1490
THRIFT-4454 Large writes/reads may cause range check errors in debug â¦
â¦mode
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1489
THRIFT-4485 Possible invalid ptr AV with overlapped read/write on pipes
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1474
Not sure.
We had that discussion in the past IIRC and the outcome was that we leave
it as it is. It's somewhere buried in the archives, maybe we heven had (or
still have) a ticket f
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1478
THRIFT-4473 Move Thrift.Console.pas out of the Library
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1474
I see the point but I'm not sure if Inunderstzand it right. Who doies what
before we add new codes? We ask FB? Or they ask us? And what ist your plan to
convince FB that they have to ask us?
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1467
THRIFT-4455 Missing dispose calls in ThreadedServer & ThreadpoolServer
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull h
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1466
THRIFT-4454 Large writes/reads may cause range check errors in debug â¦
â¦mode
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1461
Hi John,
Questions:
* Why are they deprecated? I probably only overlook sth, so bear with me
* Do we have a JIRA Ticket for this? If not, could you create one?
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1444
Travis errors seem unrelated. Go library? C++ library? I didn't even touch
those ...
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1440
Plus chinese comments should be english.
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1444
THRIFT-4422 Add Async implementation via IFuture
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1432
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1433
> , unless we ONLY use the plug-in method
I personally don't think that is a good idea. I just went through that pain
with grpc a while ago and I remember it as being utterly compli
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1436
THRIFT-4400 Visual Studio Compiler project should link runtime staticâ¦
â¦ally in release builds
Client: Compiler (general)
Patch: Jens Geyer
You can merge this pull request into a
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1430
Hi @slandelle,
thank you for the patch!
[If you could also create a ticket for it as
well](https://thrift.apache.org/docs/committers/HowToRelease), that would be
awesome.
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1432
0.11.0 rc1
Versioning for 0.11.0 release candidate
**Caution: Do NOT merge this to master.**
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1431#discussion_r154285598
--- Diff: test/haxe/Makefile.am ---
@@ -96,7 +96,9 @@ EXTRA_DIST = \
neko.hxml \
php.hxml \
python.hxml
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1431
THRIFT-4398 Update EXTRA_DIST for "make dist"
Client: Build process
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1422
THRIFT-4396 inconsistent (or plain wrong) version numbers in master/tâ¦
â¦runk
Client: (multiple)
Patch: Jens Geyer
You can merge this pull request into a Git repository by running
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1413
@jfarrell, could you please close this?
---
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149504639
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1410
@jfarrell: What's your opinion re the (c) things above?
---
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1410#discussion_r149475953
--- Diff: lib/cl/framed-transport.lisp ---
@@ -0,0 +1,136 @@
+(in-package #:org.apache.thrift.implementation)
+
+ Copyright 2017 Rigetti
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1402
> Why not actually use (2^16)-1 which is the limit?
Several reasons. First, aligned memory access is always faster. If we
subtract 1 byte, we get the worst case. Next, at least on Window
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1402
THRIFT-4372 Pipe write operations across a network are limited to 65,â¦
â¦535 bytes per write
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/782
This will not generate nodejs code, to name just one case.
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1370
Yeah, test. I got only 2 mails this time. Your comment generated 3 mails. I
had cases where I got up to 7 mails for one github comment.
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1370
Test
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1355
Jake does that.
---
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1355
I'm fine with combining both flavours into one single c# library etc, as
long as you don't break the c# library. The netcore lib is quite new and
there's a lot of movement so we sure
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1355
What is THRIFTCORE? Is this intended tom become another netcore library?
What about the existing one? Please explain.
---
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1348
THRIFT-4318 Delphi performance improvements
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1338
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1339
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1323
No idea what you think you can achieve with that. Please close this PR, as
it will never get merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1311
Ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1316
Anyone amongst the fluently Erlang speaking people who wants to review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1309
go version go1.8.3 windows/amd64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1311#discussion_r128901829
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -424,6 +424,52 @@ bool t_go_generator::is_pointer_field(t_field* tfield,
bool
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1309
> I'll also be sending a PR to update the Go tutorial with the new handler
signature.
Please do. Right now the tutorial does not build.
```
handler.go:30:2: cannot find
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1304#discussion_r126221534
--- Diff: lib/go/thrift/server_socket.go ---
@@ -68,15 +68,18 @@ func (p *TServerSocket) Listen() error {
func (p *TServerSocket) Accept
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125749743
--- Diff: lib/py/src/TRecursive.py ---
@@ -0,0 +1,63 @@
+# MODIFIED June 20, 2017, Eric Conner
+#
+#
+# Original source copyright 2014
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1303
Tracked in THRIFT-4245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1186
@ctubbsii: Could you please have a look at
[THRIFT-4239](https://issues.apache.org/jira/browse/THRIFT-4239)? Not sure if
it has sth. to do with your patch, but it came up while looking for the cause
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1298
I look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1287
If nobody else wants to vote against it, I'll commit this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1297
Something is wrong here. Could you please review your pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1296
Nice, but not 100%. Still two are saying ..
> npm install
> /bin/bash: npm: command not found
>
---
If your project is set up for it, you can reply to this email and
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1292
1) We have a [nice, short & concise contrib
guide](http://thrift.apache.org/docs/HowToContribute) that covers all the
formalities
2) We also have a [test
suite](https://github.com/ap
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1291
THRIFT-4231 TJSONProtocol throws unexpected non-Thrift-exception on nâ¦
â¦ull strings
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1288
Can someone with adequate privileges please close this bull, ehm - PULL
request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1284
Ok, I'll look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wish
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1284
If you could file a JIRA ticket, that would be awesome :-)
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up for it, you can reply to this email and have your
reply
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1283
Anyone from the PHP experts who can confirm this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1282
THRIFT-4217 HttpClient should support gzip and deflate
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1280
THRIFT-4213 Travis build fails at curl -sSL https://www.npmjs.com/insâ¦
â¦tall.sh | sh
Client: Build process
Patch: Jens Geyer
Temporarily removed nodejs from travis builds
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1275
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1275
THRIFT-4209 warning CS0414 in T[TLS]ServerSocket.cs
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1277
THRIFT-4210 include Thrift.45.csproj into CI runs
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1276
THRIFT-4208 C# NamedPipesServer not really working in some scenarios â¦
â¦Client: C# Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1270
THRIFT-4204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1268
The NPM timed out, no other errors. If there are no objections against it,
I'll commit that shortly.
So please speak now (or be quiet forever, as they say) ... :-)
---
If your project i
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1252
Tracked in THRIFT-4198. See [our contrib
guide](http://thrift.apache.org/docs/HowToContribute) for details.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1268
THRIFT-4190 Improve C# TThreadPoolServer defaults (part 2 of 2)
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1266
Don't panic, I already planned to look into this. I have a life
besidesThrift, you know ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1262
THRIFT-4190 Improve C# TThreadPoolServer defaults
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1258
That travis thing seems pretty reliable. The pobkly difference is in the
commit message, yet it fails where it succeeded minutes ago. Compare
https://travis-ci.org/apache/thrift/builds/226143091
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1258
THRIFT-4183 Named pipe client blocks forever on Open() when there is â¦
â¦no server at the other end
Client: C#
Patch: Jens Geyer
You can merge this pull request into a Git
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1045
After I read that the cross tests doesn't need to be made because "it
doesn't work anyway" my enthusiasm for this patch was basically send to zero .
First, this is a plain lie.
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1234
THRIFT-4157
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1234
THRIFT-4157 outdated readme about Haxe installation on Linux
Client: Haxe
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1230
THRIFT-4152
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1223
Yeah, but at least it looks as if we get the compiler ready.
If there are no objections, I am going commit that part today, With UBSAN
still left disabled of course. I only enabled it in
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1223
THRIFT-4137 vptr @ compiler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4137
Alternatively you can review and apply
Github user Jens-G closed the pull request at:
https://github.com/apache/thrift/pull/1222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1222
To be honest, my intention is to fix the actual problem, not to refactor
the whole app.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1222
No, the intention is to patch everything. A few things are still open, but
I will update the PR until we have it all.
---
If your project is set up for it, you can reply to this email and have your
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1222
```
void t_json_generator::write_type_spec(t_type* ttype) {
ttype = ttype->get_true_type();
write_string(get_type_name(ttype));
if (ttype->is_struct() ||
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108063013
--- Diff: build/docker/scripts/ubsan.sh ---
@@ -15,7 +15,7 @@ export CXX=clang++-3.8
# undefined casting, aka "vptr".
#
# TODO: fix
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1222#discussion_r108062987
--- Diff: compiler/cpp/src/thrift/generate/t_xml_generator.cc ---
@@ -391,11 +391,16 @@ void t_xml_generator::write_type(t_type* ttype) {
if (type
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1222
THRIFT-4134-Fix-remaining-undefined-behavior-invalid.patch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4134
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1221
THRIFT-4136
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4136
Alternatively you can review and apply these changes as
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1163
> because .Net Core generator still not included into Thrift.exe.
It's included in trunk, not in 0.10. The release was already at the door so
I didn't want to pollute it
Github user Jens-G commented on the issue:
https://github.com/apache/thrift/pull/1208
The careful reader will notice that it says "asfgit closed this in b79396f
19 hours ago". The b79396f is a link to the commit you are looking for.
---
If your project is set up for i
1 - 100 of 417 matches
Mail list logo
