Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/590#issuecomment-133053214
Thanks @RandyAbernethy!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Paul Magrath created THRIFT-3300:
Summary: Reimplement TZlibTransport in Java using streams
Key: THRIFT-3300
URL: https://issues.apache.org/jira/browse/THRIFT-3300
Project: Thrift
Issue Type
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/590
THRIFT-3300 Reimplement TZlibTransport in Java using streams
https://issues.apache.org/jira/browse/THRIFT-3300
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/THRIFT-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14698324#comment-14698324
]
Paul Magrath commented on THRIFT-3294:
--
Thanks!
TZlibTransport for Java does
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/585#issuecomment-131395965
Closing as this has now been merged by @RandyAbernethy
https://github.com/apache/thrift/commit/bb98e97fd3c82117c87d23e3fb6b8bbd800784f2
(thanks!)
---
If your project
Github user Magrath closed the pull request at:
https://github.com/apache/thrift/pull/585
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Paul Magrath created THRIFT-3294:
Summary: TZlibTransport for Java does not write data correctly
Key: THRIFT-3294
URL: https://issues.apache.org/jira/browse/THRIFT-3294
Project: Thrift
Issue
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/585
THRIFT-3294 Fix buffer overrun in Java implementation of Zlib transport
The TZlibTransport did not check the write buffer length when flushing.
Instead, it assumed that the entire write buffer byte
[
https://issues.apache.org/jira/browse/THRIFT-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Magrath updated THRIFT-3294:
-
Description:
An error similar to the following exception is encountered in the client after
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/580#issuecomment-128965350
Thanks! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/580#issuecomment-128663833
No problem, I've added a new commit that integrates it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/580
THRIFT-3292 Add a Zlib transport for Go
This is a TZlibTransport implementation compatible with the Java version of
TZlibTransport, at least from my (admittedly limited) testing.
https
Paul Magrath created THRIFT-3292:
Summary: Implement TZlibTransport in Go
Key: THRIFT-3292
URL: https://issues.apache.org/jira/browse/THRIFT-3292
Project: Thrift
Issue Type: New Feature
[
https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14567939#comment-14567939
]
Paul Magrath commented on THRIFT-3170:
--
Thank you! :)
Initialism code in the Go
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/508#issuecomment-107221480
@Jens-G I've done the necessary merging, this should be good to go now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/509
THRIFT-3174: Modify initialism code in Go compiler to check first word
https://issues.apache.org/jira/browse/THRIFT-3174
You can merge this pull request into a Git repository by running:
$ git
Paul Magrath created THRIFT-3174:
Summary: Initialism code in the Go compiler doesn't check first
word
Key: THRIFT-3174
URL: https://issues.apache.org/jira/browse/THRIFT-3174
Project: Thrift
[
https://issues.apache.org/jira/browse/THRIFT-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566091#comment-14566091
]
Paul Magrath commented on THRIFT-3174:
--
This was first reported as part of THRIFT
[
https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566088#comment-14566088
]
Paul Magrath commented on THRIFT-3170:
--
Hi Adam
I'll have to disagree with you
[
https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566121#comment-14566121
]
Paul Magrath commented on THRIFT-3170:
--
Hi Adam,
That's good to hear. :)
Regarding
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/509#issuecomment-107100144
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14566024#comment-14566024
]
Paul Magrath commented on THRIFT-3170:
--
Hi Jens,
Yep, I agree, I'll code something
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/508
THRIFT-3170: Add a flag to allow the ignoring of common initialisms in Go
As discussed in https://issues.apache.org/jira/browse/THRIFT-3170
You can merge this pull request into a Git repository
[
https://issues.apache.org/jira/browse/THRIFT-3170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557722#comment-14557722
]
Paul Magrath commented on THRIFT-3170:
--
Hello!
So there are a fair few points above
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14361871#comment-14361871
]
Paul Magrath commented on THRIFT-3027:
--
Thank you!
Go compiler does not ensure
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351707#comment-14351707
]
Paul Magrath commented on THRIFT-3027:
--
Thanks for the feedback. I've incorporated
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351706#comment-14351706
]
Paul Magrath commented on THRIFT-3027:
--
Thanks for the feedback. I've incorporated
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Magrath updated THRIFT-3027:
-
Comment: was deleted
(was: Thanks for the feedback. I've incorporated it into the pull request
[
https://issues.apache.org/jira/browse/THRIFT-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351708#comment-14351708
]
Paul Magrath commented on THRIFT-3023:
--
Thank you!
Go compiler is a little overly
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Magrath updated THRIFT-3027:
-
Description:
In Go, as per https://github.com/golang/go/wiki/CodeReviewComments#initialisms
[
https://issues.apache.org/jira/browse/THRIFT-3027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Magrath updated THRIFT-3027:
-
Description:
In Go, as per https://github.com/golang/go/wiki/CodeReviewComments#initialisms
GitHub user Magrath opened a pull request:
https://github.com/apache/thrift/pull/394
THRIFT-3027 Ensure common initialisms in generated Go code have consistent
case
In Go, as per
https://github.com/golang/go/wiki/CodeReviewComments#initialisms, words in
names that are initialisms
Paul Magrath created THRIFT-3027:
Summary: Go compiler does not ensure common initialisms have
consistent case
Key: THRIFT-3027
URL: https://issues.apache.org/jira/browse/THRIFT-3027
Project: Thrift
Paul Magrath created THRIFT-3023:
Summary: Go compiler is a little overly conservative with names of
attributes
Key: THRIFT-3023
URL: https://issues.apache.org/jira/browse/THRIFT-3023
Project: Thrift
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/380#issuecomment-75808111
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/380#issuecomment-75808487
@pjjw From reading https://thrift.apache.org/docs/HowToContribute, looks
like pull requests need to reference the JIRA ticket number?
---
If your project is set up
Github user Magrath commented on the pull request:
https://github.com/apache/thrift/pull/380#issuecomment-75809082
Ah, cool, hopefully it'll get merged soon then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
37 matches
Mail list logo
