[jira] [Commented] (THRIFT-3182) TFramedTransport is in an invalid state after frame size exception

2015-07-08 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619915#comment-14619915 ] Mathias Herberts commented on THRIFT-3182: -- I was recently bitten by this i

Re: [jira] [Created] (THRIFT-1770) Killing a thrift 0.8 server with telnet

2012-12-01 Thread Mathias Herberts
I thought framed transports were the way to avoid those cases. On Dec 1, 2012 10:20 AM, "oliver z (JIRA)" wrote: > oliver z created THRIFT-1770: > - > > Summary: Killing a thrift 0.8 server with telnet > Key: THRIFT-1770 >

Thrift logo

2011-10-18 Thread Mathias Herberts
As I was working on my Hadoop World presentation, I was looking for an illustration for Thrift but could not find anything suitable. Is there such thing as a Thrift logo? Mathias.

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-30 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057952#comment-13057952 ] Mathias Herberts commented on THRIFT-1226: -- Since binary fields in 0.6.0+

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057545#comment-13057545 ] Mathias Herberts commented on THRIFT-1226: -- Prior to THRIFT-1038, Th

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057449#comment-13057449 ] Mathias Herberts commented on THRIFT-1226: -- What part of the java serializa

[jira] [Commented] (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serial

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057436#comment-13057436 ] Mathias Herberts commented on THRIFT-1038: -- Do you have a unit test to pro

[jira] [Updated] (THRIFT-1211) When using THttpClient, non 200 responses leave the connection open

2011-06-16 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1211: - Attachment: THRIFT-1211.patch > When using THttpClient, non 200 responses leave

[jira] [Created] (THRIFT-1211) When using THttpClient, non 200 responses leave the connection open

2011-06-16 Thread Mathias Herberts (JIRA)
Components: Java - Library Affects Versions: 0.6.1 Environment: All Reporter: Mathias Herberts Fix For: 0.7 The call to HttpClient.execute is done in a try/catch/finally which includes closing of entity's input stream in the finally clause

[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5

2011-03-23 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010507#comment-13010507 ] Mathias Herberts commented on THRIFT-633: - I haven't used JDK 1.5 in a

Re: [VOTE] Thrift 0.6.0 RC2

2011-01-31 Thread Mathias Herberts
+1

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-28 Thread Mathias Herberts
cMethodCallTimeoutComparator implements >> Comparator { >>    @Override >>    public int compare(TAsyncMethodCall left, TAsyncMethodCall right) { >> >> >> -Original Message- >> From: Christian Lavoie [mailto:christian.lav...@gmail.com] >> Sent: T

Re: [VOTE] Thrift 0.6.0 RC1

2011-01-27 Thread Mathias Herberts
+1 My GWT patch was successfully updated for this RC.

[jira] Commented: (THRIFT-1039) Refactor methods accessing binary data

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987279#action_12987279 ] Mathias Herberts commented on THRIFT-1039: -- How far down the road do you for

[jira] Commented: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Seriali

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987180#action_12987180 ] Mathias Herberts commented on THRIFT-1038: -- I agree we can settle on TCom

[jira] Updated: (THRIFT-1039) Refactor methods accessing binary data

2011-01-18 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1039: - Attachment: THRIFT-1039.patch Attached patch that replaces the 'byte[] getXxx()&#x

[jira] Closed: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-17 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts closed THRIFT-1035. Resolution: Won't Fix > Container types containing binary data are parameteri

[jira] Created: (THRIFT-1039) Refactor methods accessing binary data

2011-01-17 Thread Mathias Herberts (JIRA)
Environment: All Reporter: Mathias Herberts Priority: Minor Since THRIFT-830, binary fields are implemented using ByteBuffer. struct A { 1: binary bin_field, } will generate a method 'byte[] getBin_field()' which will optionally resize the underlying ByteBuffer

[jira] Updated: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializa

2011-01-13 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1038: - Attachment: THRIFT-1038.patch Adds writeObject/readObject methods. The Java

Re: Contribution process, adding Go language support

2011-01-12 Thread Mathias Herberts
On Thu, Jan 13, 2011 at 06:56, Bryan Duxbury wrote: > Tolliver - > > It'd be great if you created a JIRA ticket at > https://issues.apache.org/jira/browse/THRIFT. I don't know if we have any Go > developers in the project at this point, but I'm willing to do some reviews > if you put together dece

[jira] Created: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializa

2011-01-12 Thread Mathias Herberts (JIRA)
Environment: All Reporter: Mathias Herberts Assignee: Mathias Herberts Priority: Blocker Fix For: 0.6 Since THRIFT-830, binary fields are implemented using ByteBuffer instead of byte[], but ByteBuffer are not serializable (in the Java sense

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980441#action_12980441 ] Mathias Herberts commented on THRIFT-1035: -- I hear your arguments loud and c

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980406#action_12980406 ] Mathias Herberts commented on THRIFT-1035: -- I understand the performance ben

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980359#action_12980359 ] Mathias Herberts commented on THRIFT-1035: -- I see this issue as more th

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980333#action_12980333 ] Mathias Herberts commented on THRIFT-1035: -- I think developers using Th

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980326#action_12980326 ] Mathias Herberts commented on THRIFT-1035: -- I don't see how you can

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980300#action_12980300 ] Mathias Herberts commented on THRIFT-1035: -- If we go the way you suggest, ho

[jira] Updated: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1035: - Attachment: THRIFT-1035-2.patch New version of the patch which adds the generation of

[jira] Updated: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1035: - Attachment: THRIFT-1035.patch This patch modifies the Java generator so it generates

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-10 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979714#action_12979714 ] Mathias Herberts commented on THRIFT-1035: -- Another annoyance with ByteBuffe

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979488#action_12979488 ] Mathias Herberts commented on THRIFT-1035: -- I'd like to have feedba

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979435#action_12979435 ] Mathias Herberts commented on THRIFT-1035: -- Another problem arising from

[jira] Created: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
/THRIFT-1035 Project: Thrift Issue Type: Bug Components: Java - Compiler, Java - Library Affects Versions: 0.5, 0.4, 0.6, 0.7 Environment: All Reporter: Mathias Herberts Since THRIFT-830, binary fields are internally handled using ByteBuffer

Re: [VOTE] Thrift 0.6.0 RC0

2011-01-09 Thread Mathias Herberts
-1 As I was porting my GWT patch to 0.6.0, I realized that in Java, list, set and map<...,binary> or map now generate container types parameterized by ByteBuffer and not byte[], I'm not convinced this should be left as is after all the efforts that went into making sure the byte[] returning method

Re: Time to drop 0.6?

2010-11-15 Thread Mathias Herberts
+1 too

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-08 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929552#action_12929552 ] Mathias Herberts commented on THRIFT-970: - Indeed, should this pose a probl

[jira] Updated: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-04 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-970: Attachment: THRIFT-970-2 Patch which modifies THttpClient to offer both implementations

[jira] Commented: (THRIFT-414) Support non-UTF-8 in Java and C#

2010-11-03 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927761#action_12927761 ] Mathias Herberts commented on THRIFT-414: - Since most comments seem to agree

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-02 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927600#action_12927600 ] Mathias Herberts commented on THRIFT-970: - I could merge THttpClient

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-10-28 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925735#action_12925735 ] Mathias Herberts commented on THRIFT-970: - My tests show that if you