[jira] [Commented] (THRIFT-3182) TFramedTransport is in an invalid state after frame size exception

2015-07-08 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14619915#comment-14619915 ] Mathias Herberts commented on THRIFT-3182: -- I was recently bitten by this issue,

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-30 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057952#comment-13057952 ] Mathias Herberts commented on THRIFT-1226: -- Since binary fields in 0.6.0+ are ba

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057545#comment-13057545 ] Mathias Herberts commented on THRIFT-1226: -- Prior to THRIFT-1038, Thrift structu

[jira] [Commented] (THRIFT-1226) command line option to disable overriding java serialization

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057449#comment-13057449 ] Mathias Herberts commented on THRIFT-1226: -- What part of the java serialization

[jira] [Commented] (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serial

2011-06-29 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057436#comment-13057436 ] Mathias Herberts commented on THRIFT-1038: -- Do you have a unit test to provide?

[jira] [Updated] (THRIFT-1211) When using THttpClient, non 200 responses leave the connection open

2011-06-16 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1211: - Attachment: THRIFT-1211.patch > When using THttpClient, non 200 responses leave the conn

[jira] [Created] (THRIFT-1211) When using THttpClient, non 200 responses leave the connection open

2011-06-16 Thread Mathias Herberts (JIRA)
When using THttpClient, non 200 responses leave the connection open --- Key: THRIFT-1211 URL: https://issues.apache.org/jira/browse/THRIFT-1211 Project: Thrift Issue Type: Bug

[jira] [Commented] (THRIFT-633) Generated code has @Override annotations which won't compile using Apple's JDK 1.5

2011-03-23 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010507#comment-13010507 ] Mathias Herberts commented on THRIFT-633: - I haven't used JDK 1.5 in a while but I

[jira] Commented: (THRIFT-1039) Refactor methods accessing binary data

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987279#action_12987279 ] Mathias Herberts commented on THRIFT-1039: -- How far down the road do you foresee

[jira] Commented: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Seriali

2011-01-26 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12987180#action_12987180 ] Mathias Herberts commented on THRIFT-1038: -- I agree we can settle on TCompact and

[jira] Updated: (THRIFT-1039) Refactor methods accessing binary data

2011-01-18 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1039: - Attachment: THRIFT-1039.patch Attached patch that replaces the 'byte[] getXxx()' method

[jira] Closed: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-17 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts closed THRIFT-1035. Resolution: Won't Fix > Container types containing binary data are parameterized with Byte

[jira] Created: (THRIFT-1039) Refactor methods accessing binary data

2011-01-17 Thread Mathias Herberts (JIRA)
Refactor methods accessing binary data -- Key: THRIFT-1039 URL: https://issues.apache.org/jira/browse/THRIFT-1039 Project: Thrift Issue Type: Improvement Components: Java - Compiler Envi

[jira] Updated: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializa

2011-01-13 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1038: - Attachment: THRIFT-1038.patch Adds writeObject/readObject methods. The Java serializati

[jira] Created: (THRIFT-1038) Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializa

2011-01-12 Thread Mathias Herberts (JIRA)
Generated Java code for structures containing binary fields (or collections thereof) are not serializable (in the Java sense) even though they implement java.io.Serializable ---

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980441#action_12980441 ] Mathias Herberts commented on THRIFT-1035: -- I hear your arguments loud and clear,

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980406#action_12980406 ] Mathias Herberts commented on THRIFT-1035: -- I understand the performance benefit

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980359#action_12980359 ] Mathias Herberts commented on THRIFT-1035: -- I see this issue as more than a backw

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980333#action_12980333 ] Mathias Herberts commented on THRIFT-1035: -- I think developers using Thrift expec

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980326#action_12980326 ] Mathias Herberts commented on THRIFT-1035: -- I don't see how you can catch the put

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980300#action_12980300 ] Mathias Herberts commented on THRIFT-1035: -- If we go the way you suggest, how do

[jira] Updated: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1035: - Attachment: THRIFT-1035-2.patch New version of the patch which adds the generation of an

[jira] Updated: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-11 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-1035: - Attachment: THRIFT-1035.patch This patch modifies the Java generator so it generates byt

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-10 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979714#action_12979714 ] Mathias Herberts commented on THRIFT-1035: -- Another annoyance with ByteBuffer is

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979488#action_12979488 ] Mathias Herberts commented on THRIFT-1035: -- I'd like to have feedback on the foll

[jira] Commented: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979435#action_12979435 ] Mathias Herberts commented on THRIFT-1035: -- Another problem arising from this, ev

[jira] Created: (THRIFT-1035) Container types containing binary data are parameterized with ByteBuffer in the generated Java code

2011-01-09 Thread Mathias Herberts (JIRA)
Container types containing binary data are parameterized with ByteBuffer in the generated Java code --- Key: THRIFT-1035 URL: https://issues.apache.org/jira/browse/THR

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-08 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929552#action_12929552 ] Mathias Herberts commented on THRIFT-970: - Indeed, should this pose a problem I can

[jira] Updated: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-04 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathias Herberts updated THRIFT-970: Attachment: THRIFT-970-2 Patch which modifies THttpClient to offer both implementations. W

[jira] Commented: (THRIFT-414) Support non-UTF-8 in Java and C#

2010-11-03 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927761#action_12927761 ] Mathias Herberts commented on THRIFT-414: - Since most comments seem to agree that T

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-11-02 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927600#action_12927600 ] Mathias Herberts commented on THRIFT-970: - I could merge THttpClient and THttpTrans

[jira] Commented: (THRIFT-970) Under heavy load, THttpClient may fail with "too many open files"

2010-10-28 Thread Mathias Herberts (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12925735#action_12925735 ] Mathias Herberts commented on THRIFT-970: - My tests show that if you use THttpTrans