[jira] [Commented] (THRIFT-5297) Improve TThreadPoolServer Handling of Incoming Connections

[ https://issues.apache.org/jira/browse/THRIFT-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220954#comment-17220954 ] Qinghui Xu commented on THRIFT-5297: Hello [~belugabehr] Thanks for bringing this up. I though have

[jira] [Commented] (THRIFT-4720) Drop support for C++03/C++98 and begin refactoring

[ https://issues.apache.org/jira/browse/THRIFT-4720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173894#comment-17173894 ] Qinghui Xu commented on THRIFT-4720: Is it possible to backport this 0.12.0 branch? In fact in some

[jira] [Commented] (THRIFT-4889) Add SASL support for non-blocking server

[ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993941#comment-16993941 ] Qinghui Xu commented on THRIFT-4889: Thanks [~jensg] for merging my patches. As this is only tested

[jira] [Closed] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu closed THRIFT-4124. -- Resolution: Not A Problem > Connection to non-thrift server crashes android app >

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984292#comment-16984292 ] Qinghui Xu commented on THRIFT-4124: Thanks for the hint [~dcelasun] I would be glad to review the

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983951#comment-16983951 ] Qinghui Xu commented on THRIFT-4124: Have a quick look at THRIFT-5021 and it seems it is currently

[jira] [Created] (THRIFT-5038) Implement MAX_MESSAGE_SIZE for java TTransport

Qinghui Xu created THRIFT-5038: -- Summary: Implement MAX_MESSAGE_SIZE for java TTransport Key: THRIFT-5038 URL: https://issues.apache.org/jira/browse/THRIFT-5038 Project: Thrift Issue Type:

[jira] [Created] (THRIFT-5037) Documentation for thrift transport configuration

Qinghui Xu created THRIFT-5037: -- Summary: Documentation for thrift transport configuration Key: THRIFT-5037 URL: https://issues.apache.org/jira/browse/THRIFT-5037 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983336#comment-16983336 ] Qinghui Xu commented on THRIFT-4124: > 

[jira] [Assigned] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu reassigned THRIFT-4124: -- Assignee: Qinghui Xu > Connection to non-thrift server crashes android app >

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982532#comment-16982532 ] Qinghui Xu commented on THRIFT-4124: [~Alexey_A] Is my answer clear and can we close the ticket? >

[jira] [Created] (THRIFT-5031) Fix javadoc of TIOStreamTransport

Qinghui Xu created THRIFT-5031: -- Summary: Fix javadoc of TIOStreamTransport Key: THRIFT-5031 URL: https://issues.apache.org/jira/browse/THRIFT-5031 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-5022) TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.

[ https://issues.apache.org/jira/browse/THRIFT-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980121#comment-16980121 ] Qinghui Xu commented on THRIFT-5022: And thanks for the fix > TIOStreamTransport.isOpen is false

[jira] [Commented] (THRIFT-5022) TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.

[ https://issues.apache.org/jira/browse/THRIFT-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980118#comment-16980118 ] Qinghui Xu commented on THRIFT-5022: Using a finally clause is definitly better for doing the

[jira] [Commented] (THRIFT-5022) TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.

[ https://issues.apache.org/jira/browse/THRIFT-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978780#comment-16978780 ] Qinghui Xu commented on THRIFT-5022: Yes, My concern is that there might be some uncaught errors

[jira] [Commented] (THRIFT-5022) TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.

[ https://issues.apache.org/jira/browse/THRIFT-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978708#comment-16978708 ] Qinghui Xu commented on THRIFT-5022: When I fixed THRIFT-2530, I did not notice such use cases of

[jira] [Commented] (THRIFT-4889) [Java] Add SASL support for non-blocking server

[ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977518#comment-16977518 ] Qinghui Xu commented on THRIFT-4889: We are testing this patch by using it in hive metastore since a

[jira] [Commented] (THRIFT-4252) Cannot shutdown Java server when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976148#comment-16976148 ] Qinghui Xu commented on THRIFT-4252: It would be nice to get a review on the PR. To grasp the idea

[jira] [Updated] (THRIFT-5008) Add a logger line in case of failing to dispose sasl

[ https://issues.apache.org/jira/browse/THRIFT-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-5008: --- Component/s: Java - Library > Add a logger line in case of failing to dispose sasl >

[jira] [Assigned] (THRIFT-5008) Add a logger line in case of failing to dispose sasl

[ https://issues.apache.org/jira/browse/THRIFT-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu reassigned THRIFT-5008: -- Assignee: Qinghui Xu > Add a logger line in case of failing to dispose sasl >

[jira] [Updated] (THRIFT-5008) Add a logger line in case of failing to dispose sasl

[ https://issues.apache.org/jira/browse/THRIFT-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-5008: --- Labels: pull-request-available (was: ) > Add a logger line in case of failing to dispose sasl >

[jira] [Created] (THRIFT-5008) Add a logger line in case of failing to dispose sasl

Qinghui Xu created THRIFT-5008: -- Summary: Add a logger line in case of failing to dispose sasl Key: THRIFT-5008 URL: https://issues.apache.org/jira/browse/THRIFT-5008 Project: Thrift Issue

[jira] [Created] (THRIFT-4993) Add docs for version lifecycle management

Qinghui Xu created THRIFT-4993: -- Summary: Add docs for version lifecycle management Key: THRIFT-4993 URL: https://issues.apache.org/jira/browse/THRIFT-4993 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-4993) Add docs for version lifecycle management

[ https://issues.apache.org/jira/browse/THRIFT-4993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-4993: --- Component/s: Documentation > Add docs for version lifecycle management >

[jira] [Commented] (THRIFT-4976) Docker build: Test failure for `StalenessCheckTest` on MacOS

[ https://issues.apache.org/jira/browse/THRIFT-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954926#comment-16954926 ] Qinghui Xu commented on THRIFT-4976: In docker container, the file system is mounted as `osxfs`.

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953524#comment-16953524 ] Qinghui Xu commented on THRIFT-4124: In this particular case, it is tricky to fix it: * When an OOM

[jira] [Commented] (THRIFT-4937) Apache HttpCore 4.4.1 reached EoS

[ https://issues.apache.org/jira/browse/THRIFT-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953188#comment-16953188 ] Qinghui Xu commented on THRIFT-4937: [~egonsur] Maybe you are interested to submit a PR? > Apache

[jira] [Commented] (THRIFT-3969) Port from SLF4J to Log4j 2

[ https://issues.apache.org/jira/browse/THRIFT-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953143#comment-16953143 ] Qinghui Xu commented on THRIFT-3969: I'm not sure that refactoring a big part of the code base just

[jira] [Commented] (THRIFT-4124) Connection to non-thrift server crashes android app

[ https://issues.apache.org/jira/browse/THRIFT-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953131#comment-16953131 ] Qinghui Xu commented on THRIFT-4124: In fact you cannot catch the error because your RPC is

[jira] [Comment Edited] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953108#comment-16953108 ] Qinghui Xu edited comment on THRIFT-4928 at 10/16/19 7:00 PM: -- It seems to

[jira] [Commented] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953108#comment-16953108 ] Qinghui Xu commented on THRIFT-4928: It seems to me there are a lot of duplicated tickets #

[jira] [Commented] (THRIFT-4937) Apache HttpCore 4.4.1 reached EoS

[ https://issues.apache.org/jira/browse/THRIFT-4937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952773#comment-16952773 ] Qinghui Xu commented on THRIFT-4937: I suggest to upgrade to 4.4.12 for apache httpcore. > Apache

[jira] [Assigned] (THRIFT-4252) Cannot shutdown Java server when clients are still connected

[ https://issues.apache.org/jira/browse/THRIFT-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu reassigned THRIFT-4252: -- Assignee: Qinghui Xu > Cannot shutdown Java server when clients are still connected >

[jira] [Commented] (THRIFT-4949) improve HTTP/1 server test case

[ https://issues.apache.org/jira/browse/THRIFT-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951296#comment-16951296 ] Qinghui Xu commented on THRIFT-4949: The PR looks good to me. > improve HTTP/1 server test case >

[jira] [Updated] (THRIFT-4976) Docker build: Test failure for `StalenessCheckTest` on MacOS

[ https://issues.apache.org/jira/browse/THRIFT-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-4976: --- Labels: pull-request-available (was: ) > Docker build: Test failure for `StalenessCheckTest` on

[jira] [Assigned] (THRIFT-4976) Docker build: Test failure for `StalenessCheckTest` on MacOS

[ https://issues.apache.org/jira/browse/THRIFT-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu reassigned THRIFT-4976: -- Assignee: Qinghui Xu > Docker build: Test failure for `StalenessCheckTest` on MacOS >

[jira] [Commented] (THRIFT-4976) Docker build: Test failure for `StalenessCheckTest` on MacOS

[ https://issues.apache.org/jira/browse/THRIFT-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950465#comment-16950465 ] Qinghui Xu commented on THRIFT-4976: I would suggest to put the delay to 1.0 second to make sure the

[jira] [Created] (THRIFT-4976) Docker build: Test failure for `StalenessCheckTest` on MacOS

Qinghui Xu created THRIFT-4976: -- Summary: Docker build: Test failure for `StalenessCheckTest` on MacOS Key: THRIFT-4976 URL: https://issues.apache.org/jira/browse/THRIFT-4976 Project: Thrift

[jira] [Commented] (THRIFT-4949) improve HTTP/1 server test case

[ https://issues.apache.org/jira/browse/THRIFT-4949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947633#comment-16947633 ] Qinghui Xu commented on THRIFT-4949: I can have a look on the PR. > improve HTTP/1 server test case

[jira] [Commented] (THRIFT-4889) [Java] Add SASL support for non-blocking server

[ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945695#comment-16945695 ] Qinghui Xu commented on THRIFT-4889: [~atm], [~tlipcon], [~dreiss] Hello, guys, maybe you could

[jira] [Assigned] (THRIFT-4889) [Java] Add SASL support for non-blocking server

[ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu reassigned THRIFT-4889: -- Assignee: Qinghui Xu > [Java] Add SASL support for non-blocking server >

[jira] [Updated] (THRIFT-4889) [Java] Add SASL support for non-blocking server

[ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-4889: --- Labels: pull-request-available (was: ) > [Java] Add SASL support for non-blocking server >

[jira] [Updated] (THRIFT-4966) Git ignore files generated by the build

[ https://issues.apache.org/jira/browse/THRIFT-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-4966: --- Description: There are some artifacts generated by the build that should be gitignored:   - 

[jira] [Created] (THRIFT-4966) Git ignore files generated by the build

Qinghui Xu created THRIFT-4966: -- Summary: Git ignore files generated by the build Key: THRIFT-4966 URL: https://issues.apache.org/jira/browse/THRIFT-4966 Project: Thrift Issue Type: Improvement

[jira] [Commented] (THRIFT-2530) TIOStreamTransport's isOpen() always be true even if close() was called.

[ https://issues.apache.org/jira/browse/THRIFT-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942634#comment-16942634 ] Qinghui Xu commented on THRIFT-2530: I've sent a PR, could somebody help me to review it? >

[jira] [Commented] (THRIFT-4943) org.apache.thrift.transport.TTransportException: null

[ https://issues.apache.org/jira/browse/THRIFT-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935419#comment-16935419 ] Qinghui Xu commented on THRIFT-4943: I think we can close this one? cc [~jking3] [~nsuke] >

[jira] [Commented] (THRIFT-4943) org.apache.thrift.transport.TTransportException: null

[ https://issues.apache.org/jira/browse/THRIFT-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935418#comment-16935418 ] Qinghui Xu commented on THRIFT-4943: It seems this is related to THRIFT-4805, though it is addressed

[jira] [Comment Edited] (THRIFT-2530) TIOStreamTransport's isOpen() always be true even if close() was called.

[ https://issues.apache.org/jira/browse/THRIFT-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934785#comment-16934785 ] Qinghui Xu edited comment on THRIFT-2530 at 9/20/19 9:46 PM: - This indeed

[jira] [Commented] (THRIFT-2530) TIOStreamTransport's isOpen() always be true even if close() was called.

[ https://issues.apache.org/jira/browse/THRIFT-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934785#comment-16934785 ] Qinghui Xu commented on THRIFT-2530: This indeed looks like an anti pattern behavior. I'll propose a

[jira] [Commented] (THRIFT-4958) TSocket: timed out reading 4 bytes from server:port

[ https://issues.apache.org/jira/browse/THRIFT-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934780#comment-16934780 ] Qinghui Xu commented on THRIFT-4958: [~dedipyaman] No problem, I saw Jens already did the work.

[jira] [Commented] (THRIFT-4858) Java TThreadPoolServer: confusing error message on closed socket

[ https://issues.apache.org/jira/browse/THRIFT-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934777#comment-16934777 ] Qinghui Xu commented on THRIFT-4858: [~nsuke] Indeed, it seems the PR should have filtered out this

[jira] [Commented] (THRIFT-4858) Java TThreadPoolServer: confusing error message on closed socket

[ https://issues.apache.org/jira/browse/THRIFT-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934230#comment-16934230 ] Qinghui Xu commented on THRIFT-4858: [~mczajkow] To summarize, the error messages you see are not

[jira] [Commented] (THRIFT-4858) Java TThreadPoolServer: confusing error message on closed socket

[ https://issues.apache.org/jira/browse/THRIFT-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934224#comment-16934224 ] Qinghui Xu commented on THRIFT-4858: [~nsuke] I don't think it's related to THRIFT-3769 , neither

[jira] [Commented] (THRIFT-4958) TSocket: timed out reading 4 bytes from server:port

[ https://issues.apache.org/jira/browse/THRIFT-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933708#comment-16933708 ] Qinghui Xu commented on THRIFT-4958: Glad that you figure out the problem. In this case, can you

[jira] [Comment Edited] (THRIFT-4958) TSocket: timed out reading 4 bytes from server:port

[ https://issues.apache.org/jira/browse/THRIFT-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932780#comment-16932780 ] Qinghui Xu edited comment on THRIFT-4958 at 9/18/19 7:58 PM: - My

[jira] [Commented] (THRIFT-4958) TSocket: timed out reading 4 bytes from server:port

[ https://issues.apache.org/jira/browse/THRIFT-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932780#comment-16932780 ] Qinghui Xu commented on THRIFT-4958: My theory/guess is that the thrift server is over loaded, and

[jira] [Commented] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932758#comment-16932758 ] Qinghui Xu commented on THRIFT-4928: [~jensg] In the first place, these numbers should not be

[jira] [Commented] (THRIFT-4928) Sensitive information about expected and actual reading lengths (len, got) is leaked from TIOStreamTransport to TTransport through a TTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932622#comment-16932622 ] Qinghui Xu commented on THRIFT-4928: [~xiaoqin.fu] [~pengzhouhu] Why do you think putting the byte

[jira] [Commented] (THRIFT-4958) TSocket: timed out reading 4 bytes from server:port

[ https://issues.apache.org/jira/browse/THRIFT-4958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932592#comment-16932592 ] Qinghui Xu commented on THRIFT-4958: It seems more like a problem from the server side if restarting

[jira] [Created] (THRIFT-4889) [Java] Add SASL support for non-blocking server

Qinghui Xu created THRIFT-4889: -- Summary: [Java] Add SASL support for non-blocking server Key: THRIFT-4889 URL: https://issues.apache.org/jira/browse/THRIFT-4889 Project: Thrift Issue Type:

[jira] [Updated] (THRIFT-4773) TSaslTransport should relay underlying TTransportException to TSaslTransportException

[ https://issues.apache.org/jira/browse/THRIFT-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qinghui Xu updated THRIFT-4773: --- Description: For java lib: Currently when opening TsaslTransport, it will raise 

[jira] [Created] (THRIFT-4773) TSaslTransport should relay underlying TTransportException to TSaslTransportException

Qinghui Xu created THRIFT-4773: -- Summary: TSaslTransport should relay underlying TTransportException to TSaslTransportException Key: THRIFT-4773 URL: https://issues.apache.org/jira/browse/THRIFT-4773