Github user abadcafe closed the pull request at:
https://github.com/apache/thrift/pull/422
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user abadcafe commented on a diff in the pull request:
https://github.com/apache/thrift/pull/422#discussion_r28510532
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1393,9 +1397,42 @@ bool
TNonblockingIOThread::notify(TNonblockingServer::TConnection
Github user abadcafe commented on a diff in the pull request:
https://github.com/apache/thrift/pull/422#discussion_r28532945
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1393,9 +1397,42 @@ bool
TNonblockingIOThread::notify(TNonblockingServer::TConnection
Github user abadcafe commented on a diff in the pull request:
https://github.com/apache/thrift/pull/422#discussion_r27766767
--- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp ---
@@ -1393,9 +1394,39 @@ bool
TNonblockingIOThread::notify(TNonblockingServer::TConnection
GitHub user abadcafe opened a pull request:
https://github.com/apache/thrift/pull/422
THRIFT-3080: fix connection leak of C++ Nonblocking Server while huge nu...
...mber connections are accepted and unix socket stream fd is busy.
You can merge this pull request into a Git
GitHub user abadcafe opened a pull request:
https://github.com/apache/thrift/pull/248
THRIFT-2788: enable TCP keep alive for sockets in java lib.
Both client and server sockets in Java were not enable tcp keepalive.
This is important for reap dead tcp connections