[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2016-01-15 Thread adamconnelly
Github user adamconnelly commented on the pull request: https://github.com/apache/thrift/pull/762#issuecomment-171905232 @Jens-G Thanks for accepting this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2016-01-10 Thread adamconnelly
Github user adamconnelly commented on the pull request: https://github.com/apache/thrift/pull/762#issuecomment-170354621 Yeah, I already changed my settings to spaces for indentation, and two spaces for indents, which seemed to be what the existing code was using. It's just

[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2016-01-09 Thread adamconnelly
Github user adamconnelly commented on the pull request: https://github.com/apache/thrift/pull/762#issuecomment-170280633 Not quite sure if you're asking about my last comment, but what I was asking was whether you wanted me to change what I'd done to just use the existing ```async

[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2016-01-09 Thread adamconnelly
Github user adamconnelly commented on the pull request: https://github.com/apache/thrift/pull/762#issuecomment-170265874 Well let me know what you want me to do - obviously the lazy part of me doesn't mind if you want to make the change yourself to just use the existing async flag

[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2016-01-08 Thread adamconnelly
Github user adamconnelly commented on the pull request: https://github.com/apache/thrift/pull/762#issuecomment-170170922 Cheers for the feedback - I'll try to sort all tha . I'm not quite sure what the minimum version of mono is, but I'll find out. I added the new project

[GitHub] thrift pull request: THRIFT-3510 Add HttpTaskAsyncHandler implemen...

2015-12-26 Thread adamconnelly
GitHub user adamconnelly opened a pull request: https://github.com/apache/thrift/pull/762 THRIFT-3510 Add HttpTaskAsyncHandler implementation The THttpHandler doesn't support an async pipeline. This means that it's difficult for service implementations to make async calls. I've