Github user afds commented on the issue:
https://github.com/apache/thrift/pull/1254
The test is called TestDeepCopy and it uses entities defined in
JavaDeepCopyTest.thrift file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user afds commented on the issue:
https://github.com/apache/thrift/pull/1254
Are you sure? I don't really understand what should I update there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user afds opened a pull request:
https://github.com/apache/thrift/pull/1254
THRIFT-4177 fix java deep copy
Java compiler produces deep copy constructor that could make shallow copy
instead.
You can merge this pull request into a Git repository by running:
$ git pull
Github user afds commented on the issue:
https://github.com/apache/thrift/pull/627
Created a new pull request here: https://github.com/apache/thrift/pull/1253
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user afds opened a pull request:
https://github.com/apache/thrift/pull/1253
THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afds/thrift THRIFT-3357
Github user afds closed the pull request at:
https://github.com/apache/thrift/pull/627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user afds commented on the pull request:
https://github.com/apache/thrift/pull/627#issuecomment-143589859
I'm perfectly fine to make it default.
Theoretically possible issues is that someone heavily relies on
HashMap/HashSet or uses _null_ keys/elements (En
Github user afds commented on the pull request:
https://github.com/apache/thrift/pull/627#issuecomment-143475735
https://issues.apache.org/jira/browse/THRIFT-3357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user afds opened a pull request:
https://github.com/apache/thrift/pull/627
THRIFT-3357: enum_containers option to generate EnumSet/EnumMap
Additional java compiler option to generate EnumSet/EnumMap instead
of HashSet/HashMap where elements/keys are enums.
You can merge