[GitHub] thrift issue #1254: THRIFT-4177 fix java deep copy

2017-04-19 Thread afds
Github user afds commented on the issue: https://github.com/apache/thrift/pull/1254 The test is called TestDeepCopy and it uses entities defined in JavaDeepCopyTest.thrift file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] thrift issue #1254: THRIFT-4177 fix java deep copy

2017-04-18 Thread afds
Github user afds commented on the issue: https://github.com/apache/thrift/pull/1254 Are you sure? I don't really understand what should I update there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request #1254: THRIFT-4177 fix java deep copy

2017-04-18 Thread afds
GitHub user afds opened a pull request: https://github.com/apache/thrift/pull/1254 THRIFT-4177 fix java deep copy Java compiler produces deep copy constructor that could make shallow copy instead. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] thrift issue #627: THRIFT-3357: enum_containers option to generate EnumSet/E...

2017-04-17 Thread afds
Github user afds commented on the issue: https://github.com/apache/thrift/pull/627 Created a new pull request here: https://github.com/apache/thrift/pull/1253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request #1253: THRIFT-3357: Generate EnumSet/EnumMap where eleme...

2017-04-17 Thread afds
GitHub user afds opened a pull request: https://github.com/apache/thrift/pull/1253 THRIFT-3357: Generate EnumSet/EnumMap where elements/keys are enums You can merge this pull request into a Git repository by running: $ git pull https://github.com/afds/thrift THRIFT-3357

[GitHub] thrift pull request #627: THRIFT-3357: enum_containers option to generate En...

2017-04-17 Thread afds
Github user afds closed the pull request at: https://github.com/apache/thrift/pull/627 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-27 Thread afds
Github user afds commented on the pull request: https://github.com/apache/thrift/pull/627#issuecomment-143589859 I'm perfectly fine to make it default. Theoretically possible issues is that someone heavily relies on HashMap/HashSet or uses _null_ keys/elements (En

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-26 Thread afds
Github user afds commented on the pull request: https://github.com/apache/thrift/pull/627#issuecomment-143475735 https://issues.apache.org/jira/browse/THRIFT-3357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] thrift pull request: THRIFT-3357: enum_containers option to genera...

2015-09-26 Thread afds
GitHub user afds opened a pull request: https://github.com/apache/thrift/pull/627 THRIFT-3357: enum_containers option to generate EnumSet/EnumMap Additional java compiler option to generate EnumSet/EnumMap instead of HashSet/HashMap where elements/keys are enums. You can merge