GitHub user aloneguid opened a pull request:
https://github.com/apache/thrift/pull/1355
Minimal C# library version for .NET Standard 1.4, 1.6, .NET 4.5.1
This adds another project type to C# library which allows it to be build
for .NET Standard 1.4, 1.6 and .NET 4.5.1. The project
Github user aloneguid commented on the issue:
https://github.com/apache/thrift/pull/1355
@Jens-G THRIFTCORE is a simple pre-processor directive which when set
excludes files which require dependency on external libraries in .NET Standard,
essentially producing a minimal library of
Github user aloneguid commented on the issue:
https://github.com/apache/thrift/pull/1355
@gideonkorir from what I can see .net core lib was created in times when
.net core was in early stages, has some classes renamed and doesn't align with
existing csharp project. There is no
Github user aloneguid commented on the issue:
https://github.com/apache/thrift/pull/1355
I'm more than happy to do that. @Jens-G in .net ecosystem nuget package
manager is quite popular, do you have any guidance how we can automatically
publish this as you do with Maven?
---
Github user aloneguid commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1355#discussion_r138439390
--- Diff: lib/csharp/src/Thrift.sln ---
@@ -1,6 +1,8 @@

-Microsoft Visual Studio Solution File, Format Version 11.00
-# Visual Studio
Github user aloneguid commented on the issue:
https://github.com/apache/thrift/pull/1355
@gideonkorir 1.1 is fine unless we hit some limitations. Generally 1.4 is
the "safe" version of .net standard, which can be used on embedded devices,
clusters, desktops etc. However
Github user aloneguid closed the pull request at:
https://github.com/apache/thrift/pull/1355
---
Github user aloneguid commented on the issue:
https://github.com/apache/thrift/pull/1355
Sorry guys I'm giving up. Personally I think getting a real value from
contributing to main repo is not worth the effort due to many showstoppers.
This may be a reason why there are so
