[GitHub] thrift issue #1135: THRIFT-3981 Enable analyzer strong mode in Dart library

2016-12-12 Thread brianshannan-wf
Github user brianshannan-wf commented on the issue: https://github.com/apache/thrift/pull/1135 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift issue #1068: THRIFT-3905 Initialize bool, int, and double properties

2016-08-29 Thread brianshannan-wf
Github user brianshannan-wf commented on the issue: https://github.com/apache/thrift/pull/1068 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift issue #1068: THRIFT-3905 Initialize bool, int, and double properties

2016-08-29 Thread brianshannan-wf
Github user brianshannan-wf commented on the issue: https://github.com/apache/thrift/pull/1068 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift issue #1023: THRIFT-3849

2016-06-07 Thread brianshannan-wf
Github user brianshannan-wf commented on the issue: https://github.com/apache/thrift/pull/1023 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift issue #1023: THRIFT-3849

2016-06-06 Thread brianshannan-wf
Github user brianshannan-wf commented on the issue: https://github.com/apache/thrift/pull/1023 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] thrift pull request #1023: THRIFT-3849

2016-06-06 Thread brianshannan-wf
Github user brianshannan-wf commented on a diff in the pull request: https://github.com/apache/thrift/pull/1023#discussion_r65955275 --- Diff: lib/dart/lib/src/serializer/t_serializer.dart --- @@ -0,0 +1,43 @@ +/// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...

2016-05-26 Thread brianshannan-wf
Github user brianshannan-wf closed the pull request at: https://github.com/apache/thrift/pull/1017 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...

2016-05-25 Thread brianshannan-wf
Github user brianshannan-wf commented on the pull request: https://github.com/apache/thrift/pull/1019#issuecomment-221676733 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...

2016-05-24 Thread brianshannan-wf
GitHub user brianshannan-wf opened a pull request: https://github.com/apache/thrift/pull/1017 thrift-3841: dart compact protocol incorrectly serializes doubles The compact protocol expects doubles to be serialized/deserialized with a little endian byte order instead of with a

[GitHub] thrift pull request: THRIFT-3702 Fix cross tests for Dart compact ...

2016-03-01 Thread brianshannan-wf
Github user brianshannan-wf commented on the pull request: https://github.com/apache/thrift/pull/917#issuecomment-190943506 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift pull request: THRIFT-3637: Dart compact protocol

2016-02-29 Thread brianshannan-wf
GitHub user brianshannan-wf opened a pull request: https://github.com/apache/thrift/pull/916 THRIFT-3637: Dart compact protocol https://issues.apache.org/jira/browse/THRIFT-3637 You can merge this pull request into a Git repository by running: $ git pull https://github.com